Skip to contentSkip to conversation

xfstests: make sure tests check for loop device support

PATCH New Brian Foster 1 participant 1 message May 14, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: make sure tests check for loop device support

Several tests happen to make use of loop device support without the requisite pre-test checks. This results in spurious failures for systems that might not have loop device support. Add _require_loop checks to shared/298, xfs/206 and xfs/259.

---
 tests/shared/298 | 1 +
 tests/xfs/206    | 1 +
 tests/xfs/259    | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)
tests/shared/298 +1 -0
index f13c14b..8211da3 100755
@@ -32,6 +32,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 _supported_fs ext4 xfs
 _supported_os Linux
+_require_loop
 _require_fstrim
 _require_xfs_io_command "fiemap"
 _require_fs_space $TEST_DIR 307200
tests/xfs/206 +1 -0
index 0bbd595..f739597 100755
@@ -53,6 +53,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs xfs
 _supported_os IRIX Linux
+_require_loop
 
 bitsperlong=`src/feature -w`
 if [ "$bitsperlong" -ne 64 ]; then
tests/xfs/259 +1 -1
index b8bd69a..8241d94 100755
@@ -41,7 +41,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
 # real QA test starts here
 _supported_fs xfs
 _supported_os Linux
-
+_require_loop
 _require_math
 
 testfile=$TEST_DIR/259.image
Signature · 6 lines
1.8.3.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs