pull request: batman-adv 20140518

PATCH New Antonio Quartulli 2 participants 5 messages May 18, 2014 – May 19, 2014

Subsystems (3)

Networking Network drivers Batman advanced

lore

Share & tools

lore

Antonio Quartulli

author

2014-05-18 17:58 UTC #0 lore raw

Hello David,

here you have our pull request for net-next.

Unfortunately this time we have nothing exciting for you (as you may have seen we preferred to focus on bug fixing during the last period).

Patch 1 and 2 slightly improve our codestyle in order to respect two new checks that have been recently introduced in checkpatch.

Patch 3 is just increasing our internal version number.

Please pull or let me know of any problem.

Thanks a lot!
Antonio

The following changes since commit 33fcc5e05ea2b43ce0c6d356424ee5e25406f4c2:

Merge branch 'cdc_ncm-coalesce' (2014-05-16 22:39:13 -0400)

are available in the git repository at:

git://git.open-mesh.org/linux-merge.git tags/batman-adv-for-davem

for you to fetch changes up to 871d3d9fdf1c2fb58927080c8e96edccb1fee010:

batman-adv: Start new development cycle (2014-05-18 15:04:00 +0200)

----------------------------------------------------------------
Included changes:
- fix codestyle to respect new checkpatch warnings
- increase internal version number

----------------------------------------------------------------
Antonio Quartulli (2):
batman-adv: add blank line between declarations and the rest of the code
batman-adv: remove semi-colon after macro definition

Simon Wunderlich (1):
batman-adv: Start new development cycle

 net/batman-adv/debugfs.c               | 13 +++++++++++--
 net/batman-adv/distributed-arp-table.c |  1 +
 net/batman-adv/main.h                  |  2 +-
 net/batman-adv/network-coding.c        |  1 +
 net/batman-adv/sysfs.c                 | 14 ++++++++++++--
 5 files changed, 26 insertions(+), 5 deletions(-)

Antonio Quartulli

author

2014-05-18 17:58 UTC #1 lore raw

PATCH 1/3 batman-adv: add blank line between declarations and the rest of the code

Reported by checkpatch with the following message:
"WARNING: Missing a blank line after declarations"

Signed-off-by Antonio Quartulli <[email protected]>

Signed-off-by Marek Lindner <[email protected]>

---
 net/batman-adv/debugfs.c               |  9 +++++++++
 net/batman-adv/distributed-arp-table.c |  1 +
 net/batman-adv/network-coding.c        |  1 +
 net/batman-adv/sysfs.c                 | 10 ++++++++++
 4 files changed, 21 insertions(+)

net/batman-adv/debugfs.c +9 -0

index b758881..99f2ba0 100644
@@ -245,6 +245,7 @@ static int batadv_algorithms_open(struct inode *inode, struct file *file)
 static int batadv_originators_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_orig_seq_print_text, net_dev);
 }

@@ -258,18 +259,21 @@ static int batadv_originators_hardif_open(struct inode *inode,
 					  struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_orig_hardif_seq_print_text, net_dev);
 }
 
 static int batadv_gateways_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_gw_client_seq_print_text, net_dev);
 }
 
 static int batadv_transtable_global_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_tt_global_seq_print_text, net_dev);
 }

@@ -277,6 +281,7 @@ static int batadv_transtable_global_open(struct inode *inode, struct file *file)
 static int batadv_bla_claim_table_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_bla_claim_table_seq_print_text,
 			   net_dev);
 }

@@ -285,6 +290,7 @@ static int batadv_bla_backbone_table_open(struct inode *inode,
 					  struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_bla_backbone_table_seq_print_text,
 			   net_dev);
 }

@@ -300,6 +306,7 @@ static int batadv_bla_backbone_table_open(struct inode *inode,
 static int batadv_dat_cache_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_dat_cache_seq_print_text, net_dev);
 }
 #endif

@@ -307,6 +314,7 @@ static int batadv_dat_cache_open(struct inode *inode, struct file *file)
 static int batadv_transtable_local_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_tt_local_seq_print_text, net_dev);
 }

@@ -319,6 +327,7 @@ struct batadv_debuginfo {
 static int batadv_nc_nodes_open(struct inode *inode, struct file *file)
 {
 	struct net_device *net_dev = (struct net_device *)inode->i_private;
+
 	return single_open(file, batadv_nc_nodes_seq_print_text, net_dev);
 }
 #endif

net/batman-adv/distributed-arp-table.c +1 -0

index b25fd64..60889df 100644
@@ -662,6 +662,7 @@ static void batadv_dat_tvlv_container_update(struct batadv_priv *bat_priv)
 void batadv_dat_status_update(struct net_device *net_dev)
 {
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);
+
 	batadv_dat_tvlv_container_update(bat_priv);
 }

net/batman-adv/network-coding.c +1 -0

index a9546fe..40a2fc4 100644
@@ -86,6 +86,7 @@ static void batadv_nc_tvlv_container_update(struct batadv_priv *bat_priv)
 void batadv_nc_status_update(struct net_device *net_dev)
 {
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);
+
 	batadv_nc_tvlv_container_update(bat_priv);
 }

net/batman-adv/sysfs.c +10 -0

index 1ebb0d9..f51b484 100644
@@ -29,12 +29,14 @@
 static struct net_device *batadv_kobj_to_netdev(struct kobject *obj)
 {
 	struct device *dev = container_of(obj->parent, struct device, kobj);
+
 	return to_net_dev(dev);
 }
 
 static struct batadv_priv *batadv_kobj_to_batpriv(struct kobject *obj)
 {
 	struct net_device *net_dev = batadv_kobj_to_netdev(obj);
+
 	return netdev_priv(net_dev);
 }

@@ -124,6 +126,7 @@ ssize_t batadv_store_##_name(struct kobject *kobj,			\
 {									\
 	struct net_device *net_dev = batadv_kobj_to_netdev(kobj);	\
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);		\
+									\
 	return __batadv_store_bool_attr(buff, count, _post_func, attr,	\
 					&bat_priv->_name, net_dev);	\
 }

@@ -133,6 +136,7 @@ ssize_t batadv_show_##_name(struct kobject *kobj,			\
 			    struct attribute *attr, char *buff)		\
 {									\
 	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);	\
+									\
 	return sprintf(buff, "%s\n",					\
 		       atomic_read(&bat_priv->_name) == 0 ?		\
 		       "disabled" : "enabled");				\

@@ -155,6 +159,7 @@ ssize_t batadv_store_##_name(struct kobject *kobj,			\
 {									\
 	struct net_device *net_dev = batadv_kobj_to_netdev(kobj);	\
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);		\
+									\
 	return __batadv_store_uint_attr(buff, count, _min, _max,	\
 					_post_func, attr,		\
 					&bat_priv->_name, net_dev);	\

@@ -165,6 +170,7 @@ ssize_t batadv_show_##_name(struct kobject *kobj,			\
 			    struct attribute *attr, char *buff)		\
 {									\
 	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);	\
+									\
 	return sprintf(buff, "%i\n", atomic_read(&bat_priv->_name));	\
 }									\

@@ -188,6 +194,7 @@ ssize_t batadv_store_vlan_##_name(struct kobject *kobj,			\
 	size_t res = __batadv_store_bool_attr(buff, count, _post_func,	\
 					      attr, &vlan->_name,	\
 					      bat_priv->soft_iface);	\
+									\
 	batadv_softif_vlan_free_ref(vlan);				\
 	return res;							\
 }

@@ -202,6 +209,7 @@ ssize_t batadv_show_vlan_##_name(struct kobject *kobj,			\
 	size_t res = sprintf(buff, "%s\n",				\
 			     atomic_read(&vlan->_name) == 0 ?		\
 			     "disabled" : "enabled");			\
+									\
 	batadv_softif_vlan_free_ref(vlan);				\
 	return res;							\
 }

@@ -324,12 +332,14 @@ static ssize_t batadv_show_bat_algo(struct kobject *kobj,
 				    struct attribute *attr, char *buff)
 {
 	struct batadv_priv *bat_priv = batadv_kobj_to_batpriv(kobj);
+
 	return sprintf(buff, "%s\n", bat_priv->bat_algo_ops->name);
 }
 
 static void batadv_post_gw_reselect(struct net_device *net_dev)
 {
 	struct batadv_priv *bat_priv = netdev_priv(net_dev);
+
 	batadv_gw_reselect(bat_priv);
 }

Signature · 1 line

1.8.5.5

Antonio Quartulli

author

2014-05-18 17:58 UTC #2 lore raw

PATCH 2/3 batman-adv: remove semi-colon after macro definition

In reply to Antonio Quartulli

Reported by checkpatch with the following warning:
"WARNING: macros should not use a trailing semicolon"

Signed-off-by Antonio Quartulli <[email protected]>

Signed-off-by Marek Lindner <[email protected]>

---
 net/batman-adv/debugfs.c | 4 ++--
 net/batman-adv/sysfs.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

net/batman-adv/debugfs.c +2 -2

index 99f2ba0..a12e25e 100644
@@ -342,7 +342,7 @@ struct batadv_debuginfo batadv_debuginfo_##_name = {	\
 		  .llseek = seq_lseek,			\
 		  .release = single_release,		\
 		}					\
-};
+}
 
 /* the following attributes are general and therefore they will be directly
  * placed in the BATADV_DEBUGFS_SUBDIR subdirectory of debugfs

@@ -404,7 +404,7 @@ struct batadv_debuginfo batadv_hardif_debuginfo_##_name = {	\
 		.llseek = seq_lseek,				\
 		.release = single_release,			\
 	},							\
-};
+}
 static BATADV_HARDIF_DEBUGINFO(originators, S_IRUGO,
 			       batadv_originators_hardif_open);

net/batman-adv/sysfs.c +2 -2

index f51b484..fc47baa 100644
@@ -108,7 +108,7 @@ struct batadv_attribute batadv_attr_vlan_##_name = {	\
 		 .mode = _mode },			\
 	.show   = _show,				\
 	.store  = _store,				\
-};
+}
 
 /* Use this, if you have customized show and store functions */
 #define BATADV_ATTR(_name, _mode, _show, _store)	\

@@ -117,7 +117,7 @@ struct batadv_attribute batadv_attr_##_name = {		\
 		 .mode = _mode },			\
 	.show   = _show,				\
 	.store  = _store,				\
-};
+}
 
 #define BATADV_ATTR_SIF_STORE_BOOL(_name, _post_func)			\
 ssize_t batadv_store_##_name(struct kobject *kobj,			\

Signature · 1 line

1.8.5.5

Antonio Quartulli

author

2014-05-18 17:58 UTC #3 lore raw

PATCH 3/3 batman-adv: Start new development cycle

In reply to Antonio Quartulli

From: Simon Wunderlich <[email protected]>

Signed-off-by Simon Wunderlich <[email protected]>

Signed-off-by Antonio Quartulli <[email protected]>

---
 net/batman-adv/main.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/batman-adv/main.h +1 -1

index 770dc89..118b990 100644
@@ -24,7 +24,7 @@
 #define BATADV_DRIVER_DEVICE "batman-adv"
 
 #ifndef BATADV_SOURCE_VERSION
-#define BATADV_SOURCE_VERSION "2014.2.0"
+#define BATADV_SOURCE_VERSION "2014.3.0"
 #endif
 
 /* B.A.T.M.A.N. parameters */

Signature · 1 line

1.8.5.5

David Miller

maintainer

2014-05-19 01:27 UTC #4 lore raw

In reply to Antonio Quartulli

From: Antonio Quartulli <[email protected]>
Date: Sun, 18 May 2014 19:58:07 +0200

Quoted 9 lines

here you have our pull request for net-next.
Unfortunately this time we have nothing exciting for you (as you may have seen we preferred to focus on bug fixing during the last period).
Patch 1 and 2 slightly improve our codestyle in order to respect two new checks that have been recently introduced in checkpatch.
Patch 3 is just increasing our internal version number.

Pulled, thanks Antonio.