Skip to contentSkip to conversation

uxa: fix pageflips on 3 head scenarios

PATCH In review Dave Airlie 2 participants 2 messages May 20, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uxa: fix pageflips on 3 head scenarios

From: Dave Airlie <[email protected]>

While fixing up UXA for MST I eventually fell over this bug.

---
 src/uxa/intel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/uxa/intel.h +1 -1
index 6ac770e..f9dbd96 100644
@@ -334,7 +334,7 @@ typedef struct intel_screen_private {
 	Bool has_kernel_flush;
 	Bool needs_flush;
 
-	struct _DRI2FrameEvent *pending_flip[2];
+	struct _DRI2FrameEvent *pending_flip[3];
 
 	/* Broken-out options. */
 	OptionInfoPtr Options;
Signature · 1 line
1.9.0
#1 lore raw
Quoted 5 lines · Dave Airlie

From: Dave Airlie <[email protected]>

While fixing up UXA for MST I eventually fell over this bug.

Oops, that's bad - sorry for sending you on that chase.

I amended the commit to use MAX_PIPES so hopefully it is easier to spot the bad code again in future and pushed.

commit 197ab0cda06c44aa1a2b17bf69ac08612811b107

Author: Dave Airlie <[email protected]>
Date:   Tue May 20 07:45:14 2014 +0100

uxa: fix pageflips on 3 head scenarios

Thanks,
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre