Skip to contentSkip to conversation

UBI: block: Fix error path on alloc_workqueue failure

PATCH In review Helmut Schaa 2 participants 2 messages May 20, 2014

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Helmut Schaa

author
#0 lore raw

PATCH 1/1 UBI: block: Fix error path on alloc_workqueue failure

Otherwise we'd return a random value if allocation of the workqueue fails.

Signed-off-by Helmut Schaa <[email protected]>

---
Just stumbled over that one while playing with UBI block devices.

 drivers/mtd/ubi/block.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mtd/ubi/block.c +3 -1
index 8d659e6..389e5f0 100644
@@ -432,8 +432,10 @@ int ubiblock_create(struct ubi_volume_info *vi)
 	 * Rembember workqueues are cheap, they're not threads.
 	 */
 	dev->wq = alloc_workqueue("%s", 0, 0, gd->disk_name);
-	if (!dev->wq)
+	if (!dev->wq) {
+		ret = -ENOMEM;
 		goto out_free_queue;
+	}
 	INIT_WORK(&dev->work, ubiblock_do_work);
 
 	mutex_lock(&devices_mutex);
Signature · 1 line
1.8.4.5