Skip to contentSkip to conversation

MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC

PATCH In review Paul Bolle 2 participants 2 messages May 20, 2014 – May 22, 2014 MIPS

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 MIPS: remove check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC

A check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC was added in v2.6.29, but without the related Kconfig symbol. Remove this check.

Also remove the test for an "ecc_verbose" kernel parameter. It is undocumented and has no effect anyway.

---
Untested.

Note that __cvmx_interrupt_ecc_report_single_bit_errors doesn't exist.

 arch/mips/cavium-octeon/setup.c | 6 ------
 1 file changed, 6 deletions(-)
arch/mips/cavium-octeon/setup.c +0 -6
index 331b837cec57..953ca85f84fa 100644
@@ -779,12 +779,6 @@ void __init prom_init(void)
 				MAX_MEMORY = 32ull << 30;
 			if (*p == '@')
 				RESERVE_LOW_MEM = memparse(p + 1, &p);
-		} else if (strcmp(arg, "ecc_verbose") == 0) {
-#ifdef CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC
-			__cvmx_interrupt_ecc_report_single_bit_errors = 1;
-			pr_notice("Reporting of single bit ECC errors is "
-				  "turned on\n");
-#endif
 #ifdef CONFIG_KEXEC
 		} else if (strncmp(arg, "crashkernel=", 12) == 0) {
 			crashk_size = memparse(arg+12, &p);
Signature · 1 line
1.9.0
#1 lore raw
Quoted 11 lines · Paul Bolle

A check for CONFIG_CAVIUM_REPORT_SINGLE_BIT_ECC was added in v2.6.29, but without the related Kconfig symbol. Remove this check.

Also remove the test for an "ecc_verbose" kernel parameter. It is undocumented and has no effect anyway.

---
Untested.

Note that __cvmx_interrupt_ecc_report_single_bit_errors doesn't exist.

I tried to chase the history of this but as far as I was able to find, this is unused since I initially merged Octeon support; beyond that I wasn't able to find any history.

So queued for 3.16.

Thanks!

Ralf