Skip to contentSkip to conversation

powerpc: fix typo 'CONFIG_PMAC'

PATCH In review Paul Bolle 2 participants 4 messages May 20, 2014 – May 22, 2014 PowerPC

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 powerpc: fix typo 'CONFIG_PMAC'

Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") added a check for CONFIG_PMAC were a check for CONFIG_PPC_PMAC was clearly intended.

Fixes b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending")

---
Untested. Needs testing on 32 bit powermac, I guess.

This typo was introduced in v2.6.36. No one noticed because very few people still use 32 bit powermacs?

 arch/powerpc/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/time.c +1 -1
index 122a580f7322..bb3cfa10a4ea 100644
@@ -551,7 +551,7 @@ void timer_interrupt(struct pt_regs * regs)
 	may_hard_irq_enable();
 
 
-#if defined(CONFIG_PPC32) && defined(CONFIG_PMAC)
+#if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC)
 	if (atomic_read(&ppc_n_lost_interrupts) != 0)
 		do_IRQ(regs);
 #endif
Signature · 1 line
1.9.0
#1 lore raw
Quoted 11 lines · Paul Bolle

Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") added a check for CONFIG_PMAC were a check for CONFIG_PPC_PMAC was clearly intended.

Fixes b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending")

---
Untested. Needs testing on 32 bit powermac, I guess.

This typo was introduced in v2.6.36. No one noticed because very few people still use 32 bit powermacs?

How does that bug manifest itself?

Andreas.

Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
author
#2 lore raw

Andreas,

Quoted 11 lines · Andreas Schwab
Quoted 9 lines · Paul Bolle

Commit b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending") added a check for CONFIG_PMAC were a check for CONFIG_PPC_PMAC was clearly intended.

Fixes b0d278b7d3ae ("powerpc/perf_event: Reduce latency of calling perf_event_do_pending")

---
Untested. Needs testing on 32 bit powermac, I guess.

Quoted 4 lines
Quoted 2 lines

This typo was introduced in v2.6.36. No one noticed because very few people still use 32 bit powermacs?

How does that bug manifest itself?

Do you want to know how to test this patch on a 32 bit powermac? Ie, see if it has any effect, and whether that effect improves things or make things worse.

I have no clue how to do that, sorry. Perhaps someone else has.

Paul Bolle

#3 lore raw
Quoted 3 lines · Paul Bolle

Do you want to know how to test this patch on a 32 bit powermac? Ie, see if it has any effect, and whether that effect improves things or make things worse.

Yes.

Andreas.

Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."