mtd: lpddr: fix Kconfig dependency, for I/O accessors
PATCH 1/1 mtd: lpddr: fix Kconfig dependency, for I/O accessors
Not all architectures implement a writel_relaxed() accessor. Hopefully this will change eventually, but for now, this means lpddr2_nvm.c can't compile on some architectures.
Let's add an ARM dependency for now, and leave a comment so maybe we can change this in the future.
--- drivers/mtd/lpddr/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mtd/lpddr/Kconfig +2 -1
@@ -19,7 +19,8 @@ config MTD_QINFO_PROBE Flash products config MTD_LPDDR2_NVM - depends on MTD + # ARM dependency is only for writel_relaxed() + depends on MTD && ARM tristate "Support for LPDDR2-NVM flash chips" help This option enables support of PCM memories with a LPDDR2-NVM
Signature · 1 line
1.8.3.2
Quoted 9 lines · Brian Norris
Not all architectures implement a
writel_relaxed()accessor. Hopefully this will change eventually, but for now, this meanslpddr2_nvm.ccan't compile on some architectures.Let's add an ARM dependency for now, and leave a comment so maybe we can change this in the future.
Signed-off-by Brian Norris <[email protected]>Cc Vincenzo Aliberti <[email protected]>
Pushed to l2-mtd.git, to stop people from reporting build failures on x86.
Brian
Brian,
as discussed this solution is fine for me
Vincenzo
Quoted 30 lines · Brian Norris
Not all architectures implement a
writel_relaxed()accessor. Hopefully this will change eventually, but for now, this meanslpddr2_nvm.ccan't compile on some architectures.Let's add an ARM dependency for now, and leave a comment so maybe we can change this in the future.
Signed-off-by Brian Norris <[email protected]>Cc Vincenzo Aliberti <[email protected]>--- drivers/mtd/lpddr/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mtd/lpddr/Kconfig +2
-2@@ -19,7 +19,8 @@ config MTD_QINFO_PROBE Flash products config MTD_LPDDR2_NVM - depends on MTD + # ARM dependency is only for writel_relaxed() + depends on MTD && ARM tristate "Support for LPDDR2-NVM flash chips" help This option enables support of PCM memories with a LPDDR2-NVM --1.8.3.2