pwm: fsl-ftm: set pwm_chip can_sleep flag
PATCH 1/1 pwm: fsl-ftm: set pwm_chip can_sleep flag
The implementation of .config(), .enable() and .disable() operations in this driver may sleep, thus set pwm_chip can_sleep flag.
--- drivers/pwm/pwm-fsl-ftm.c | 1 + 1 file changed, 1 insertion(+)
drivers/pwm/pwm-fsl-ftm.c +1 -0
@@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) fpc->chip.of_pwm_n_cells =3 ; fpc->chip.base =-1 ; fpc->chip.npwm =8 ; + fpc->chip.can_sleep = true; ret =pwmchip_add (&fpc->chip);if (ret <0 ) {
Signature · 1 line
1.8.3.2
Quoted 7 lines
Subject: [PATCH] pwm: fsl-ftm: set
pwm_chipcan_sleepflagThe implementation of .config(), .enable() and .disable() operations in this driver may sleep, thus set
pwm_chipcan_sleepflag.Signed-off-by Axel Lin <[email protected]>---
@Thierry,
There are still 4 patches before this one, and I'd like to know the status of them:
[PATCHv2 0/4] FTM PWM adds regmap and endianness support.
Thanks,
BRs
Xiubo
Quoted 19 lines
drivers/pwm/pwm-fsl-ftm.c | 1 + 1 file changed, 1 insertion(+)drivers/pwm/pwm-fsl-ftm.c +1
-1@@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) fpc->chip.of_pwm_n_cells =3 ; fpc->chip.base =-1 ; fpc->chip.npwm =8 ; + fpc->chip.can_sleep = true; ret =pwmchip_add (&fpc->chip);if (ret <0 ) { --1.8.3.2
Quoted 8 lines · On Fri, May 23, 2014 at 01:02:21AM +0000, [email protected] wrote:
Quoted 7 lines
Subject: [PATCH] pwm: fsl-ftm: set
pwm_chipcan_sleepflagThe implementation of .config(), .enable() and .disable() operations in this driver may sleep, thus set
pwm_chipcan_sleepflag.Signed-off-by Axel Lin <[email protected]>---
Quoted 7 lines
Acked-by Xiubo Li <[email protected]>@Thierry,
There are still 4 patches before this one, and I'd like to know the status of them:
[PATCHv2 0/4] FTM PWM adds regmap and endianness support.
I was holding off on those because I thought I had seen some discussion about how to represent endianness support in DT and I'm not aware that there were any conclusions yet.
Thierry
Quoted 16 lines
Subject: Re: [PATCH] pwm: fsl-ftm: set
pwm_chipcan_sleepflagQuoted 3 lines · On Fri, May 23, 2014 at 01:02:21AM +0000, [email protected] wrote:
Quoted 3 lines
Subject: [PATCH] pwm: fsl-ftm: set
pwm_chipcan_sleepflagThe implementation of .config(), .enable() and .disable() operations in
this
Quoted 9 lines
Quoted 4 lines
driver may sleep, thus set
pwm_chipcan_sleepflag.Signed-off-by Axel Lin <[email protected]>---
Acked-by Xiubo Li <[email protected]>@Thierry,
Quoted 9 lines
Quoted 1 line
There are still 4 patches before this one, and I'd like to know the status
of
Quoted 2 lines
them:
[PATCHv2 0/4] FTM PWM adds regmap and endianness support.I was holding off on those because I thought I had seen some discussion about how to represent endianness support in DT and I'm not aware that there were any conclusions yet.
pwm: ftm-pwm: Clean up the code.
pwm: ftm-pwm: Convert to direct regmap API usage.
Well, how about the above two patches? And that discussion is mostly about The following ones:
Documentation: Add 'big-endian' property for FTM PWM.
pwm: ftm-pwm: Add big-endian support
Thanks,
BRs
Xiubo
Quoted 1 line
Thierry
Thierry Reding
AppliedQuoted 13 lines · Axel Lin
The implementation of .config(), .enable() and .disable() operations in this driver may sleep, thus set
pwm_chipcan_sleepflag.Signed-off-by Axel Lin <[email protected]>--- drivers/pwm/pwm-fsl-ftm.c | 1 + 1 file changed, 1 insertion(+)drivers/pwm/pwm-fsl-ftm.c +0
-0
drivers/pwm/pwm-fsl-ftm.c static int fsl_pwm_probe(struct platform_device *pdev) · line 460
Quoted 7 lines
drivers/pwm/pwm-fsl-ftm.c +1
-0@@ -454,6 +454,7 @@ static int fsl_pwm_probe(struct platform_device *pdev) fpc->chip.of_pwm_n_cells =3 ; fpc->chip.base =-1 ; fpc->chip.npwm =8 ; + fpc->chip.can_sleep = true; ret =pwmchip_add (&fpc->chip);if (ret <0 ) {
Applied, thanks.
Thierry