drm/ttm: fix kerneldoc of ttm_bo_create
Subsystems (2)
PATCH 1/1 drm/ttm: fix kerneldoc of ttm_bo_create
The kerneldoc header of ttm_bo_create() was referring to another (nonexisting) function and had a few obsolete or incorrect arguments.
--- include/drm/ttm/ttm_bo_api.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
include/drm/ttm/ttm_bo_api.h +2 -3
@@ -485,13 +485,12 @@ extern int ttm_bo_init(struct ttm_bo_device *bdev, void (*destroy) (struct ttm_buffer_object *));/** -* ttm_bo_synccpu_object_init +* ttm_bo_create * * @bdev: Pointer to a ttm_bo_device struct. -* @bo: Pointer to a ttm_buffer_object to be initialized. * @size: Requested size of buffer object. * @type: Requested type of buffer object. -* @flags: Initial placement flags. +* @placement: Initial placement. * @page_alignment: Data alignment in pages. * @interruptible: If needing to sleep while waiting for GPU resources, * sleep interruptible.
Signature · 1 line
1.9.2
PATCH RESEND 1/1 drm/ttm: remove declaration of ttm_tt_cache_flush
ttm_tt_cache_flush's implementation was removed in 2009 by commit c9c97b8c, but its declaration has been hiding in ttm_bo_driver.h since then.
It has been surviving in the dark for too long now ; give it the mercy blow.
--- include/drm/ttm/ttm_bo_driver.h | 12 ------------ 1 file changed, 12 deletions(-)
include/drm/ttm/ttm_bo_driver.h +0 -12
@@ -653,18 +653,6 @@ extern void ttm_tt_unbind(struct ttm_tt *ttm);extern int ttm_tt_swapin (struct ttm_tt *ttm);/** -* ttm_tt_cache_flush: -* -* @pages: An array of pointers to struct page:s to flush. -* @num_pages: Number of pages to flush. -* -* Flush the data of the indicated pages from the cpu caches. -* This is used when changing caching attributes of the pages from -* cache-coherent. -*/ -extern void ttm_tt_cache_flush (struct page *pages[],unsigned long num_pages); - -/** * ttm_tt_set_placement_caching: * * @ttm A struct ttm_tt the backing pages of which will change caching policy.
Signature · 1 line
1.9.2
Re: [PATCH RESEND] drm/ttm: remove declaration of ttm_tt_cache_flush
Hi
Quoted 9 lines · Alexandre Courbot
ttm_tt_cache_flush's implementation was removed in 2009 by commit
c9c97b8c, but its declaration has been hiding inttm_bo_driver.hsince then.It has been surviving in the dark for too long now ; give it the mercy blow.
Signed-off-by Alexandre Courbot <[email protected]>Reviewed-by Thierry Reding <[email protected]>
Thanks
David
Quoted 34 lines
--- include/drm/ttm/ttm_bo_driver.h | 12 ------------ 1 file changed, 12 deletions(-)include/drm/ttm/ttm_bo_driver.h +0
-13@@ -653,18 +653,6 @@ extern void ttm_tt_unbind(struct ttm_tt *ttm);extern int ttm_tt_swapin (struct ttm_tt *ttm);/** -* ttm_tt_cache_flush: -* -* @pages: An array of pointers to struct page:s to flush. -* @num_pages: Number of pages to flush. -* -* Flush the data of the indicated pages from the cpu caches. -* This is used when changing caching attributes of the pages from -* cache-coherent. -*/ -extern void ttm_tt_cache_flush (struct page *pages[],unsigned long num_pages); - -/** * ttm_tt_set_placement_caching: * * @ttm A struct ttm_tt the backing pages of which will change caching policy. -- 1.9.2
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi
Quoted 4 lines · Alexandre Courbot
The kerneldoc header of
ttm_bo_create()was referring to another (nonexisting) function and had a few obsolete or incorrect arguments.Signed-off-by Alexandre Courbot <[email protected]>
Thanks
David
Quoted 31 lines
--- include/drm/ttm/ttm_bo_api.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)include/drm/ttm/ttm_bo_api.h +2
-4@@ -485,13 +485,12 @@ extern int ttm_bo_init(struct ttm_bo_device *bdev, void (*destroy) (struct ttm_buffer_object *));/** -* ttm_bo_synccpu_object_init +* ttm_bo_create * * @bdev: Pointer to a ttm_bo_device struct. -* @bo: Pointer to a ttm_buffer_object to be initialized. * @size: Requested size of buffer object. * @type: Requested type of buffer object. -* @flags: Initial placement flags. +* @placement: Initial placement. * @page_alignment: Data alignment in pages. * @interruptible: If needing to sleep while waiting for GPU resources, * sleep interruptible. -- 1.9.2
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel