ASoC: fsl: Remove dependencies of boards for SND_SOC_EUKREA_TLV320
PATCH 1/1 ASoC: fsl: Remove dependencies of boards for SND_SOC_EUKREA_TLV320
Eukrea-i.MX51 board was converted to use DT, ie we no longer have a MACH_EUKREA_MBIMXSD51_BASEBOARD symbol.
Transformation of other boards planned for the near future, so this patch removes all these dependencies and restricts build of this driver to ARCH_MXC.
--- sound/soc/fsl/Kconfig | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
sound/soc/fsl/Kconfig +1 -6
@@ -207,12 +207,7 @@ config SND_SOC_PHYCORE_AC97 config SND_SOC_EUKREA_TLV320 tristate "Eukrea TLV320" - depends on MACH_EUKREA_MBIMX27_BASEBOARD \ - || MACH_EUKREA_MBIMXSD25_BASEBOARD \ - || MACH_EUKREA_MBIMXSD35_BASEBOARD \ - || MACH_EUKREA_MBIMXSD51_BASEBOARD \ - || (OF && ARM) - depends on I2C + depends on ARCH_MXC && I2C select SND_SOC_TLV320AIC23_I2C select SND_SOC_IMX_AUDMUX select SND_SOC_IMX_SSI
Signature · 1 line
1.8.3.2
Mark Brown
maintainerQuoted 5 lines · Alexander Shiyan
Eukrea-i.MX51 board was converted to use DT, ie we no longer have a
MACH_EUKREA_MBIMXSD51_BASEBOARDsymbol.
Transformation of other boards planned for the near future, so this patch removes all these dependencies and restricts build of this driver toARCH_MXC.
Does it actually depend on ARCH_MXC or can we also enable build with COMPILE_TEST now everything is DT converted? Looking at the code there's a lot of machine_is_ checks in there so it's not clear that this will work well on DT...
A message that is not in the archive (sent off-list or not yet received): [email protected]
Mark Brown
maintainerQuoted 5 lines · Alexander Shiyan
Yes, now I see.
So on my opinion the true method is transform this board (for DT case) is to use generic sound card. In this patch , I just try to remove non-existent symbol dependencies, so if we haveis_machine_xxchecks I do not know the true way, since cannot test this.
Yes, transitioning to simple-card would be ideal if you can do that. I guess we can apply this one for now since it doesn't make things any worse at least.
Quoted 5 lines · Alexander Shiyan
Eukrea-i.MX51 board was converted to use DT, ie we no longer have a
MACH_EUKREA_MBIMXSD51_BASEBOARDsymbol.
Transformation of other boards planned for the near future, so this patch removes all these dependencies and restricts build of this driver toARCH_MXC.
Applied, thanks.