Skip to contentSkip to conversation

Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

PATCH In review Chaitanya Hazarey 3 participants 4 messages May 23, 2014 – May 24, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: Silicom: Bypasslib: Fixed a couple of checkpatch.pl warnings

Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:

drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations

---
 drivers/staging/silicom/bypasslib/bypass.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/silicom/bypasslib/bypass.c +2 -1
index a58251f..8e714a8 100644
@@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
 static int is_dev_sd(int if_index)
 {
 	int ret = 0;
+
 	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
 	return ret >= 0 ? 1 : 0;
 }
@@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
 static int is_bypass(int if_index)
 {
 	int ret = 0;
+
 	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
 	if (ret < 0)
--

1.7.9.5

maintainer
#1 lore raw
Quoted 9 lines · Chaitanya Hazarey

Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:

drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations

---
 drivers/staging/silicom/bypasslib/bypass.c |    2 ++
 1 file changed, 2 insertions(+)

This patch doesn't apply cleanly. Can you please refresh it against my staging-next branch of staging.git on git.kernel.org and resend?

thanks,

greg k-h

#2 lore raw
In reply to Chaitanya Hazarey
Quoted 6 lines · Chaitanya Hazarey

Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:

drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations

Still doesn't apply, I'm afraid.

Quoted 17 lines
---
 drivers/staging/silicom/bypasslib/bypass.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/silicom/bypasslib/bypass.c +1 -0
index a58251f..8e714a8 100644
@@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
 static int is_dev_sd(int if_index)
 {
 	int ret = 0;
+
 	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
 	return ret >= 0 ? 1 : 0;
 }

drivers/staging/silicom/bypasslib/bypass.c static int is_bypass_dev(int if_index) · line 192

Quoted 6 lines
drivers/staging/silicom/bypasslib/bypass.c +1 -0
@@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
 static int is_bypass(int if_index)
 {
 	int ret = 0;
+
 	SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
 	if (ret < 0)

There was supposed to be a blank line between the call to SET_BPLIB_INT_FN() and the return check and it got deleted for some reason.

regards,
dan carpetner

#3 lore raw

Hey Dan,

Thanks for your patience, I have resubmitted via a new email. Hope that works.

Thanks,

Chaitanya

Quoted 42 lines · Dan Carpenter
Quoted 6 lines · Chaitanya Hazarey

Added a blank line after declarations to fix the following warnings issued by checkpatch.pl:

drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line after declarations drivers/staging/silicom/bypasslib/bypass.c:189: WARNING: Missing a blank line after declarations

Still doesn't apply, I'm afraid.

Quoted 17 lines
---
 drivers/staging/silicom/bypasslib/bypass.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/silicom/bypasslib/bypass.c +1 -0
index a58251f..8e714a8 100644
@@ -135,6 +135,7 @@ static int doit(int cmd, int if_index, int *data)
 static int is_dev_sd(int if_index)
 {
      int ret = 0;
+
      SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
      return ret >= 0 ? 1 : 0;
 }

drivers/staging/silicom/bypasslib/bypass.c static int is_bypass_dev(int if_index) · line 192

Quoted 6 lines
drivers/staging/silicom/bypasslib/bypass.c +1 -0
@@ -186,6 +187,7 @@ static int is_bypass_dev(int if_index)
 static int is_bypass(int if_index)
 {
      int ret = 0;
+
      SET_BPLIB_INT_FN(is_bypass, int, if_index, ret);
      if (ret < 0)

There was supposed to be a blank line between the call to SET_BPLIB_INT_FN() and the return check and it got deleted for some reason.

regards,
dan carpetner