Skip to contentSkip to conversation

regulator: pfuze100: Support enable/disable for fixed regulator

PATCH Applied Axel Lin 3 participants 3 messages May 26, 2014 – May 27, 2014 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: pfuze100: Support enable/disable for fixed regulator

Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.

---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel

 drivers/regulator/pfuze100-regulator.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/regulator/pfuze100-regulator.c +3 -0
index 67e678c..b6b4529 100644
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = {
 };
 
 static struct regulator_ops pfuze100_fixed_regulator_ops = {
+	.enable = regulator_enable_regmap,
+	.disable = regulator_disable_regmap,
+	.is_enabled = regulator_is_enabled_regmap,
 	.list_voltage = regulator_list_voltage_linear,
 };
 
Signature · 1 line
1.8.3.2
Tested-by Robin Gong Acked-by Robin Gong on v1 1/1
#1 lore raw

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Monday, May 26, 2014 5:56 PM
To: Mark Brown
Cc: Gong Yibin-B38343; Estevam Fabio-R49496; Liam Girdwood; [email protected]
Subject: [RFT][PATCH] regulator: pfuze100: Support enable/disable for fixed regulator

Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.

---
Hi Robin,
Can you review and test this patch?
Thanks,
Axel

 drivers/regulator/pfuze100-regulator.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/regulator/pfuze100-regulator.c +3 -1
index 67e678c..b6b4529 100644
@@ -125,6 +125,9 @@ static struct regulator_ops pfuze100_ldo_regulator_ops = {  };
 
 static struct regulator_ops pfuze100_fixed_regulator_ops = {
+	.enable = regulator_enable_regmap,
+	.disable = regulator_disable_regmap,
+	.is_enabled = regulator_is_enabled_regmap,
 	.list_voltage = regulator_list_voltage_linear,  };
 
--

1.8.3.2

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�

maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

Current code has .enable_reg and .enable_mask settings, but the implementation for corresponding callbacks are missing. Fix it.

Applied, thanks.