Skip to contentSkip to conversation

staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

PATCH Superseded navin patidar 1 participant 24 messages May 26, 2014 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/24 staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c    |    9 ---------
 drivers/staging/rtl8188eu/include/rtw_pwrctrl.h |    2 --
 2 files changed, 11 deletions(-)
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +0 -9
index f658373..83e34f4 100644
@@ -497,15 +497,6 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
 	_init_timer(&(pwrctrlpriv->pwr_state_check_timer), padapter->pnetdev, pwr_state_check_handler, (u8 *)padapter);
 }
 
-u8 rtw_interface_ps_func(struct adapter *padapter, enum hal_intf_ps_func efunc_id, u8 *val)
-{
-	u8 bResult = true;
-	rtw_hal_intf_ps_func(padapter, efunc_id, val);
-
-	return bResult;
-}
-
-
 inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
 {
 	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h +0 -2
index 9a42859..751803f 100644
@@ -258,8 +258,6 @@ s32 LPS_RF_ON_check(struct adapter *adapter, u32 delay_ms);
 void LPS_Enter(struct adapter *adapter);
 void LPS_Leave(struct adapter *adapter);
 
-u8 rtw_interface_ps_func(struct adapter *adapter,
-			 enum hal_intf_ps_func efunc_id, u8 *val);
 void rtw_set_ips_deny(struct adapter *adapter, u32 ms);
 int _rtw_pwr_wakeup(struct adapter *adapter, u32 ips_defer_ms,
 		    const char *caller);
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/24 staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

---
 drivers/staging/rtl8188eu/hal/hal_intf.c     |    9 ---------
 drivers/staging/rtl8188eu/include/hal_intf.h |    3 ---
 2 files changed, 12 deletions(-)
drivers/staging/rtl8188eu/hal/hal_intf.c +0 -9
index d75ca7a..43eee48 100644
@@ -207,15 +207,6 @@ u32 rtw_hal_inirp_deinit(struct adapter *adapt)
 	return _FAIL;
 }
 
-u8 rtw_hal_intf_ps_func(struct adapter *adapt,
-			enum hal_intf_ps_func efunc_id, u8 *val)
-{
-	if (adapt->HalFunc.interface_ps_func)
-		return adapt->HalFunc.interface_ps_func(adapt, efunc_id,
-							   val);
-	return _FAIL;
-}
-
 s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)
 {
 	if (adapt->HalFunc.hal_xmit)
drivers/staging/rtl8188eu/include/hal_intf.h +0 -3
index c274b34..9228bc6 100644
@@ -332,9 +332,6 @@ void rtw_hal_disable_interrupt(struct adapter *padapter);
 u32	rtw_hal_inirp_init(struct adapter *padapter);
 u32	rtw_hal_inirp_deinit(struct adapter *padapter);
 
-u8	rtw_hal_intf_ps_func(struct adapter *padapter,
-			     enum hal_intf_ps_func efunc_id, u8 *val);
-
 s32	rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);
 s32	rtw_hal_mgnt_xmit(struct adapter *padapter,
 			  struct xmit_frame *pmgntframe);
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 3/24 staging: rtl8188eu: Remove unused function pointer ->interface_ps_func

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c  |    2 --
 drivers/staging/rtl8188eu/include/hal_intf.h |    3 ---
 2 files changed, 5 deletions(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +0 -2
index 0cb84ae..9020129 100644
@@ -2272,7 +2272,5 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
 	halfunc->hal_xmit = &rtl8188eu_hal_xmit;
 	halfunc->mgnt_xmit = &rtl8188eu_mgnt_xmit;
 
-	halfunc->interface_ps_func = &rtl8188eu_ps_func;
-
 	rtl8188e_set_hal_ops(halfunc);
 }
drivers/staging/rtl8188eu/include/hal_intf.h +0 -3
index 9228bc6..acdef1d 100644
@@ -218,9 +218,6 @@ struct hal_ops {
 	void	(*AntDivCompareHandler)(struct adapter *adapter,
 					struct wlan_bssid_ex *dst,
 					struct wlan_bssid_ex *src);
-	u8	(*interface_ps_func)(struct adapter *padapter,
-				     enum hal_intf_ps_func efunc_id, u8 *val);
-
 	s32	(*hal_xmit)(struct adapter *padapter,
 			    struct xmit_frame *pxmitframe);
 	s32 (*mgnt_xmit)(struct adapter *padapter,
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH 4/24 staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/usb_halinit.c |    6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +0 -6
index 9020129..141f85a 100644
@@ -2226,12 +2226,6 @@ static void rtl8188eu_init_default_value(struct adapter *adapt)
 		haldata->odmpriv.RFCalibrateInfo.ThermalValue_HP[i] = 0;
 }
 
-static u8 rtl8188eu_ps_func(struct adapter *Adapter, enum hal_intf_ps_func efunc_id, u8 *val)
-{
-	u8 bResult = true;
-	return bResult;
-}
-
 void rtl8188eu_set_hal_ops(struct adapter *adapt)
 {
 	struct hal_ops	*halfunc = &adapt->HalFunc;
Signature · 1 line
1.7.10.4
#4 lore raw

PATCH 5/24 staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/odm_HWConfig.c |    8 --------
 1 file changed, 8 deletions(-)
drivers/staging/rtl8188eu/hal/odm_HWConfig.c +0 -8
index a755df3..0145a11 100644
@@ -436,14 +436,6 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm,
 	ODM_PhyStatusQuery_92CSeries(dm_odm, pPhyInfo, pPhyStatus, pPktinfo);
 }
 
-/*  For future use. */
-void ODM_MacStatusQuery(struct odm_dm_struct *dm_odm, u8 *mac_stat,
-			u8 macid, bool pkt_match_bssid,
-			bool pkttoself, bool pkt_beacon)
-{
-	/*  2011/10/19 Driver team will handle in the future. */
-}
-
 enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm,
 					   enum rf_radio_path content,
 					   enum rf_radio_path rfpath)
Signature · 1 line
1.7.10.4
#5 lore raw

PATCH 6/24 staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/odm_HWConfig.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8188eu/hal/odm_HWConfig.c +0 -4
index 0145a11..f2e1d02 100644
@@ -275,10 +275,6 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
 	dm_odm->DM_FatTable.antsel_rx_keep_2 = pPhyStaRpt->antsel_rx_keep_2;
 }
 
-void odm_Init_RSSIForDM(struct odm_dm_struct *dm_odm)
-{
-}
-
 static void odm_Process_RSSIForDM(struct odm_dm_struct *dm_odm,
 				  struct odm_phy_status_info *pPhyInfo,
 				  struct odm_per_pkt_info *pPktinfo)
Signature · 1 line
1.7.10.4
#6 lore raw

PATCH 7/24 staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |   10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +0 -10
index cf88bf2..4e9f797 100644
@@ -31,10 +31,6 @@
 
 #include <rtl8188e_hal.h>
 
-static void dm_CheckStatistics(struct adapter *Adapter)
-{
-}
-
 /*  Initialize GPIO setting registers */
 static void dm_InitGPIOSetting(struct adapter *Adapter)
 {
@@ -173,12 +169,6 @@ void rtl8188e_HalDmWatchDog(struct adapter *Adapter)
 	if (Adapter->wdinfo.p2p_ps_mode)
 		fw_ps_awake = false;
 
-	if (hw_init_completed && ((!fw_cur_in_ps) && fw_ps_awake)) {
-		/*  Calculate Tx/Rx statistics. */
-		dm_CheckStatistics(Adapter);
-
-	}
-
 	/* ODM */
 	if (hw_init_completed) {
 		struct mlme_priv *pmlmepriv = &Adapter->mlmepriv;
Signature · 1 line
1.7.10.4
#7 lore raw

PATCH 8/24 staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

In reply to navin patidar

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer. rtl8188e_deinit_dm_priv() has empty defination, so we can remove rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be removed.

---
 drivers/staging/rtl8188eu/hal/hal_intf.c     |    7 -------
 drivers/staging/rtl8188eu/include/hal_intf.h |    1 -
 drivers/staging/rtl8188eu/os_dep/os_intfs.c  |    2 --
 3 files changed, 10 deletions(-)
drivers/staging/rtl8188eu/hal/hal_intf.c +0 -7
index 43eee48..d0ac4a1 100644
@@ -60,13 +60,6 @@ void rtw_hal_dm_init(struct adapter *adapt)
 		adapt->HalFunc.dm_init(adapt);
 }
 
-void rtw_hal_dm_deinit(struct adapter *adapt)
-{
-	/*  cancel dm  timer */
-	if (adapt->HalFunc.dm_deinit)
-		adapt->HalFunc.dm_deinit(adapt);
-}
-
 void rtw_hal_sw_led_init(struct adapter *adapt)
 {
 	if (adapt->HalFunc.InitSwLeds)
drivers/staging/rtl8188eu/include/hal_intf.h +0 -1
index acdef1d..a8f25c9 100644
@@ -296,7 +296,6 @@ void rtw_hal_def_value_init(struct adapter *padapter);
 void	rtw_hal_free_data(struct adapter *padapter);
 
 void rtw_hal_dm_init(struct adapter *padapter);
-void rtw_hal_dm_deinit(struct adapter *padapter);
 void rtw_hal_sw_led_init(struct adapter *padapter);
 void rtw_hal_sw_led_deinit(struct adapter *padapter);
 
drivers/staging/rtl8188eu/os_dep/os_intfs.c +0 -2
index 9edb8e8..c1368b8 100644
@@ -951,8 +951,6 @@ void rtw_cancel_all_timer(struct adapter *padapter)
 	_cancel_timer_ex(&padapter->pwrctrlpriv.pwr_state_check_timer);
 
 	_cancel_timer_ex(&padapter->recvpriv.signal_stat_timer);
-	/* cancel dm timer */
-	rtw_hal_dm_deinit(padapter);
 }
 
 u8 rtw_free_drv_sw(struct adapter *padapter)
Signature · 1 line
1.7.10.4
#8 lore raw

PATCH 9/24 staging: rtl8188eu: Remove unused function pointer ->dm_init

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |    1 -
 drivers/staging/rtl8188eu/include/hal_intf.h      |    1 -
 2 files changed, 2 deletions(-)
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c +0 -1
index f9d5558..5a22c6d 100644
@@ -1843,7 +1843,6 @@ void rtl8188e_set_hal_ops(struct hal_ops *pHalFunc)
 	pHalFunc->free_hal_data = &rtl8188e_free_hal_data;
 
 	pHalFunc->dm_init = &rtl8188e_init_dm_priv;
-	pHalFunc->dm_deinit = &rtl8188e_deinit_dm_priv;
 
 	pHalFunc->read_chip_version = &rtl8188e_read_chip_version;
 
drivers/staging/rtl8188eu/include/hal_intf.h +0 -1
index a8f25c9..c59fccd 100644
@@ -166,7 +166,6 @@ struct hal_ops {
 	void	(*DeInitSwLeds)(struct adapter *padapter);
 
 	void	(*dm_init)(struct adapter *padapter);
-	void	(*dm_deinit)(struct adapter *padapter);
 	void	(*read_chip_version)(struct adapter *padapter);
 
 	void	(*init_default_value)(struct adapter *padapter);
Signature · 1 line
1.7.10.4
#9 lore raw

PATCH 10/24 staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c     |    4 ----
 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |    1 -
 2 files changed, 5 deletions(-)
drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +0 -4
index 4e9f797..d5cd30b 100644
@@ -203,10 +203,6 @@ void rtl8188e_init_dm_priv(struct adapter *Adapter)
 	ODM_InitDebugSetting(podmpriv);
 }
 
-void rtl8188e_deinit_dm_priv(struct adapter *Adapter)
-{
-}
-
 /*  Add new function to reset the state of antenna diversity before link. */
 /*  Compare RSSI for deciding antenna */
 void AntDivCompare8188E(struct adapter *Adapter, struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src)
drivers/staging/rtl8188eu/include/rtl8188e_dm.h +0 -1
index 97a3175..5e0ac31 100644
@@ -51,7 +51,6 @@ struct	dm_priv {
 };
 
 void rtl8188e_init_dm_priv(struct adapter *adapt);
-void rtl8188e_deinit_dm_priv(struct adapter *adapt);
 void rtl8188e_InitHalDm(struct adapter *adapt);
 void rtl8188e_HalDmWatchDog(struct adapter *adapt);
 
Signature · 1 line
1.7.10.4
#10 lore raw

PATCH 11/24 staging: rtl8188eu: remove unused header inclusion from rtw_mp.c

In reply to navin patidar
---
 drivers/staging/rtl8188eu/core/rtw_mp.c |    1 -
 1 file changed, 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_mp.c +0 -1
index 705f666..17427a6 100644
@@ -21,7 +21,6 @@
 
 #include <drv_types.h>
 
-#include "odm_precomp.h"
 #include "rtl8188e_hal.h"
 #include <linux/vmalloc.h>
 
Signature · 1 line
1.7.10.4
#11 lore raw

PATCH 12/24 staging: rtl8188eu: Remove unused macros and enum defined in odm_types.h

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_types.h |   25 -------------------------
 1 file changed, 25 deletions(-)
drivers/staging/rtl8188eu/include/odm_types.h +0 -25
index 78ee2ba..c1355b9 100644
@@ -20,31 +20,13 @@
 #ifndef __ODM_TYPES_H__
 #define __ODM_TYPES_H__
 
-/*  */
-/*  Define Different SW team support */
-/*  */
-#define	ODM_AP			0x01	 /* BIT0 */
-#define	ODM_ADSL		0x02	/* BIT1 */
 #define	ODM_CE			0x04	/* BIT2 */
-#define	ODM_MP			0x08	/* BIT3 */
-
-#define		RT_PCI_INTERFACE				1
-#define		RT_USB_INTERFACE				2
-#define		RT_SDIO_INTERFACE				3
 
 enum HAL_STATUS {
 	HAL_STATUS_SUCCESS,
 	HAL_STATUS_FAILURE,
 };
 
-enum RT_SPINLOCK_TYPE {
-	RT_TEMP = 1,
-};
-
-#include <basic_types.h>
-
-#define DEV_BUS_TYPE	RT_USB_INTERFACE
-
 #define SET_TX_DESC_ANTSEL_A_88E(__pTxDesc, __Value)			\
 	SET_BITS_TO_LE_4BYTE(__pTxDesc+8, 24, 1, __Value)
 #define SET_TX_DESC_ANTSEL_B_88E(__pTxDesc, __Value)			\
@@ -52,11 +34,4 @@ enum RT_SPINLOCK_TYPE {
 #define SET_TX_DESC_ANTSEL_C_88E(__pTxDesc, __Value)			\
 	SET_BITS_TO_LE_4BYTE(__pTxDesc+28, 29, 1, __Value)
 
-/* define useless flag to avoid compile warning */
-#define	USE_WORKITEM			0
-#define		FOR_BRAZIL_PRETEST	0
-#define	BT_30_SUPPORT			0
-#define   FPGA_TWO_MAC_VERIFICATION	0
-
-
 #endif /*  __ODM_TYPES_H__ */
Signature · 1 line
1.7.10.4
#12 lore raw

PATCH 13/24 staging: rtl8188eu: Remove unused structure "rtl8192cd_priv"

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm.h |    8 --------
 1 file changed, 8 deletions(-)
drivers/staging/rtl8188eu/include/odm.h +0 -8
index 9d1a79c..e83812f 100644
@@ -90,14 +90,6 @@
 #define ANTTESTA		0x01	/* Ant A will be Testing */
 #define ANTTESTB		0x02	/* Ant B will be testing */
 
-/*  structure and define */
-
-/*  Add for AP/ADSLpseudo DM structuer requirement. */
-/*  We need to remove to other position??? */
-struct rtl8192cd_priv {
-	u8		temp;
-};
-
 struct rtw_dig {
 	u8		Dig_Enable_Flag;
 	u8		Dig_Ext_Port_Stage;
Signature · 1 line
1.7.10.4
#13 lore raw

PATCH 14/24 staging: rtl8188eu: Remove unused macros in odm_interface.h

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |   11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -11
index 548a309..3fc3e3c 100644
@@ -21,18 +21,7 @@
 #ifndef	__ODM_INTERFACE_H__
 #define __ODM_INTERFACE_H__
 
-/*  */
-/*  =========== Constant/Structure/Enum/... Define */
-/*  */
-
-/*  */
 /*  =========== Macro Define */
-/*  */
-
-#define _reg_all(_name)			ODM_##_name
-#define _reg_ic(_name, _ic)		ODM_##_name##_ic
-#define _bit_all(_name)			BIT_##_name
-#define _bit_ic(_name, _ic)		BIT_##_name##_ic
 
 /*  _cat: implemented by Token-Pasting Operator. */
 
Signature · 1 line
1.7.10.4
#14 lore raw

PATCH 15/24 staging: rtl8188eu: Remove unused function pointer declaration.

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |   10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -10
index 3fc3e3c..5338290 100644
@@ -58,16 +58,6 @@ enum odm_h2c_cmd {
 	ODM_MAX_H2CCMD
 };
 
-/*  2012/02/17 MH For non-MP compile pass only. Linux does not support workitem. */
-/*  Suggest HW team to use thread instead of workitem. Windows also support the feature. */
-typedef void (*RT_WORKITEM_CALL_BACK)(void *pContext);
-
-/*  =========== Extern Variable ??? It should be forbidden. */
-
-/*  =========== EXtern Function Prototype */
-
-/*  Memory Relative Function. */
-
 /*  ODM Timer relative API. */
 
 void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer);
Signature · 1 line
1.7.10.4
#15 lore raw

PATCH 16/24 staging: rtl8188eu: Remove unused function declaration.

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |    4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -4
index 5338290..ba58a67 100644
@@ -58,10 +58,6 @@ enum odm_h2c_cmd {
 	ODM_MAX_H2CCMD
 };
 
-/*  ODM Timer relative API. */
-
-void ODM_CancelTimer(struct odm_dm_struct *pDM_Odm, struct timer_list *pTimer);
-
 /*  ODM FW relative API. */
 u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum,
 		   u32 *pElementID, u32 *pCmdLen, u8 **pCmbBuffer,
Signature · 1 line
1.7.10.4
#16 lore raw

PATCH 17/24 staging: rtl8188eu: Use "ODM_REG_CCK_CCA_11N" in ODM_Write_CCK_CCA_Thres()

In reply to navin patidar

Use "ODM_REG_CCK_CCA_11N" directly instead of using ODM_REG(CCK_CCA, pDM_Odm) which produces same after preprocessing.

---
 drivers/staging/rtl8188eu/hal/odm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/odm.c +1 -1
index a39eba9..540527d 100644
@@ -842,7 +842,7 @@ void ODM_Write_CCK_CCA_Thres(struct odm_dm_struct *pDM_Odm, u8 CurCCK_CCAThres)
 	struct adapter *adapt = pDM_Odm->Adapter;
 
 	if (pDM_DigTable->CurCCK_CCAThres != CurCCK_CCAThres)		/* modify by Guo.Mingzhi 2012-01-03 */
-		rtw_write8(adapt, ODM_REG(CCK_CCA, pDM_Odm), CurCCK_CCAThres);
+		rtw_write8(adapt, ODM_REG_CCK_CCA_11N, CurCCK_CCAThres);
 	pDM_DigTable->PreCCK_CCAThres = pDM_DigTable->CurCCK_CCAThres;
 	pDM_DigTable->CurCCK_CCAThres = CurCCK_CCAThres;
 }
Signature · 1 line
1.7.10.4
#17 lore raw

PATCH 18/24 staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in odm_DIGInit()

In reply to navin patidar

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing.

---
 drivers/staging/rtl8188eu/hal/odm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/odm.c +1 -1
index 540527d..2bd68aa 100644
@@ -531,7 +531,7 @@ void odm_DIGInit(struct odm_dm_struct *pDM_Odm)
 	struct adapter *adapter = pDM_Odm->Adapter;
 	struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
 
-	pDM_DigTable->CurIGValue = (u8) PHY_QueryBBReg(adapter, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm));
+	pDM_DigTable->CurIGValue = (u8) PHY_QueryBBReg(adapter, ODM_REG_IGI_A_11N, ODM_BIT_IGI_11N);
 	pDM_DigTable->RssiLowThresh	= DM_DIG_THRESH_LOW;
 	pDM_DigTable->RssiHighThresh	= DM_DIG_THRESH_HIGH;
 	pDM_DigTable->FALowThresh	= DM_false_ALARM_THRESH_LOW;
Signature · 1 line
1.7.10.4
#18 lore raw

PATCH 19/24 staging: rtl8188eu: Remove unnecessary debugging message from ODM_Write_DIG()

In reply to navin patidar
---
 drivers/staging/rtl8188eu/hal/odm.c |    9 ---------
 1 file changed, 9 deletions(-)
drivers/staging/rtl8188eu/hal/odm.c +0 -9
index 2bd68aa..205ba7f 100644
@@ -511,19 +511,10 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)
 	struct rtw_dig *pDM_DigTable = &pDM_Odm->DM_DigTable;
 	struct adapter *adapter = pDM_Odm->Adapter;
 
-	ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD,
-		     ("ODM_REG(IGI_A,pDM_Odm)=0x%x, ODM_BIT(IGI,pDM_Odm)=0x%x\n",
-		     ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm)));
-
 	if (pDM_DigTable->CurIGValue != CurrentIGI) {
 		PHY_SetBBReg(adapter, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
-		ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD, ("CurrentIGI(0x%02x).\n", CurrentIGI));
-		/* pDM_DigTable->PreIGValue = pDM_DigTable->CurIGValue; */
 		pDM_DigTable->CurIGValue = CurrentIGI;
 	}
-	ODM_RT_TRACE(pDM_Odm, ODM_COMP_DIG, ODM_DBG_LOUD, ("ODM_Write_DIG():CurrentIGI=0x%x\n", CurrentIGI));
-
-/*  Add by Neil Chen to enable edcca to MP Platform */
 }
 
 void odm_DIGInit(struct odm_dm_struct *pDM_Odm)
Signature · 1 line
1.7.10.4
#19 lore raw

PATCH 20/24 staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in ODM_Write_DIG()

In reply to navin patidar

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing.

---
 drivers/staging/rtl8188eu/hal/odm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/odm.c +1 -1
index 205ba7f..2a0ac4a 100644
@@ -512,7 +512,7 @@ void ODM_Write_DIG(struct odm_dm_struct *pDM_Odm, u8 CurrentIGI)
 	struct adapter *adapter = pDM_Odm->Adapter;
 
 	if (pDM_DigTable->CurIGValue != CurrentIGI) {
-		PHY_SetBBReg(adapter, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm), CurrentIGI);
+		PHY_SetBBReg(adapter, ODM_REG_IGI_A_11N, ODM_BIT_IGI_11N, CurrentIGI);
 		pDM_DigTable->CurIGValue = CurrentIGI;
 	}
 }
Signature · 1 line
1.7.10.4
#20 lore raw

PATCH 21/24 staging: rtl8188eu: Remove unused macros defined in odm_interface.h

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |   30 ---------------------
 1 file changed, 30 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -30
index ba58a67..2c2991e 100644
@@ -21,36 +21,6 @@
 #ifndef	__ODM_INTERFACE_H__
 #define __ODM_INTERFACE_H__
 
-/*  =========== Macro Define */
-
-/*  _cat: implemented by Token-Pasting Operator. */
-
-/*===================================
-
-#define ODM_REG_DIG_11N		0xC50
-#define ODM_REG_DIG_11AC	0xDDD
-
-ODM_REG(DIG,_pDM_Odm)
-=====================================*/
-
-#define _reg_11N(_name)			ODM_REG_##_name##_11N
-#define _reg_11AC(_name)		ODM_REG_##_name##_11AC
-#define _bit_11N(_name)			ODM_BIT_##_name##_11N
-#define _bit_11AC(_name)		ODM_BIT_##_name##_11AC
-
-#define _cat(_name, _ic_type, _func)					\
-	(								\
-		(_ic_type) ? _func##_11N(_name) :			\
-		_func##_11AC(_name)					\
-	)
-
-/*  _name: name of register or bit. */
-/*  Example: "ODM_REG(R_A_AGC_CORE1, pDM_Odm)" */
-/*         gets "ODM_R_A_AGC_CORE1" or "ODM_R_A_AGC_CORE1_8192C",
- *	   depends on SupportICType. */
-#define ODM_REG(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _reg)
-#define ODM_BIT(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _bit)
-
 enum odm_h2c_cmd {
 	ODM_H2C_RSSI_REPORT = 0,
 	ODM_H2C_PSD_RESULT = 1,
Signature · 1 line
1.7.10.4
#21 lore raw

PATCH 22/24 staging: rtl8188eu: Remove unused function declaration.

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |    6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -6
index 2c2991e..e29ac79 100644
@@ -27,10 +27,4 @@ enum odm_h2c_cmd {
 	ODM_H2C_PathDiv = 2,
 	ODM_MAX_H2CCMD
 };
-
-/*  ODM FW relative API. */
-u32 ODM_FillH2CCmd(u8 *pH2CBuffer, u32 H2CBufferLen, u32 CmdNum,
-		   u32 *pElementID, u32 *pCmdLen, u8 **pCmbBuffer,
-		   u8 *CmdStartSeq);
-
 #endif	/*  __ODM_INTERFACE_H__ */
Signature · 1 line
1.7.10.4
#22 lore raw

PATCH 23/24 staging: rtl8188eu: Remove unused enum odm_h2c_cmd.

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |    6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8188eu/include/odm_interface.h +0 -6
index e29ac79..dc6b1c2 100644
@@ -21,10 +21,4 @@
 #ifndef	__ODM_INTERFACE_H__
 #define __ODM_INTERFACE_H__
 
-enum odm_h2c_cmd {
-	ODM_H2C_RSSI_REPORT = 0,
-	ODM_H2C_PSD_RESULT = 1,
-	ODM_H2C_PathDiv = 2,
-	ODM_MAX_H2CCMD
-};
 #endif	/*  __ODM_INTERFACE_H__ */
Signature · 1 line
1.7.10.4
#23 lore raw

PATCH 24/24 staging: rtl8188eu: Remove empty file odm_interface.h

In reply to navin patidar
---
 drivers/staging/rtl8188eu/include/odm_interface.h |   24 ---------------------
 drivers/staging/rtl8188eu/include/odm_precomp.h   |    1 -
 2 files changed, 25 deletions(-)
 delete mode 100644 drivers/staging/rtl8188eu/include/odm_interface.h
drivers/staging/rtl8188eu/include/odm_interface.h deleted +0 -24
deleted file mode 100644
index dc6b1c2..0000000
@@ -1,24 +0,0 @@
-/******************************************************************************
- *
- * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of version 2 of the GNU General Public License as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
- *
- ******************************************************************************/
-
-#ifndef	__ODM_INTERFACE_H__
-#define __ODM_INTERFACE_H__
-
-#endif	/*  __ODM_INTERFACE_H__ */
drivers/staging/rtl8188eu/include/odm_precomp.h +0 -1
index 6e6a656..2eb769b3 100644
@@ -44,7 +44,6 @@
 #include "Hal8188ERateAdaptive.h"/* for  RA,Power training */
 #include "rtl8188e_hal.h"
 
-#include "odm_interface.h"
 #include "odm_reg.h"
 
 #include "HalHWImg8188E_MAC.h"
Signature · 1 line
1.7.10.4