Skip to contentSkip to conversation

staging: comedi: remove check for CONFIG_KMOD

PATCH New Paul Bolle 1 participant 1 message May 26, 2014 Staging

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 staging: comedi: remove check for CONFIG_KMOD

The comedi driver was added in v2.6.29. That's the same release that removed the Kconfig symbol KMOD. So the code behind a test for its macro has been hidden since it was in staging. Remove it.

Remove a useless assignment to "dev->in_request_module" too. That variable seems pointless anyhow, but that's a different issue.

---
Untested. Done on top of next-20140526.

 drivers/staging/comedi/comedi_fops.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/staging/comedi/comedi_fops.c +0 -8
index 012c8fd1aabb..70ad00c501ef 100644
@@ -2351,14 +2351,6 @@ static int comedi_open(struct inode *inode, struct file *file)
 	if (capable(CAP_NET_ADMIN) && dev->in_request_module)
 		goto ok;
 
-	dev->in_request_module = true;
-
-#ifdef CONFIG_KMOD
-	mutex_unlock(&dev->mutex);
-	request_module("char-major-%i-%i", COMEDI_MAJOR, dev->minor);
-	mutex_lock(&dev->mutex);
-#endif
-
 	dev->in_request_module = false;
 
 	if (!dev->attached && !capable(CAP_NET_ADMIN)) {
Signature · 1 line
1.9.0