parser: use symbolic expression for ether too

PATCH New Pablo Neira Ayuso 1 participant 1 message May 28, 2014 netfilter

Share & tools

Pablo Neira Ayuso

author maintainer

2014-05-28 08:06 UTC #0 lore raw

PATCH 1/1 parser: use symbolic expression for ether too

Like in 0dbced3 ("parser: use symbolic expressions for parsing keywords as protocol values"), convert `ether' to use a symbolic expression.

This fixes:

 # nft add rule ip filter input meta iiftype ether
 # nft list table filter
 table ip filter {
	...
	iiftype 256

which was converted to network byte order.

Reported-by Ana Rey <[email protected]>

Signed-off-by Pablo Neira Ayuso <[email protected]>

---
 src/parser.y |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

src/parser.y +3 -4

index 20a836e..38b655d 100644
@@ -1848,10 +1848,9 @@ eth_hdr_expr		:	ETHER	eth_hdr_field
 			}
 			|	ETHER
 			{
-				uint16_t data = ARPHRD_ETHER;
-				$$ = constant_expr_alloc(&@$, &arphrd_type,
-							 BYTEORDER_BIG_ENDIAN,
-							 sizeof(data) * BITS_PER_BYTE, &data);
+				$$ = symbol_expr_alloc(&@$, SYMBOL_VALUE,
+						       current_scope(state),
+						       "ether");
 			}
 			;

Signature · 1 line

1.7.10.4