mtd: lpc32xx: drop bitflip_threshold initialization

PATCH Applied Brian Norris 1 participant 2 messages May 28, 2014 – Jul 3, 2014

Subsystems (3)

Memory technology devices (MTD) NAND flash Arm/LPC32XX SoC support

lore

Share & tools

lore

Brian Norris

author

2014-05-28 08:53 UTC #0 lore raw

PATCH 1/1 mtd: lpc32xx: drop bitflip_threshold initialization

These drivers don't need to explicitly initialize their bitflip thresholds. The comment is no longer correct, since nand_scan_tail() performs this initialization as of the following commit:

commit ea3b2ea24ef0f2ef9c6795b19cff456195b6728a
Author: Shmulik Ladkani <[email protected]>
Date: Fri Jun 8 18:29:06 2012 +0300

mtd: nand: initialize bitflip_threshold prior to BBT scanning

(It seems there were some parallel efforts on writing/submitting these drivers, and Shmulik's bug fix.)

Signed-off-by Brian Norris <[email protected]>

Cc Roland Stigge <[email protected]>

---
Not tested

 drivers/mtd/nand/lpc32xx_mlc.c | 6 ------
 drivers/mtd/nand/lpc32xx_slc.c | 6 ------
 2 files changed, 12 deletions(-)

drivers/mtd/nand/lpc32xx_mlc.c +0 -6

index 687478c9f09c..7335346dc126 100644
@@ -721,12 +721,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
 	nand_chip->bbt_td = &lpc32xx_nand_bbt;
 	nand_chip->bbt_md = &lpc32xx_nand_bbt_mirror;
 
-	/* bitflip_threshold's default is defined as ecc_strength anyway.
-	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-	 * being 0, it causes bad block table scanning errors in
-	 * nand_scan_tail(), so preparing it here. */
-	mtd->bitflip_threshold = nand_chip->ecc.strength;
-
 	if (use_dma) {
 		res = lpc32xx_dma_setup(host);
 		if (res) {

drivers/mtd/nand/lpc32xx_slc.c +0 -6

index 53a6742e3da3..8caef28e0756 100644
@@ -840,12 +840,6 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
 	chip->ecc.strength = 1;
 	chip->ecc.hwctl = lpc32xx_nand_ecc_enable;
 
-	/* bitflip_threshold's default is defined as ecc_strength anyway.
-	 * Unfortunately, it is set only later at add_mtd_device(). Meanwhile
-	 * being 0, it causes bad block table scanning errors in
-	 * nand_scan_tail(), so preparing it here already. */
-	mtd->bitflip_threshold = chip->ecc.strength;
-
 	/*
 	 * Allocate a large enough buffer for a single huge page plus
 	 * extra space for the spare area and ECC storage area

Signature · 1 line

1.9.1

Brian Norris

author Applied

2014-07-03 00:25 UTC #1 lore raw

Quoted 8 lines · Brian Norris

These drivers don't need to explicitly initialize their bitflip thresholds. The comment is no longer correct, since nand_scan_tail() performs this initialization as of the following commit:
commit ea3b2ea24ef0f2ef9c6795b19cff456195b6728a
Author: Shmulik Ladkani <[email protected]>
Date: Fri Jun 8 18:29:06 2012 +0300

Quoted 7 lines

mtd: nand: initialize bitflip_threshold prior to BBT scanning
(It seems there were some parallel efforts on writing/submitting these drivers, and Shmulik's bug fix.)
Signed-off-by Brian Norris <[email protected]>
Cc Roland Stigge <[email protected]>

Pushed to l2-mtd.git.

Brian