Skip to contentSkip to conversation

MAINTAINERS: drop two usb-serial subdriver entries

PATCH In review Johan Hovold 4 participants 7 messages Jun 1, 2014 – Jun 23, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: drop two usb-serial subdriver entries

Remove the remaining two obsolete usb-serial subdriver entries from MAINTAINERS, which were missed in the recent purge by commit f896b7968b62 ("USB: Maintainers change for usb serial drivers").

---
 MAINTAINERS | 12 ------------
 1 file changed, 12 deletions(-)
MAINTAINERS +0 -12
index 51ebb779c5f3..68599b26f514 100644
@@ -9298,12 +9298,6 @@ S:	Maintained
 F:	drivers/usb/host/isp116x*
 F:	include/linux/usb/isp116x.h
 
-USB KAWASAKI LSI DRIVER
-M:	Oliver Neukum <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/kl5kusb105.*
-
 USB MASS STORAGE DRIVER
 M:	Matthew Dharm <[email protected]>
 L:	[email protected]
@@ -9331,12 +9325,6 @@ S:	Maintained
 F:	Documentation/usb/ohci.txt
 F:	drivers/usb/host/ohci*
 
-USB OPTION-CARD DRIVER
-M:	Matthias Urlichs <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/option.c
-
 USB PEGASUS DRIVER
 M:	Petko Manolov <[email protected]>
 L:	[email protected]
Signature · 1 line
1.8.5.5
#1 lore raw
Quoted 27 lines · Johan Hovold

Remove the remaining two obsolete usb-serial subdriver entries from MAINTAINERS, which were missed in the recent purge by commit f896b7968b62 ("USB: Maintainers change for usb serial drivers").

---
 MAINTAINERS | 12 ------------
 1 file changed, 12 deletions(-)
MAINTAINERS +0 -6
index 51ebb779c5f3..68599b26f514 100644
@@ -9298,12 +9298,6 @@ S:	Maintained
 F:	drivers/usb/host/isp116x*
 F:	include/linux/usb/isp116x.h
 
-USB KAWASAKI LSI DRIVER
-M:	Oliver Neukum <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/kl5kusb105.*
-
 USB MASS STORAGE DRIVER
 M:	Matthew Dharm <[email protected]>
 L:	[email protected]

MAINTAINERS S: Maintained · line 9338

Quoted 8 lines
MAINTAINERS +0 -5
@@ -9331,12 +9325,6 @@ S:	Maintained
 F:	Documentation/usb/ohci.txt
 F:	drivers/usb/host/ohci*
 
-USB OPTION-CARD DRIVER
-M:	Matthias Urlichs <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/option.c

Why are we taking away the maintainership of these individual drivers from these developers? I had no problem giving you the drivers I was supposed to be in charge of, but I need a signed-off-by from Matthias and Oliver for these if they want to do the same.

thanks,

greg k-h

#2 lore raw
Quoted 31 lines · Greg Kroah-Hartman
Quoted 30 lines · Johan Hovold

Remove the remaining two obsolete usb-serial subdriver entries from MAINTAINERS, which were missed in the recent purge by commit f896b7968b62 ("USB: Maintainers change for usb serial drivers").

---
 MAINTAINERS | 12 ------------
 1 file changed, 12 deletions(-)
MAINTAINERS +0 -6
index 51ebb779c5f3..68599b26f514 100644
@@ -9298,12 +9298,6 @@ S:	Maintained
 F:	drivers/usb/host/isp116x*
 F:	include/linux/usb/isp116x.h
 
-USB KAWASAKI LSI DRIVER
-M:	Oliver Neukum <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/kl5kusb105.*
-
 USB MASS STORAGE DRIVER
 M:	Matthew Dharm <[email protected]>
 L:	[email protected]
@@ -9331,12 +9325,6 @@ S:	Maintained
 F:	Documentation/usb/ohci.txt
 F:	drivers/usb/host/ohci*
 
Quoted 10 lines

MAINTAINERS S: Maintained · line 9338

Quoted 5 lines
MAINTAINERS +0 -5
-USB OPTION-CARD DRIVER
-M:	Matthias Urlichs <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/option.c

Why are we taking away the maintainership of these individual drivers from these developers? I had no problem giving you the drivers I was supposed to be in charge of, but I need a signed-off-by from Matthias and Oliver for these if they want to do the same.

I honestly thought you had just missed these entries when you removed individual maintainership for the other usb-serial drivers with the motivation that the developers were not around and that maintainership for individual drivers did not make much sense anymore (as consolidation proceeds, I read). (These two entries were also not grouped with the others.)

Oliver and perhaps also Mathias are still around, but the option driver is now down to about 200 LOC (including boilerplate) when not counting the id table, while the kl5kusb105 is currently at about 400 LOC (including boilerplate) since I converted it to use the generic implementation a few years ago.

Oliver and Mathias, what do you think of this? Would you be willing to sign off on this patch?

Thanks,
Johan

#3 lore raw

Hi,

Johan Hovold:

Quoted 18 lines
Quoted 10 lines

MAINTAINERS S: Maintained · line 9338

Quoted 5 lines
MAINTAINERS +0 -5
-USB OPTION-CARD DRIVER
-M:	Matthias Urlichs <[email protected]>
-L:	[email protected]
-S:	Maintained
-F:	drivers/usb/serial/option.c

Why are we taking away the maintainership of these individual drivers from these developers? I had no problem giving you the drivers I was supposed to be in charge of, but I need a signed-off-by from Matthias and Oliver for these if they want to do the same.

I honestly thought you had just missed these entries when you removed individual maintainership for the other usb-serial drivers with the motivation that the developers were not around and that maintainership for individual drivers did not make much sense anymore (as consolidation proceeds, I read). (These two entries were also not grouped with the others.)

Quoted 9 lines

Oliver and perhaps also Mathias are still around, but the option driver is now down to about 200 LOC (including boilerplate) when not counting the id table, while the kl5kusb105 is currently at about 400 LOC (including boilerplate) since I converted it to use the generic implementation a few years ago.

Oliver and Mathias, what do you think of this? Would you be willing to sign off on this patch?

Fine by me. While I am indeed "still around", Option doesn't need a maintainer any more -- the thing just works, and I do not see any need for driver-specific changes other than additions to the ID table.

You hardly need a maintainer for that.

Signature · 1 line
-- Matthias Urlichs
#5 lore raw
Quoted 8 lines · Matthias Urlichs

Hi,

Matthias Urlichs:

Quoted 1 line

Fine by me.

or, in other words:

I've now applied this to my usb-linus branch with yours and Oliver's signed-offs.

Thanks,
Johan

#6 lore raw
In reply to Johan Hovold
Quoted 9 lines · Johan Hovold

Oliver and perhaps also Mathias are still around, but the option driver
is now down to about 200 LOC (including boilerplate) when not counting the id table, while the kl5kusb105 is currently at about 400 LOC (including boilerplate) since I converted it to use the generic implementation a few years ago.

Oliver and Mathias, what do you think of this? Would you be willing to sign off on this patch?

Regards
Oliver