Skip to contentSkip to conversation

image_types_fsl.bbclass: add uboot.mxsboot-nand image generation

PATCH In review Alexey Ignatov 2 participants 4 messages Jun 2, 2014 Arm i.MX and Layerscape

lore
Share & tools
lore

Alexey Ignatov

author
#0 lore raw

PATCH 1/2 image_types_fsl.bbclass: add uboot.mxsboot-nand image generation

---
 classes/image_types_fsl.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)
classes/image_types_fsl.bbclass +6 -0
index dfa55e4..d585512 100644
@@ -59,6 +59,12 @@ IMAGE_DEPENDS_uboot.mxsboot-sdcard = "u-boot-mxsboot-native:do_populate_sysroot
 IMAGE_CMD_uboot.mxsboot-sdcard = "mxsboot sd ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.${UBOOT_SUFFIX} \
                                              ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.uboot.mxsboot-sdcard"
 
+IMAGE_DEPENDS_uboot.mxsboot-nand = "u-boot-mxsboot-native:do_populate_sysroot \
+                                      u-boot:do_deploy"
+IMAGE_CMD_uboot.mxsboot-nand = "mxsboot ${MXSBOOT_ARGS} nand \
+                                             ${DEPLOY_DIR_IMAGE}/u-boot-${MACHINE}.${UBOOT_SUFFIX} \
+                                             ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.uboot.mxsboot-nand"
+
 # Boot partition volume id
 BOOTDD_VOLUME_ID ?= "Boot ${MACHINE}"
Signature · 1 line
1.8.2.1
author
#1 lore raw

PATCH 2/2 imx28evk: add MXSBOOT_ARGS

---
 conf/machine/imx28evk.conf | 1 +
 1 file changed, 1 insertion(+)
conf/machine/imx28evk.conf +1 -0
index d4f1ad6..23d4bd8 100644
@@ -29,6 +29,7 @@ MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
 
 MKUBIFS_ARGS = "--min-io-size 4096 --leb-size 516096 --max-leb-cnt 8139"
 UBINIZE_ARGS = "--min-io-size 4096 --peb-size 524288 --sub-page-size 4096"
+MXSBOOT_ARGS = "-w 4096 -o 218 -e 524288"
 
 ## To determine parameters' values, run "ubiattach -m 6 /dev/ubi_ctrl"
 ## (assuming the rootfs device is /dev/mtd6).  Here's an example:
Signature · 1 line
1.8.2.1
#2 lore raw

Re: [PATCH 2/2] imx28evk: add MXSBOOT_ARGS

Hello Alexey,

On Mon, Jun 2, 2014 at 10:24 AM, Alexey Ignatov <[email protected]> wrote:

Please explain what you are doing and not the code here, as I suggested in the other patch commit log. Please the means of the params so users can understand and change them if needed.

Also please change the variable name accordingly.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw
In reply to Alexey Ignatov

Hello Alexey,

Thanks for sending this for upstreaming. Please see the comments below...

On Mon, Jun 2, 2014 at 10:24 AM, Alexey Ignatov <[email protected]> wrote:

Please describe it more extensively in the commitlog, something as:

image_types_fsl.bbclass: Add U-Boot NAND support for i.MX23/i.MX28

This adds support to generate the U-Boot image for use with NAND (uboot.mxsboot-nand) and allows for custom params to be given for mxsboot using the MXSBOOT_NAND_ARGS variable which should be defined in the machine definition file.

Signed-off-by ...
Quoted 4 lines
classes/image_types_fsl.bbclass +0 -0
index dfa55e4..d585512 100644

...

Quoted 1 line

+IMAGE_CMD_uboot.mxsboot-nand = "mxsboot ${MXSBOOT_ARGS} nand \

...

Change it to MXSBOOT_NAND_ARGS as we may want MXSBOOT_SD_ARGS or others later.

You need to add a week definition of MXSBOOT_NAND_ARGS in the began of the class as:

# Extra params to pass for MXSBOOT_NAND_ARGS
MXSBOOT_NAND_ARGS ?= ""

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750