Skip to contentSkip to conversation

drm/i915: Drop unused lut tables from intel_plane

PATCH Applied Matt Roper 3 participants 3 messages Jun 2, 2014 – Jun 3, 2014

Subsystems (2)
lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 drm/i915: Drop unused lut tables from intel_plane

---
 drivers/gpu/drm/i915/intel_drv.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/intel_drv.h +0 -1
index 76de420..fea8e05 100644
@@ -428,7 +428,6 @@ struct intel_plane {
 	struct drm_i915_gem_object *obj;
 	bool can_scale;
 	int max_downscale;
-	u32 lut_r[1024], lut_g[1024], lut_b[1024];
 	int crtc_x, crtc_y;
 	unsigned int crtc_w, crtc_h;
 	uint32_t src_x, src_y;
Signature · 1 line
1.8.5.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Matt Roper

The commit message is a bit terse and could do with some digging. Something like:

Those LUT where defined in the original sprite patch introducing intel_plane, but were never used.

commit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
Author: Jesse Barnes <[email protected]>
Date: Tue Dec 13 13:19:38 2011 -0800

drm/i915: add SNB and IVB video sprite support v6

Quoted 23 lines
---
 drivers/gpu/drm/i915/intel_drv.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/intel_drv.h +0 -1
index 76de420..fea8e05 100644
@@ -428,7 +428,6 @@ struct intel_plane {
 	struct drm_i915_gem_object *obj;
 	bool can_scale;
 	int max_downscale;
-	u32 lut_r[1024], lut_g[1024], lut_b[1024];
 	int crtc_x, crtc_y;
 	unsigned int crtc_w, crtc_h;
 	uint32_t src_x, src_y;
Signature · 6 lines
1.8.5.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 6 lines · Damien Lespiau
Quoted 1 line · Matt Roper

The commit message is a bit terse and could do with some digging. Something like:

Quoted 8 lines

Those LUT where defined in the original sprite patch introducing intel_plane, but were never used.

commit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
Author: Jesse Barnes <[email protected]>
Date: Tue Dec 13 13:19:38 2011 -0800

drm/i915: add SNB and IVB video sprite support v6

Added.

Quoted 1 line

Queued for -next, thanks for the patch.
-Daniel

Quoted 28 lines
Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_drv.h | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/intel_drv.h +0 -1
index 76de420..fea8e05 100644
@@ -428,7 +428,6 @@ struct intel_plane {
 	struct drm_i915_gem_object *obj;
 	bool can_scale;
 	int max_downscale;
-	u32 lut_r[1024], lut_g[1024], lut_b[1024];
 	int crtc_x, crtc_y;
 	unsigned int crtc_w, crtc_h;
 	uint32_t src_x, src_y;
Signature · 6 lines
1.8.5.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch