Skip to contentSkip to conversation

drm/i915: Replace remaining drm_get_connector_name(c) by c->name.

PATCH In review Rodrigo Vivi 3 participants 5 messages Jun 4, 2014 – Jun 5, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Replace remaining drm_get_connector_name(c) by c->name.

---
 drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_fbdev.c +1 -1
index e768207..b5448d8 100644
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
 		/* No preferred mode marked by the EDID? Are there any modes? */
 		if (!modes[i] && !list_empty(&connector->modes)) {
 			DRM_DEBUG_KMS("using first mode listed on connector %s\n",
-				      drm_get_connector_name(connector));
+				      connector->name);
 			modes[i] = list_first_entry(&connector->modes,
 						    struct drm_display_mode,
 						    head);
Signature · 1 line
1.9.3
#1 lore raw

This is breaking -nightly build!

Quoted 27 lines · Rodrigo Vivi
---
 drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_fbdev.c +0 -0
index e768207..b5448d8 100644
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct
 drm_fb_helper *fb_helper,
                /* No preferred mode marked by the EDID? Are there any

modes? */
if (!modes[i] && !list_empty(&connector->modes)) {
DRM_DEBUG_KMS("using first mode listed on
connector %s\n",

drivers/gpu/drm/i915/intel_fbdev.c +1 -1
-                                     drm_get_connector_name(connector));
+                                     connector->name);
                        modes[i] = list_first_entry(&connector->modes,
                                                    struct

drm_display_mode,

                                                    head);

--
1.9.3

Signature · 2 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rodrigo Vivi

2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <[email protected]>:

Quoted 1 line

Yeah, this seems to make -nightly compile.

Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_fbdev.c +1 -2
index e768207..b5448d8 100644
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
                /* No preferred mode marked by the EDID? Are there any modes? */
                if (!modes[i] && !list_empty(&connector->modes)) {
                        DRM_DEBUG_KMS("using first mode listed on connector %s\n",
-                                     drm_get_connector_name(connector));
+                                     connector->name);
                        modes[i] = list_first_entry(&connector->modes,
                                                    struct drm_display_mode,
                                                    head);
--

1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 1 line
Paulo Zanoni
#3 lore raw
Quoted 6 lines · Paulo Zanoni

2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <[email protected]>:

Quoted 1 line

Yeah, this seems to make -nightly compile.

Sorry my script for fixing up the -nightly build failed. I've spotted this but then lost the manual fixup patch again :(

Should work now correctly and Dave is doing a backport of drm-fixes into drm-next to resolve this. My apologies for the mess I've caused here. -Daniel

Quoted 34 lines
Quoted 25 lines
---
 drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_fbdev.c +1 -2
index e768207..b5448d8 100644
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
                /* No preferred mode marked by the EDID? Are there any modes? */
                if (!modes[i] && !list_empty(&connector->modes)) {
                        DRM_DEBUG_KMS("using first mode listed on connector %s\n",
-                                     drm_get_connector_name(connector));
+                                     connector->name);
                        modes[i] = list_first_entry(&connector->modes,
                                                    struct drm_display_mode,
                                                    head);
--

1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#4 lore raw
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Paulo Zanoni

2014-06-04 15:47 GMT-03:00 Rodrigo Vivi <[email protected]>:

Quoted 1 line

Yeah, this seems to make -nightly compile.

Quoted 7 lines
Quoted 1 line

Sorry my script for fixing up the -nightly build failed. I've spotted this but then lost the manual fixup patch again :(

Should work now correctly and Dave is doing a backport of drm-fixes into drm-next to resolve this. My apologies for the mess I've caused here.

Forgotten to add Dave.
-Daniel

Quoted 39 lines
Quoted 34 lines
Quoted 25 lines
---
 drivers/gpu/drm/i915/intel_fbdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_fbdev.c +1 -2
index e768207..b5448d8 100644
@@ -390,7 +390,7 @@ static bool intel_fb_initial_config(struct drm_fb_helper *fb_helper,
                /* No preferred mode marked by the EDID? Are there any modes? */
                if (!modes[i] && !list_empty(&connector->modes)) {
                        DRM_DEBUG_KMS("using first mode listed on connector %s\n",
-                                     drm_get_connector_name(connector));
+                                     connector->name);
                        modes[i] = list_first_entry(&connector->modes,
                                                    struct drm_display_mode,
                                                    head);
--

1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch