Skip to contentSkip to conversation

serial: samsung: Use %pa to print 'resource_size_t' type

PATCH In review Fabio Estevam 2 participants 2 messages Jun 4, 2014 – Jun 5, 2014

Subsystems (2)
Arm Samsung Exynos TTY layer and serial drivers
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 serial: samsung: Use %pa to print 'resource_size_t' type

From: Fabio Estevam <[email protected]>

When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning is seen:

drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
drivers/tty/serial/samsung.c:1229:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'resource_size_t' [-Wformat]

Use %pa to print 'resource_size_t' type to fix the warning.

Reported-by Olof's autobuilder <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/tty/serial/samsung.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/samsung.c +2 -2
index 3293377..b7b8185 100644
@@ -1226,8 +1226,8 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
 		wr_regl(port, S3C64XX_UINTSP, 0xf);
 	}
 
-	dbg("port: map=%08x, mem=%p, irq=%d (%d,%d), clock=%u\n",
-	    port->mapbase, port->membase, port->irq,
+	dbg("port: map=%pa, mem=%p, irq=%d (%d,%d), clock=%u\n",
+	    &port->mapbase, port->membase, port->irq,
 	    ourport->rx_irq, ourport->tx_irq, port->uartclk);
 
 	/* reset the fifos (and setup the uart) */
Signature · 1 line
1.8.3.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning is seen:

Quoted 8 lines

drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port':
drivers/tty/serial/samsung.c:1229:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'resource_size_t' [-Wformat]

Use %pa to print 'resource_size_t' type to fix the warning.

Reported-by Olof's autobuilder <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Jingoo Han <[email protected]>

Best regards,
Jingoo Han

Quoted 21 lines
---
 drivers/tty/serial/samsung.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/samsung.c +2 -3
index 3293377..b7b8185 100644
@@ -1226,8 +1226,8 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport,
 		wr_regl(port, S3C64XX_UINTSP, 0xf);
 	}
 
-	dbg("port: map=%08x, mem=%p, irq=%d (%d,%d), clock=%u\n",
-	    port->mapbase, port->membase, port->irq,
+	dbg("port: map=%pa, mem=%p, irq=%d (%d,%d), clock=%u\n",
+	    &port->mapbase, port->membase, port->irq,
 	    ourport->rx_irq, ourport->tx_irq, port->uartclk);
 
 	/* reset the fifos (and setup the uart) */
--

1.8.3.2