Skip to contentSkip to conversation

drm/i915: BDW: Adding missing cursor offsets.

PATCH In review Rodrigo Vivi 3 participants 4 messages Jun 5, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: BDW: Adding missing cursor offsets.

BDW uses IVB cursor offsets.

Whithout this patch it is not possible to use multiple outputs with cursor on BDW.
The cursor gets completely crazy because update position uses the wrong cursor register for the second pipe.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/i915_drv.c +2 -0
index f9cd5ff..615b62f 100644
@@ -315,6 +315,7 @@ static const struct intel_device_info intel_broadwell_m_info = {
 	.has_ddi = 1,
 	.has_fbc = 1,
 	GEN_DEFAULT_PIPEOFFSETS,
+	IVB_CURSOR_OFFSETS,
 };
 
 static const struct intel_device_info intel_broadwell_gt3d_info = {
@@ -325,6 +326,7 @@ static const struct intel_device_info intel_broadwell_gt3d_info = {
 	.has_ddi = 1,
 	.has_fbc = 1,
 	GEN_DEFAULT_PIPEOFFSETS,
+	IVB_CURSOR_OFFSETS,
 };
 
 static const struct intel_device_info intel_broadwell_gt3m_info = {
Signature · 1 line
1.9.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Rodrigo Vivi

BDW uses IVB cursor offsets.

Whithout this patch it is not possible to use multiple outputs with cursor on BDW.
The cursor gets completely crazy because update position uses the wrong cursor register for the second pipe.

Should be cc: stable IMO
[snip]

Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
#2 lore raw

I just noticed and verified this patch fixes this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=79621

Quoted 18 lines · Ben Widawsky
Quoted 3 lines · Rodrigo Vivi

BDW uses IVB cursor offsets.

Whithout this patch it is not possible to use multiple outputs with

cursor

Quoted 5 lines

on BDW.
The cursor gets completely crazy because update position uses the wrong cursor register for the second pipe.

Should be cc: stable IMO
[snip]

--
Ben Widawsky, Intel Open Source Technology Center

Signature · 2 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Ben Widawsky
Quoted 10 lines · Ben Widawsky
Quoted 8 lines · Rodrigo Vivi

BDW uses IVB cursor offsets.

Whithout this patch it is not possible to use multiple outputs with cursor on BDW.
The cursor gets completely crazy because update position uses the wrong cursor register for the second pipe.

Thanks.

Quoted 3 lines

Should be cc: stable IMO
[snip]

Agreed.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch