Skip to contentSkip to conversation

README: update piglit instructions

PATCH In review Thomas Wood 2 participants 21 messages Jun 10, 2014 – Jun 11, 2014 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 README: update piglit instructions

Piglit now has a top level "piglit" command and the location of the tests can now be read from an environment variable.

---
 README | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
README +10 -17
index 2cfb5c5..cfa186d 100644
@@ -34,32 +34,25 @@ tests/
 
 	git://anongit.freedesktop.org/piglit
 
-	and build it (no need to install anything). Then we need to link up the
-	i-g-t sources with piglit
+	There is no need to build and install piglit if it is only going to be
+	used for running i-g-t tests.
+
+	Set the IGT_TEST_ROOT environment variable to point to the tests
+	directory or link up the i-g-t sources with piglit using a symlink:
 
 	piglit-sources $ cd bin
 	piglit-sources/bin $ ln $i-g-t-sources igt -s
 
-	To avoid some hassles with piglit's use of Waffle just disable it. Run
-
-	piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
-
-	With
-
-	piglit-sources $ ccmake .
-
-	you can check your configuration with a curses interface, too.
-
-	The tests in the i-g-t sources need to have been built already. Then we
-	can run the testcases with (as usual as root, no other drm clients
-	running):
+	In both cases, the tests in the i-g-t sources need to have been built
+	already. Then we can run the testcases with (as usual as root, no other
+	drm clients running):
 
-	piglit-sources # ./piglit-run.py igt <results-file>
+	piglit-sources # ./piglit run igt <results-file>
 
 	The testlist is built at runtime, so no need to update anything in
 	piglit when adding new tests. See
 
-	piglit-sources $ ./piglit-run.py -h
+	piglit-sources $ ./piglit run -h
 
 	for some useful options.
 
Signature · 1 line
1.9.3
#1 lore raw

PATCH 2/7 lib: remove /** from comments that are not API documentation

These comments are not gtk-doc comments, so replacing /** with /* prevents any gtk-doc warnings.

---
 lib/i915_3d.h         |  26 ++--
 lib/intel_reg.h       | 404 +++++++++++++++++++++++++-------------------------
 lib/rendercopy_gen8.c |   6 +-
 3 files changed, 218 insertions(+), 218 deletions(-)
lib/i915_3d.h +13 -13
index 04531f3..eea379c 100644
@@ -324,7 +324,7 @@ enum i915_fs_channel {
 (z##_CHANNEL_VAL << Z_CHANNEL_SHIFT) | \
 (w##_CHANNEL_VAL << W_CHANNEL_SHIFT)
 
-/**
+/*
  * Construct an operand description for using a register with no swizzling
  */
 #define i915_fs_operand_reg(reg)					\
@@ -333,17 +333,17 @@ enum i915_fs_channel {
 #define i915_fs_operand_reg_negate(reg)					\
 	i915_fs_operand(reg, NEG_X, NEG_Y, NEG_Z, NEG_W)
 
-/**
+/*
  * Returns an operand containing (0.0, 0.0, 0.0, 0.0).
  */
 #define i915_fs_operand_zero() i915_fs_operand(FS_R0, ZERO, ZERO, ZERO, ZERO)
 
-/**
+/*
  * Returns an unused operand
  */
 #define i915_fs_operand_none() i915_fs_operand_zero()
 
-/**
+/*
  * Returns an operand containing (1.0, 1.0, 1.0, 1.0).
  */
 #define i915_fs_operand_one() i915_fs_operand(FS_R0, ONE, ONE, ONE, ONE)
@@ -351,7 +351,7 @@ enum i915_fs_channel {
 #define i915_get_hardware_channel_val(val, shift, negate) \
 	(((val & 0x7) << shift) | ((val & 0x8) ? negate : 0))
 
-/**
+/*
  * Outputs a fragment shader command to declare a sampler or texture register.
  */
 #define i915_fs_dcl(reg)						\
@@ -519,19 +519,19 @@ enum i915_fs_channel {
 		       i915_fs_operand_none(),			\
 		       i915_fs_operand_none())
 
-/** Add operand0 and operand1 and put the result in dest_reg */
+/* Add operand0 and operand1 and put the result in dest_reg */
 #define i915_fs_add(dest_reg, operand0, operand1)			\
 	i915_fs_arith (ADD, dest_reg, \
 		       operand0, operand1,	\
 		       i915_fs_operand_none())
 
-/** Multiply operand0 and operand1 and put the result in dest_reg */
+/* Multiply operand0 and operand1 and put the result in dest_reg */
 #define i915_fs_mul(dest_reg, operand0, operand1)			\
 	i915_fs_arith (MUL, dest_reg, \
 		       operand0, operand1,	\
 		       i915_fs_operand_none())
 
-/** Computes 1/sqrt(operand0.replicate_swizzle) puts the result in dest_reg */
+/* Computes 1/sqrt(operand0.replicate_swizzle) puts the result in dest_reg */
 #define i915_fs_rsq(dest_reg, dest_mask, operand0)		\
 	do {									\
 		if (dest_mask) {							\
@@ -547,13 +547,13 @@ enum i915_fs_channel {
 		} \
 	} while (0)
 
-/** Puts the minimum of operand0 and operand1 in dest_reg */
+/* Puts the minimum of operand0 and operand1 in dest_reg */
 #define i915_fs_min(dest_reg, operand0, operand1)			\
 	i915_fs_arith (MIN, dest_reg, \
 		       operand0, operand1, \
 		       i915_fs_operand_none())
 
-/** Puts the maximum of operand0 and operand1 in dest_reg */
+/* Puts the maximum of operand0 and operand1 in dest_reg */
 #define i915_fs_max(dest_reg, operand0, operand1)			\
 	i915_fs_arith (MAX, dest_reg, \
 		       operand0, operand1, \
@@ -562,7 +562,7 @@ enum i915_fs_channel {
 #define i915_fs_cmp(dest_reg, operand0, operand1, operand2)		\
 	i915_fs_arith (CMP, dest_reg, operand0, operand1, operand2)
 
-/** Perform operand0 * operand1 + operand2 and put the result in dest_reg */
+/* Perform operand0 * operand1 + operand2 and put the result in dest_reg */
 #define i915_fs_mad(dest_reg, dest_mask, op0, op1, op2)	\
 	do {									\
 		if (dest_mask) {							\
@@ -581,7 +581,7 @@ enum i915_fs_channel {
 		} \
 	} while (0)
 
-/**
+/*
  * Perform a 3-component dot-product of operand0 and operand1 and put the
  * resulting scalar in the channels of dest_reg specified by the dest_mask.
  */
@@ -597,7 +597,7 @@ enum i915_fs_channel {
 		} \
 	} while (0)
 
-/**
+/*
  * Sets up local state for accumulating a fragment shader buffer.
  *
  * \param x maximum number of shader commands that may be used between
lib/intel_reg.h +202 -202

992 lines not on this page · raw message

lib/rendercopy_gen8.c +3 -3
index e7567d2..a32871d 100644
@@ -286,7 +286,7 @@ gen8_fill_ps(struct intel_batchbuffer *batch,
 	return offset;
 }
 
-/**
+/*
  * gen7_fill_vertex_buffer_data populate vertex buffer with data.
  *
  * The vertex buffer consists of 3 vertices to construct a RECTLIST. The 4th
@@ -327,7 +327,7 @@ gen7_fill_vertex_buffer_data(struct intel_batchbuffer *batch,
 	return offset;
 }
 
-/**
+/*
  * gen6_emit_vertex_elements - The vertex elements describe the contents of the
  * vertex buffer. We pack the vertex buffer in a semi weird way, conforming to
  * what gen6_rendercopy did. The most straightforward would be to store
@@ -384,7 +384,7 @@ gen6_emit_vertex_elements(struct intel_batchbuffer *batch) {
 		  GEN6_VFCOMPONENT_STORE_1_FLT << VE1_VFCOMPONENT_3_SHIFT);
 }
 
-/**
+/*
  * gen7_emit_vertex_buffer emit the vertex buffers command
  *
  * @batch
Signature · 1 line
1.9.3
#2 lore raw

PATCH 3/7 README: update the section on modifying and rebuilding documentation

In reply to Thomas Wood
---
 README | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
README +5 -7
index cfa186d..5e98565 100644
@@ -108,16 +108,14 @@ docs/
 	reference documenation in docs/reference/ You need to have the gtk doc
 	tools installed to generate this API documentation.
 
-	Note that the currrent gtk-docs integration sucks a bit wrt regenerating
-	the html files. You need at least
+	To regenerate the html files when updating documentation, use:
 
 	$ make clean -C docs && make -C docs
 
-	to regenerate them on any change. If you've added/changed/removed a
-	symbol or anything else that changes the overall structure or indexes,
-	you need a full rebuild:
-
-	$ git clean -dfx && ./autogen.sh --enable-gtk-doc && make -C docs
+	If you've added/changed/removed a symbol or anything else that changes
+	the overall structure or indexes, this needs to be reflected in
+	intel-gpu-tools-sections.txt. Entirely new sections will also need to be
+	added to intel-gpu-tools-docs.xml in the appropriate place.
 
 DEPENDENCIES
 	This is a non-exchaustive list of package dependencies required for
Signature · 1 line
1.9.3
#3 lore raw

Re: [i-g-t 3/7] README: update the section on modifying and rebuilding documentation

Quoted 14 lines · Thomas Wood
---
 README | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
README +0 -1
index cfa186d..5e98565 100644
@@ -108,16 +108,14 @@ docs/
 	reference documenation in docs/reference/ You need to have the gtk doc
 	tools installed to generate this API documentation.
 
-	Note that the currrent gtk-docs integration sucks a bit wrt regenerating

README docs/ · line 120

Quoted 10 lines
README +1 -6
-	the html files. You need at least
+	To regenerate the html files when updating documentation, use:
 
 	$ make clean -C docs && make -C docs
 
-	to regenerate them on any change. If you've added/changed/removed a
-	symbol or anything else that changes the overall structure or indexes,
-	you need a full rebuild:
-
-	$ git clean -dfx && ./autogen.sh --enable-gtk-doc && make -C docs

This is still requried afaik when you add new .c/.h files with api docs in them.
-Daniel

Quoted 14 lines
README +4 -0
+	If you've added/changed/removed a symbol or anything else that changes
+	the overall structure or indexes, this needs to be reflected in
+	intel-gpu-tools-sections.txt. Entirely new sections will also need to be
+	added to intel-gpu-tools-docs.xml in the appropriate place.
 
 DEPENDENCIES
 	This is a non-exchaustive list of package dependencies required for
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#4 lore raw

Re: [i-g-t 3/7] README: update the section on modifying and rebuilding documentation

Quoted 20 lines · Daniel Vetter
Quoted 19 lines · Thomas Wood
---
 README | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
README +1 -2
index cfa186d..5e98565 100644
@@ -108,16 +108,14 @@ docs/
      reference documenation in docs/reference/ You need to have the gtk doc
      tools installed to generate this API documentation.
 
-     Note that the currrent gtk-docs integration sucks a bit wrt regenerating
-     the html files. You need at least
+     To regenerate the html files when updating documentation, use:
 
      $ make clean -C docs && make -C docs
 
Quoted 9 lines

README docs/ · line 120

Quoted 5 lines
README +0 -5
-     to regenerate them on any change. If you've added/changed/removed a
-     symbol or anything else that changes the overall structure or indexes,
-     you need a full rebuild:
-
-     $ git clean -dfx && ./autogen.sh --enable-gtk-doc && make -C docs

This is still requried afaik when you add new .c/.h files with api docs in them.
-Daniel

Running make clean && make is enough for symbols to be added or removed, even in new source files. The sections file will still need to be updated to reflect the changes (e.g. new sections added when new files are added).

Quoted 20 lines
Quoted 11 lines
README +4 -1
+     If you've added/changed/removed a symbol or anything else that changes
+     the overall structure or indexes, this needs to be reflected in
+     intel-gpu-tools-sections.txt. Entirely new sections will also need to be
+     added to intel-gpu-tools-docs.xml in the appropriate place.
 
 DEPENDENCIES
      This is a non-exchaustive list of package dependencies required for
--

1.9.3

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

#5 lore raw

PATCH 4/7 docs: add the sections file

In reply to Thomas Wood

This file can contain custom changes to the control the documentation output and therefore should be included in the repository.

---
 docs/reference/intel-gpu-tools/.gitignore          |   1 -
 .../intel-gpu-tools/intel-gpu-tools-sections.txt   | 378 +++++++++++++++++++++
 2 files changed, 378 insertions(+), 1 deletion(-)
 create mode 100644 docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt
docs/reference/intel-gpu-tools/.gitignore +0 -1
index 9415974..9fadbfc 100644
@@ -6,7 +6,6 @@
 /intel-gpu-tools-decl-list.txt
 /intel-gpu-tools-decl.txt
 /intel-gpu-tools-overrides.txt
-/intel-gpu-tools-sections.txt
 /intel-gpu-tools-undeclared.txt
 /intel-gpu-tools-undocumented.txt
 /intel-gpu-tools-unused.txt
docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt new file +378 -0

378 lines not on this page · raw message

Signature · 1 line
1.9.3
#6 lore raw

Re: [i-g-t 4/7] docs: add the sections file

Quoted 4 lines · Thomas Wood

This file can contain custom changes to the control the documentation output and therefore should be included in the repository.

Doesn't that mean we need to update this when adding new symbols? Imo forcing autogeneration is better since you can control the order also by moving functions around in the .h files. Or what exactly is this for? -Daniel

Quoted 409 lines
---
 docs/reference/intel-gpu-tools/.gitignore          |   1 -
 .../intel-gpu-tools/intel-gpu-tools-sections.txt   | 378 +++++++++++++++++++++
 2 files changed, 378 insertions(+), 1 deletion(-)
 create mode 100644 docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt
docs/reference/intel-gpu-tools/.gitignore +0 -1
index 9415974..9fadbfc 100644
@@ -6,7 +6,6 @@
 /intel-gpu-tools-decl-list.txt
 /intel-gpu-tools-decl.txt
 /intel-gpu-tools-overrides.txt
-/intel-gpu-tools-sections.txt
 /intel-gpu-tools-undeclared.txt
 /intel-gpu-tools-undocumented.txt
 /intel-gpu-tools-unused.txt
docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt new file +378 -0
new file mode 100644
index 0000000..de6c76c
@@ -0,0 +1,378 @@
+<SECTION>
+<FILE>debug</FILE>
+DEBUG_PROTOCOL_VERSION
+COMMUNICATION_OFFSET
+COMMUNICATION_QWORD
+STATE_EU_MSG
+STATE_CPU_ACK
+STATE_OFFSET
+STATE_QWORD
+TX_OFFSET
+TX_QWORD
+RX_OFFSET
+RX_QWORD
+grf
+mrf
+cr
+sr
+DWORD8
+</SECTION>
+
+<SECTION>
+<FILE>drmtest</FILE>
+mmap64
+ARRAY_SIZE
+ALIGN
+drm_get_card
+drm_open_any
+drm_open_any_render
+gem_quiescent_gpu
+do_or_die
+do_ioctl
+</SECTION>
+
+<SECTION>
+<FILE>igt_aux</FILE>
+igt_fork_signal_helper
+igt_stop_signal_helper
+igt_exchange_int
+igt_permute_array
+igt_progress
+igt_check_boolean_env_var
+igt_aub_dump_enabled
+igt_init_aperture_trashers
+igt_trash_aperture
+igt_cleanup_aperture_trashers
+igt_system_suspend_autoresume
+igt_drop_root
+igt_wait_for_keypress
+igt_runtime_pm_status
+igt_setup_runtime_pm
+igt_get_runtime_pm_status
+igt_wait_for_pm_status
+intel_purge_vm_caches
+intel_get_avail_ram_mb
+intel_get_total_ram_mb
+intel_get_total_swap_mb
+intel_check_memory
+CHECK_RAM
+CHECK_SWAP
+</SECTION>
+
+<SECTION>
+<FILE>igt_core</FILE>
+IGT_EXIT_TIMEOUT
+IGT_EXIT_SKIP
+IGT_EXIT_SUCCESS
+igt_fixture
+igt_subtest_init
+igt_opt_handler_t
+igt_subtest_init_parse_opts
+igt_tokencat
+igt_subtest
+igt_subtest_f
+igt_subtest_name
+igt_only_list_subtests
+igt_main
+igt_simple_init
+igt_simple_main
+igt_skip
+igt_success
+igt_fail
+igt_exit
+igt_assert
+igt_assert_f
+igt_assert_cmpint
+igt_require
+igt_skip_on
+igt_require_f
+igt_skip_on_f
+igt_fork
+igt_waitchildren
+igt_helper_process
+igt_fork_helper
+igt_wait_helper
+igt_stop_helper
+igt_exit_handler_t
+igt_install_exit_handler
+igt_enable_exit_handler
+igt_disable_exit_handler
+igt_run_in_simulation
+SLOW_QUICK
+igt_skip_on_simulation
+igt_log_level
+igt_log
+igt_vlog
+igt_debug
+igt_info
+igt_warn
+igt_warn_on
+igt_warn_on_f
+igt_set_timeout
+</SECTION>
+
+<SECTION>
+<FILE>igt_debugfs</FILE>
+igt_debugfs_open
+igt_debugfs_fopen
+igt_pipe_crc_t
+igt_crc_t
+intel_pipe_crc_source
+igt_crc_is_null
+igt_crc_equal
+igt_crc_to_string
+igt_require_pipe_crc
+igt_pipe_crc_new
+igt_pipe_crc_free
+igt_pipe_crc_start
+igt_pipe_crc_stop
+igt_pipe_crc_get_crcs
+igt_pipe_crc_collect_crc
+DROP_UNBOUND
+DROP_BOUND
+DROP_RETIRE
+DROP_ACTIVE
+DROP_ALL
+igt_drop_caches_set
+igt_disable_prefault
+igt_enable_prefault
+igt_open_forcewake_handle
+stop_ring_flags
+igt_to_stop_ring_flag
+igt_set_stop_rings
+igt_get_stop_rings
+</SECTION>
+
+<SECTION>
+<FILE>igt_fb</FILE>
+cairo_surface_t
+cairo_t
+igt_fb
+igt_text_align
+igt_create_fb_with_bo_size
+igt_create_fb
+igt_create_color_fb
+igt_remove_fb
+igt_get_cairo_ctx
+igt_paint_color
+igt_paint_color_alpha
+igt_paint_color_gradient
+igt_paint_test_pattern
+igt_paint_image
+igt_write_fb_to_png
+igt_cairo_printf_line
+igt_bpp_depth_to_drm_format
+igt_drm_format_to_bpp
+igt_format_str
+igt_get_all_formats
+</SECTION>
+
+<SECTION>
+<FILE>igt_kms</FILE>
+pipe
+pipe_name
+igt_plane
+plane_name
+sprite_name
+port
+port_name
+kmstest_connector_config
+kmstest_get_connector_default_mode
+kmstest_get_connector_config
+kmstest_free_connector_config
+kmstest_dump_mode
+kmstest_get_pipe_from_crtc_id
+kmstest_pipe_str
+kmstest_encoder_type_str
+kmstest_connector_status_str
+kmstest_connector_type_str
+kmstest_set_connector_dpms
+igt_display_t
+igt_pipe_t
+igt_fixed_t
+igt_plane_t
+igt_pipe
+igt_output_t
+igt_display
+igt_set_vt_graphics_mode
+igt_display_init
+igt_display_fini
+igt_display_commit
+igt_display_get_n_pipes
+igt_output_name
+igt_output_get_mode
+igt_output_set_pipe
+igt_output_get_plane
+igt_plane_set_fb
+igt_plane_set_position
+igt_wait_for_vblank
+for_each_connected_output
+PIPE_ANY
+IGT_FIXED
+</SECTION>
+
+<SECTION>
+<FILE>instdone</FILE>
+MAX_INSTDONE_BITS
+instdone_bit
+num_instdone_bits
+init_instdone_definitions
+</SECTION>
+
+<SECTION>
+<FILE>intel_batchbuffer</FILE>
+BATCH_SZ
+BATCH_RESERVED
+intel_batchbuffer
+intel_batchbuffer_alloc
+intel_batchbuffer_free
+intel_batchbuffer_flush
+intel_batchbuffer_flush_on_ring
+intel_batchbuffer_flush_with_context
+intel_batchbuffer_reset
+intel_batchbuffer_data
+intel_batchbuffer_emit_reloc
+intel_batchbuffer_space
+intel_batchbuffer_emit_dword
+intel_batchbuffer_require_space
+BEGIN_BATCH
+OUT_BATCH
+OUT_RELOC_FENCED
+OUT_RELOC
+ADVANCE_BATCH
+BLIT_COPY_BATCH_START
+COLOR_BLIT_COPY_BATCH_START
+BLIT_RELOC_UDW
+intel_blt_copy
+intel_copy_bo
+igt_buf
+igt_buf_width
+igt_buf_height
+igt_render_copyfunc_t
+igt_get_render_copyfunc
+igt_media_fillfunc_t
+igt_get_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>intel_chipset</FILE>
+intel_get_pci_device
+intel_get_drm_devid
+intel_gen
+pch_type
+intel_check_pch
+HAS_IBX
+HAS_CPT
+HAS_LPT
+IS_MOBILE
+IS_G45
+IS_GM45
+IS_G4X
+IS_ILD
+IS_ILM
+IS_915
+IS_945GM
+IS_945
+IS_G33
+IS_GEN2
+IS_GEN3
+IS_GEN4
+IS_GEN5
+IS_GEN6
+IS_GEN7
+IS_IVYBRIDGE
+IS_VALLEYVIEW
+IS_HSW_GT1
+IS_HSW_GT2
+IS_HSW_GT3
+IS_HASWELL
+IS_BROADWELL
+IS_CHERRYVIEW
+IS_GEN8
+IS_965
+IS_9XX
+IS_INTEL
+HAS_PCH_SPLIT
+HAS_BLT_RING
+HAS_BSD_RING
+IS_BROADWATER
+IS_CRESTLINE
+HAS_VEBOX_RING
+</SECTION>
+
+<SECTION>
+<FILE>intel_io</FILE>
+mmio
+intel_mmio_use_pci_bar
+intel_mmio_use_dump_file
+intel_register_access_init
+intel_register_access_fini
+intel_register_read
+intel_register_write
+intel_register_access_needs_fakewake
+INREG
+OUTREG
+intel_dpio_reg_read
+intel_dpio_reg_write
+intel_flisdsi_reg_read
+intel_flisdsi_reg_write
+intel_punit_read
+intel_punit_write
+intel_nc_read
+intel_nc_write
+</SECTION>
+
+<SECTION>
+<FILE>ioctl_wrappers</FILE>
+gem_handle_to_libdrm_bo
+gem_set_tiling
+gem_set_caching
+gem_get_caching
+gem_flink
+gem_open
+gem_close
+gem_write
+gem_read
+gem_set_domain
+gem_sync
+gem_create
+gem_execbuf
+gem_mmap__gtt
+gem_mmap__cpu
+gem_mmap
+gem_madvise
+gem_context_create
+gem_sw_finish
+gem_bo_busy
+gem_get_num_rings
+gem_has_enable_ring
+gem_has_bsd
+gem_has_blt
+gem_has_vebox
+gem_uses_aliasing_ppgtt
+gem_available_fences
+gem_available_aperture_size
+gem_aperture_size
+gem_mappable_aperture_size
+gem_require_caching
+gem_require_ring
+prime_handle_to_fd
+prime_fd_to_handle
+prime_get_size
+</SECTION>
+
+<SECTION>
+<FILE>media_fill</FILE>
+gen8_media_fillfunc
+gen7_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>rendercopy</FILE>
+gen8_render_copyfunc
+gen7_render_copyfunc
+gen6_render_copyfunc
+gen3_render_copyfunc
+gen2_render_copyfunc
+</SECTION>
+
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#7 lore raw

Re: [i-g-t 4/7] docs: add the sections file

Quoted 10 lines · Daniel Vetter
Quoted 4 lines · Thomas Wood

This file can contain custom changes to the control the documentation output and therefore should be included in the repository.

Doesn't that mean we need to update this when adding new symbols? Imo forcing autogeneration is better since you can control the order also by moving functions around in the .h files. Or what exactly is this for? -Daniel

There are further annotations that can be made in this file, which is why gtk-doc does not automatically overwrite it when symbols and sections are added or removed:

https://developer.gnome.org/gtk-doc-manual/stable/metafiles_sections.html.en

Quoted 426 lines
Quoted 406 lines
---
 docs/reference/intel-gpu-tools/.gitignore          |   1 -
 .../intel-gpu-tools/intel-gpu-tools-sections.txt   | 378 +++++++++++++++++++++
 2 files changed, 378 insertions(+), 1 deletion(-)
 create mode 100644 docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt
docs/reference/intel-gpu-tools/.gitignore +0 -1
index 9415974..9fadbfc 100644
@@ -6,7 +6,6 @@
 /intel-gpu-tools-decl-list.txt
 /intel-gpu-tools-decl.txt
 /intel-gpu-tools-overrides.txt
-/intel-gpu-tools-sections.txt
 /intel-gpu-tools-undeclared.txt
 /intel-gpu-tools-undocumented.txt
 /intel-gpu-tools-unused.txt
docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt new file +378 -1
new file mode 100644
index 0000000..de6c76c
@@ -0,0 +1,378 @@
+<SECTION>
+<FILE>debug</FILE>
+DEBUG_PROTOCOL_VERSION
+COMMUNICATION_OFFSET
+COMMUNICATION_QWORD
+STATE_EU_MSG
+STATE_CPU_ACK
+STATE_OFFSET
+STATE_QWORD
+TX_OFFSET
+TX_QWORD
+RX_OFFSET
+RX_QWORD
+grf
+mrf
+cr
+sr
+DWORD8
+</SECTION>
+
+<SECTION>
+<FILE>drmtest</FILE>
+mmap64
+ARRAY_SIZE
+ALIGN
+drm_get_card
+drm_open_any
+drm_open_any_render
+gem_quiescent_gpu
+do_or_die
+do_ioctl
+</SECTION>
+
+<SECTION>
+<FILE>igt_aux</FILE>
+igt_fork_signal_helper
+igt_stop_signal_helper
+igt_exchange_int
+igt_permute_array
+igt_progress
+igt_check_boolean_env_var
+igt_aub_dump_enabled
+igt_init_aperture_trashers
+igt_trash_aperture
+igt_cleanup_aperture_trashers
+igt_system_suspend_autoresume
+igt_drop_root
+igt_wait_for_keypress
+igt_runtime_pm_status
+igt_setup_runtime_pm
+igt_get_runtime_pm_status
+igt_wait_for_pm_status
+intel_purge_vm_caches
+intel_get_avail_ram_mb
+intel_get_total_ram_mb
+intel_get_total_swap_mb
+intel_check_memory
+CHECK_RAM
+CHECK_SWAP
+</SECTION>
+
+<SECTION>
+<FILE>igt_core</FILE>
+IGT_EXIT_TIMEOUT
+IGT_EXIT_SKIP
+IGT_EXIT_SUCCESS
+igt_fixture
+igt_subtest_init
+igt_opt_handler_t
+igt_subtest_init_parse_opts
+igt_tokencat
+igt_subtest
+igt_subtest_f
+igt_subtest_name
+igt_only_list_subtests
+igt_main
+igt_simple_init
+igt_simple_main
+igt_skip
+igt_success
+igt_fail
+igt_exit
+igt_assert
+igt_assert_f
+igt_assert_cmpint
+igt_require
+igt_skip_on
+igt_require_f
+igt_skip_on_f
+igt_fork
+igt_waitchildren
+igt_helper_process
+igt_fork_helper
+igt_wait_helper
+igt_stop_helper
+igt_exit_handler_t
+igt_install_exit_handler
+igt_enable_exit_handler
+igt_disable_exit_handler
+igt_run_in_simulation
+SLOW_QUICK
+igt_skip_on_simulation
+igt_log_level
+igt_log
+igt_vlog
+igt_debug
+igt_info
+igt_warn
+igt_warn_on
+igt_warn_on_f
+igt_set_timeout
+</SECTION>
+
+<SECTION>
+<FILE>igt_debugfs</FILE>
+igt_debugfs_open
+igt_debugfs_fopen
+igt_pipe_crc_t
+igt_crc_t
+intel_pipe_crc_source
+igt_crc_is_null
+igt_crc_equal
+igt_crc_to_string
+igt_require_pipe_crc
+igt_pipe_crc_new
+igt_pipe_crc_free
+igt_pipe_crc_start
+igt_pipe_crc_stop
+igt_pipe_crc_get_crcs
+igt_pipe_crc_collect_crc
+DROP_UNBOUND
+DROP_BOUND
+DROP_RETIRE
+DROP_ACTIVE
+DROP_ALL
+igt_drop_caches_set
+igt_disable_prefault
+igt_enable_prefault
+igt_open_forcewake_handle
+stop_ring_flags
+igt_to_stop_ring_flag
+igt_set_stop_rings
+igt_get_stop_rings
+</SECTION>
+
+<SECTION>
+<FILE>igt_fb</FILE>
+cairo_surface_t
+cairo_t
+igt_fb
+igt_text_align
+igt_create_fb_with_bo_size
+igt_create_fb
+igt_create_color_fb
+igt_remove_fb
+igt_get_cairo_ctx
+igt_paint_color
+igt_paint_color_alpha
+igt_paint_color_gradient
+igt_paint_test_pattern
+igt_paint_image
+igt_write_fb_to_png
+igt_cairo_printf_line
+igt_bpp_depth_to_drm_format
+igt_drm_format_to_bpp
+igt_format_str
+igt_get_all_formats
+</SECTION>
+
+<SECTION>
+<FILE>igt_kms</FILE>
+pipe
+pipe_name
+igt_plane
+plane_name
+sprite_name
+port
+port_name
+kmstest_connector_config
+kmstest_get_connector_default_mode
+kmstest_get_connector_config
+kmstest_free_connector_config
+kmstest_dump_mode
+kmstest_get_pipe_from_crtc_id
+kmstest_pipe_str
+kmstest_encoder_type_str
+kmstest_connector_status_str
+kmstest_connector_type_str
+kmstest_set_connector_dpms
+igt_display_t
+igt_pipe_t
+igt_fixed_t
+igt_plane_t
+igt_pipe
+igt_output_t
+igt_display
+igt_set_vt_graphics_mode
+igt_display_init
+igt_display_fini
+igt_display_commit
+igt_display_get_n_pipes
+igt_output_name
+igt_output_get_mode
+igt_output_set_pipe
+igt_output_get_plane
+igt_plane_set_fb
+igt_plane_set_position
+igt_wait_for_vblank
+for_each_connected_output
+PIPE_ANY
+IGT_FIXED
+</SECTION>
+
+<SECTION>
+<FILE>instdone</FILE>
+MAX_INSTDONE_BITS
+instdone_bit
+num_instdone_bits
+init_instdone_definitions
+</SECTION>
+
+<SECTION>
+<FILE>intel_batchbuffer</FILE>
+BATCH_SZ
+BATCH_RESERVED
+intel_batchbuffer
+intel_batchbuffer_alloc
+intel_batchbuffer_free
+intel_batchbuffer_flush
+intel_batchbuffer_flush_on_ring
+intel_batchbuffer_flush_with_context
+intel_batchbuffer_reset
+intel_batchbuffer_data
+intel_batchbuffer_emit_reloc
+intel_batchbuffer_space
+intel_batchbuffer_emit_dword
+intel_batchbuffer_require_space
+BEGIN_BATCH
+OUT_BATCH
+OUT_RELOC_FENCED
+OUT_RELOC
+ADVANCE_BATCH
+BLIT_COPY_BATCH_START
+COLOR_BLIT_COPY_BATCH_START
+BLIT_RELOC_UDW
+intel_blt_copy
+intel_copy_bo
+igt_buf
+igt_buf_width
+igt_buf_height
+igt_render_copyfunc_t
+igt_get_render_copyfunc
+igt_media_fillfunc_t
+igt_get_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>intel_chipset</FILE>
+intel_get_pci_device
+intel_get_drm_devid
+intel_gen
+pch_type
+intel_check_pch
+HAS_IBX
+HAS_CPT
+HAS_LPT
+IS_MOBILE
+IS_G45
+IS_GM45
+IS_G4X
+IS_ILD
+IS_ILM
+IS_915
+IS_945GM
+IS_945
+IS_G33
+IS_GEN2
+IS_GEN3
+IS_GEN4
+IS_GEN5
+IS_GEN6
+IS_GEN7
+IS_IVYBRIDGE
+IS_VALLEYVIEW
+IS_HSW_GT1
+IS_HSW_GT2
+IS_HSW_GT3
+IS_HASWELL
+IS_BROADWELL
+IS_CHERRYVIEW
+IS_GEN8
+IS_965
+IS_9XX
+IS_INTEL
+HAS_PCH_SPLIT
+HAS_BLT_RING
+HAS_BSD_RING
+IS_BROADWATER
+IS_CRESTLINE
+HAS_VEBOX_RING
+</SECTION>
+
+<SECTION>
+<FILE>intel_io</FILE>
+mmio
+intel_mmio_use_pci_bar
+intel_mmio_use_dump_file
+intel_register_access_init
+intel_register_access_fini
+intel_register_read
+intel_register_write
+intel_register_access_needs_fakewake
+INREG
+OUTREG
+intel_dpio_reg_read
+intel_dpio_reg_write
+intel_flisdsi_reg_read
+intel_flisdsi_reg_write
+intel_punit_read
+intel_punit_write
+intel_nc_read
+intel_nc_write
+</SECTION>
+
+<SECTION>
+<FILE>ioctl_wrappers</FILE>
+gem_handle_to_libdrm_bo
+gem_set_tiling
+gem_set_caching
+gem_get_caching
+gem_flink
+gem_open
+gem_close
+gem_write
+gem_read
+gem_set_domain
+gem_sync
+gem_create
+gem_execbuf
+gem_mmap__gtt
+gem_mmap__cpu
+gem_mmap
+gem_madvise
+gem_context_create
+gem_sw_finish
+gem_bo_busy
+gem_get_num_rings
+gem_has_enable_ring
+gem_has_bsd
+gem_has_blt
+gem_has_vebox
+gem_uses_aliasing_ppgtt
+gem_available_fences
+gem_available_aperture_size
+gem_aperture_size
+gem_mappable_aperture_size
+gem_require_caching
+gem_require_ring
+prime_handle_to_fd
+prime_fd_to_handle
+prime_get_size
+</SECTION>
+
+<SECTION>
+<FILE>media_fill</FILE>
+gen8_media_fillfunc
+gen7_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>rendercopy</FILE>
+gen8_render_copyfunc
+gen7_render_copyfunc
+gen6_render_copyfunc
+gen3_render_copyfunc
+gen2_render_copyfunc
+</SECTION>
+
--

1.9.3

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#8 lore raw

Re: [i-g-t 4/7] docs: add the sections file

Quoted 12 lines · Thomas Wood
Quoted 10 lines · Daniel Vetter
Quoted 4 lines · Thomas Wood

This file can contain custom changes to the control the documentation output and therefore should be included in the repository.

Doesn't that mean we need to update this when adding new symbols? Imo forcing autogeneration is better since you can control the order also by moving functions around in the .h files. Or what exactly is this for? -Daniel

Quoted 5 lines

There are further annotations that can be made in this file, which is why gtk-doc does not automatically overwrite it when symbols and sections are added or removed:

https://developer.gnome.org/gtk-doc-manual/stable/metafiles_sections.html.en

Hm, I actually like the autogenerated one. Forcing people to do this by hand pretty much means that it will get lost in most cases - doing the api docs themselves is still often not done.

So for now I'd actually prefer if we hack the Makefiles to unconditionally regen this, if possible. At least until we have a real use-case for this. -Daniel

Quoted 428 lines
Quoted 428 lines
Quoted 408 lines


---
 docs/reference/intel-gpu-tools/.gitignore          |   1 -
 .../intel-gpu-tools/intel-gpu-tools-sections.txt   | 378 +++++++++++++++++++++
 2 files changed, 378 insertions(+), 1 deletion(-)
 create mode 100644 docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt
docs/reference/intel-gpu-tools/.gitignore +0 -1
index 9415974..9fadbfc 100644
@@ -6,7 +6,6 @@
 /intel-gpu-tools-decl-list.txt
 /intel-gpu-tools-decl.txt
 /intel-gpu-tools-overrides.txt
-/intel-gpu-tools-sections.txt
 /intel-gpu-tools-undeclared.txt
 /intel-gpu-tools-undocumented.txt
 /intel-gpu-tools-unused.txt
docs/reference/intel-gpu-tools/intel-gpu-tools-sections.txt new file +378 -1
new file mode 100644
index 0000000..de6c76c
@@ -0,0 +1,378 @@
+<SECTION>
+<FILE>debug</FILE>
+DEBUG_PROTOCOL_VERSION
+COMMUNICATION_OFFSET
+COMMUNICATION_QWORD
+STATE_EU_MSG
+STATE_CPU_ACK
+STATE_OFFSET
+STATE_QWORD
+TX_OFFSET
+TX_QWORD
+RX_OFFSET
+RX_QWORD
+grf
+mrf
+cr
+sr
+DWORD8
+</SECTION>
+
+<SECTION>
+<FILE>drmtest</FILE>
+mmap64
+ARRAY_SIZE
+ALIGN
+drm_get_card
+drm_open_any
+drm_open_any_render
+gem_quiescent_gpu
+do_or_die
+do_ioctl
+</SECTION>
+
+<SECTION>
+<FILE>igt_aux</FILE>
+igt_fork_signal_helper
+igt_stop_signal_helper
+igt_exchange_int
+igt_permute_array
+igt_progress
+igt_check_boolean_env_var
+igt_aub_dump_enabled
+igt_init_aperture_trashers
+igt_trash_aperture
+igt_cleanup_aperture_trashers
+igt_system_suspend_autoresume
+igt_drop_root
+igt_wait_for_keypress
+igt_runtime_pm_status
+igt_setup_runtime_pm
+igt_get_runtime_pm_status
+igt_wait_for_pm_status
+intel_purge_vm_caches
+intel_get_avail_ram_mb
+intel_get_total_ram_mb
+intel_get_total_swap_mb
+intel_check_memory
+CHECK_RAM
+CHECK_SWAP
+</SECTION>
+
+<SECTION>
+<FILE>igt_core</FILE>
+IGT_EXIT_TIMEOUT
+IGT_EXIT_SKIP
+IGT_EXIT_SUCCESS
+igt_fixture
+igt_subtest_init
+igt_opt_handler_t
+igt_subtest_init_parse_opts
+igt_tokencat
+igt_subtest
+igt_subtest_f
+igt_subtest_name
+igt_only_list_subtests
+igt_main
+igt_simple_init
+igt_simple_main
+igt_skip
+igt_success
+igt_fail
+igt_exit
+igt_assert
+igt_assert_f
+igt_assert_cmpint
+igt_require
+igt_skip_on
+igt_require_f
+igt_skip_on_f
+igt_fork
+igt_waitchildren
+igt_helper_process
+igt_fork_helper
+igt_wait_helper
+igt_stop_helper
+igt_exit_handler_t
+igt_install_exit_handler
+igt_enable_exit_handler
+igt_disable_exit_handler
+igt_run_in_simulation
+SLOW_QUICK
+igt_skip_on_simulation
+igt_log_level
+igt_log
+igt_vlog
+igt_debug
+igt_info
+igt_warn
+igt_warn_on
+igt_warn_on_f
+igt_set_timeout
+</SECTION>
+
+<SECTION>
+<FILE>igt_debugfs</FILE>
+igt_debugfs_open
+igt_debugfs_fopen
+igt_pipe_crc_t
+igt_crc_t
+intel_pipe_crc_source
+igt_crc_is_null
+igt_crc_equal
+igt_crc_to_string
+igt_require_pipe_crc
+igt_pipe_crc_new
+igt_pipe_crc_free
+igt_pipe_crc_start
+igt_pipe_crc_stop
+igt_pipe_crc_get_crcs
+igt_pipe_crc_collect_crc
+DROP_UNBOUND
+DROP_BOUND
+DROP_RETIRE
+DROP_ACTIVE
+DROP_ALL
+igt_drop_caches_set
+igt_disable_prefault
+igt_enable_prefault
+igt_open_forcewake_handle
+stop_ring_flags
+igt_to_stop_ring_flag
+igt_set_stop_rings
+igt_get_stop_rings
+</SECTION>
+
+<SECTION>
+<FILE>igt_fb</FILE>
+cairo_surface_t
+cairo_t
+igt_fb
+igt_text_align
+igt_create_fb_with_bo_size
+igt_create_fb
+igt_create_color_fb
+igt_remove_fb
+igt_get_cairo_ctx
+igt_paint_color
+igt_paint_color_alpha
+igt_paint_color_gradient
+igt_paint_test_pattern
+igt_paint_image
+igt_write_fb_to_png
+igt_cairo_printf_line
+igt_bpp_depth_to_drm_format
+igt_drm_format_to_bpp
+igt_format_str
+igt_get_all_formats
+</SECTION>
+
+<SECTION>
+<FILE>igt_kms</FILE>
+pipe
+pipe_name
+igt_plane
+plane_name
+sprite_name
+port
+port_name
+kmstest_connector_config
+kmstest_get_connector_default_mode
+kmstest_get_connector_config
+kmstest_free_connector_config
+kmstest_dump_mode
+kmstest_get_pipe_from_crtc_id
+kmstest_pipe_str
+kmstest_encoder_type_str
+kmstest_connector_status_str
+kmstest_connector_type_str
+kmstest_set_connector_dpms
+igt_display_t
+igt_pipe_t
+igt_fixed_t
+igt_plane_t
+igt_pipe
+igt_output_t
+igt_display
+igt_set_vt_graphics_mode
+igt_display_init
+igt_display_fini
+igt_display_commit
+igt_display_get_n_pipes
+igt_output_name
+igt_output_get_mode
+igt_output_set_pipe
+igt_output_get_plane
+igt_plane_set_fb
+igt_plane_set_position
+igt_wait_for_vblank
+for_each_connected_output
+PIPE_ANY
+IGT_FIXED
+</SECTION>
+
+<SECTION>
+<FILE>instdone</FILE>
+MAX_INSTDONE_BITS
+instdone_bit
+num_instdone_bits
+init_instdone_definitions
+</SECTION>
+
+<SECTION>
+<FILE>intel_batchbuffer</FILE>
+BATCH_SZ
+BATCH_RESERVED
+intel_batchbuffer
+intel_batchbuffer_alloc
+intel_batchbuffer_free
+intel_batchbuffer_flush
+intel_batchbuffer_flush_on_ring
+intel_batchbuffer_flush_with_context
+intel_batchbuffer_reset
+intel_batchbuffer_data
+intel_batchbuffer_emit_reloc
+intel_batchbuffer_space
+intel_batchbuffer_emit_dword
+intel_batchbuffer_require_space
+BEGIN_BATCH
+OUT_BATCH
+OUT_RELOC_FENCED
+OUT_RELOC
+ADVANCE_BATCH
+BLIT_COPY_BATCH_START
+COLOR_BLIT_COPY_BATCH_START
+BLIT_RELOC_UDW
+intel_blt_copy
+intel_copy_bo
+igt_buf
+igt_buf_width
+igt_buf_height
+igt_render_copyfunc_t
+igt_get_render_copyfunc
+igt_media_fillfunc_t
+igt_get_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>intel_chipset</FILE>
+intel_get_pci_device
+intel_get_drm_devid
+intel_gen
+pch_type
+intel_check_pch
+HAS_IBX
+HAS_CPT
+HAS_LPT
+IS_MOBILE
+IS_G45
+IS_GM45
+IS_G4X
+IS_ILD
+IS_ILM
+IS_915
+IS_945GM
+IS_945
+IS_G33
+IS_GEN2
+IS_GEN3
+IS_GEN4
+IS_GEN5
+IS_GEN6
+IS_GEN7
+IS_IVYBRIDGE
+IS_VALLEYVIEW
+IS_HSW_GT1
+IS_HSW_GT2
+IS_HSW_GT3
+IS_HASWELL
+IS_BROADWELL
+IS_CHERRYVIEW
+IS_GEN8
+IS_965
+IS_9XX
+IS_INTEL
+HAS_PCH_SPLIT
+HAS_BLT_RING
+HAS_BSD_RING
+IS_BROADWATER
+IS_CRESTLINE
+HAS_VEBOX_RING
+</SECTION>
+
+<SECTION>
+<FILE>intel_io</FILE>
+mmio
+intel_mmio_use_pci_bar
+intel_mmio_use_dump_file
+intel_register_access_init
+intel_register_access_fini
+intel_register_read
+intel_register_write
+intel_register_access_needs_fakewake
+INREG
+OUTREG
+intel_dpio_reg_read
+intel_dpio_reg_write
+intel_flisdsi_reg_read
+intel_flisdsi_reg_write
+intel_punit_read
+intel_punit_write
+intel_nc_read
+intel_nc_write
+</SECTION>
+
+<SECTION>
+<FILE>ioctl_wrappers</FILE>
+gem_handle_to_libdrm_bo
+gem_set_tiling
+gem_set_caching
+gem_get_caching
+gem_flink
+gem_open
+gem_close
+gem_write
+gem_read
+gem_set_domain
+gem_sync
+gem_create
+gem_execbuf
+gem_mmap__gtt
+gem_mmap__cpu
+gem_mmap
+gem_madvise
+gem_context_create
+gem_sw_finish
+gem_bo_busy
+gem_get_num_rings
+gem_has_enable_ring
+gem_has_bsd
+gem_has_blt
+gem_has_vebox
+gem_uses_aliasing_ppgtt
+gem_available_fences
+gem_available_aperture_size
+gem_aperture_size
+gem_mappable_aperture_size
+gem_require_caching
+gem_require_ring
+prime_handle_to_fd
+prime_fd_to_handle
+prime_get_size
+</SECTION>
+
+<SECTION>
+<FILE>media_fill</FILE>
+gen8_media_fillfunc
+gen7_media_fillfunc
+</SECTION>
+
+<SECTION>
+<FILE>rendercopy</FILE>
+gen8_render_copyfunc
+gen7_render_copyfunc
+gen6_render_copyfunc
+gen3_render_copyfunc
+gen2_render_copyfunc
+</SECTION>
+
--

1.9.3

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#9 lore raw

PATCH 1/1 docs: always rebuild the sections file

Always rebuild the sections file since it currently doesn't contain any custom modifications.

---
 docs/reference/intel-gpu-tools/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
docs/reference/intel-gpu-tools/Makefile.am +2 -2
index 549f34b..3368e3e 100644
@@ -29,7 +29,7 @@ SCANGOBJ_OPTIONS=
 
 # Extra options to supply to gtkdoc-scan.
 # e.g. SCAN_OPTIONS=--deprecated-guards="GTK_DISABLE_DEPRECATED"
-SCAN_OPTIONS=
+SCAN_OPTIONS=--rebuild-sections
 
 # Extra options to supply to gtkdoc-mkdb.
 # e.g. MKDB_OPTIONS=--xml-mode --output-format=xml
@@ -93,7 +93,7 @@ EXTRA_DIST +=
 # Files not to distribute
 # for --rebuild-types in $(SCAN_OPTIONS), e.g. $(DOC_MODULE).types
 # for --rebuild-sections in $(SCAN_OPTIONS) e.g. $(DOC_MODULE)-sections.txt
-#DISTCLEANFILES +=
+DISTCLEANFILES = $(DOC_MODULE)-sections.txt
 
 # Comment this out if you want 'make check' to test you doc status
 # and run some sanity checks
Signature · 1 line
1.9.3
#10 lore raw

PATCH 5/7 gitignore: add missing files and keep lists sorted

In reply to Thomas Wood
---
 tests/.gitignore                | 11 +++++++----
 tools/null_state_gen/.gitignore |  1 +
 2 files changed, 8 insertions(+), 4 deletions(-)
 create mode 100644 tools/null_state_gen/.gitignore
tests/.gitignore +7 -4
index d7ad054..a61d025 100644
@@ -1,6 +1,6 @@
 # Please keep sorted alphabetically
-core_getclient
 core_get_client_auth
+core_getclient
 core_getstats
 core_getversion
 ddi_compute_wrpll
@@ -41,8 +41,8 @@ gem_exec_nop
 gem_exec_params
 gem_exec_parse
 gem_fd_exhaustion
-gem_fenced_exec_thrash
 gem_fence_thrash
+gem_fenced_exec_thrash
 gem_flink
 gem_flink_race
 gem_gtt_cpu_tlb
@@ -77,9 +77,9 @@ gem_render_copy_redux
 gem_render_linear_blits
 gem_render_tiled_blits
 gem_reset_stats
-gem_ringfill
 gem_ring_sync_copy
 gem_ring_sync_loop
+gem_ringfill
 gem_seqno_wrap
 gem_set_tiling_vs_blt
 gem_set_tiling_vs_gtt
@@ -118,17 +118,20 @@ igt_simulation
 kms_addfb
 kms_cursor_crc
 kms_fbc_crc
+kms_fence_pin_leak
 kms_flip
 kms_flip_tiling
+kms_mmio_vs_cs_flip
 kms_pipe_crc_basic
 kms_plane
 kms_render
 kms_setmode
+kms_sink_crc_basic
 multi-tests.txt
 pm_lpsp
-pm_rpm
 pm_psr
 pm_rc6_residency
+pm_rpm
 pm_rps
 prime_nv_api
 prime_nv_pcopy
tools/null_state_gen/.gitignore new file +1 -0
new file mode 100644
index 0000000..170bcef
@@ -0,0 +1 @@
+intel_null_state_gen
Signature · 1 line
1.9.3
#11 lore raw

PATCH 6/7 lib: various documentation fixes

In reply to Thomas Wood

Fix some documentation comments and mark some struct members private.

---
 lib/igt_aux.c           |  5 ++---
 lib/igt_core.c          | 10 +++++-----
 lib/igt_kms.h           |  2 ++
 lib/intel_batchbuffer.h |  5 +----
 4 files changed, 10 insertions(+), 12 deletions(-)
lib/igt_aux.c +2 -3
index c0088d5..7b277be 100644
@@ -430,10 +430,9 @@ bool igt_setup_runtime_pm(void)
 }
 
 /**
- * igt_runtime_pm_status:
+ * igt_get_runtime_pm_status:
  *
- * Returns:
- * The current runtime PM status.
+ * Returns: The current runtime PM status.
  */
 enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
 {
lib/igt_core.c +5 -5
index 56eacf2..7ac7ebe 100644
@@ -1031,11 +1031,11 @@ static void fatal_sig_handler(int sig)
  * @fn: exit handler function
  *
  * Set a handler that will be called either when the process calls exit() or
- * returns from the main function, or one of the signals in 'handled_signals'
- * is raised. MAX_EXIT_HANDLERS handlers can be installed, each of which will
- * be called only once, even if a subsequent signal is raised. If the exit
- * handlers are called due to a signal, the signal will be re-raised with the
- * original signal disposition after all handlers returned.
+ * <!-- -->returns from the main function, or one of the signals in
+ * 'handled_signals' is raised. MAX_EXIT_HANDLERS handlers can be installed,
+ * each of which will be called only once, even if a subsequent signal is
+ * raised. If the exit handlers are called due to a signal, the signal will be
+ * re-raised with the original signal disposition after all handlers returned.
  *
  * The handler will be passed the signal number if called due to a signal, or
  * 0 otherwise. Exit handlers can also be used from test children spawned with
lib/igt_kms.h +2 -0
index 8e80d4b..17bf0a2 100644
@@ -99,6 +99,7 @@ typedef struct igt_pipe igt_pipe_t;
 typedef uint32_t igt_fixed_t;			/* 16.16 fixed point */
 
 typedef struct {
+	/*< private >*/
 	igt_pipe_t *pipe;
 	int index;
 	unsigned int is_primary       : 1;
@@ -127,6 +128,7 @@ struct igt_pipe {
 };
 
 typedef struct {
+	/*< private >*/
 	igt_display_t *display;
 	uint32_t id;					/* KMS id */
 	struct kmstest_connector_config config;
lib/intel_batchbuffer.h +1 -4
index 49dbcf0..3715161 100644
@@ -204,14 +204,10 @@ void intel_copy_bo(struct intel_batchbuffer *batch,
  * @tiling: tiling mode bits
  * @data: pointer to the memory mapping of the buffer
  * @size: size of the buffer object
- * @num_tiles: number of tiles of the buffer object
  *
  * This is a i-g-t buffer object wrapper structure which augments the baseline
  * libdrm buffer object with suitable data needed by the render copy and the
  * media fill functions.
- *
- * Note that @num_tiles is only used by gem_stress.c internally and can be
- * ignored.
  */
 struct igt_buf {
     drm_intel_bo *bo;
@@ -219,6 +215,7 @@ struct igt_buf {
     uint32_t tiling;
     uint32_t *data;
     uint32_t size;
+    /*< private >*/
     unsigned num_tiles;
 };
 
Signature · 1 line
1.9.3
#12 lore raw

Re: [i-g-t 6/7] lib: various documentation fixes

Quoted 32 lines · Thomas Wood

Fix some documentation comments and mark some struct members private.

---
 lib/igt_aux.c           |  5 ++---
 lib/igt_core.c          | 10 +++++-----
 lib/igt_kms.h           |  2 ++
 lib/intel_batchbuffer.h |  5 +----
 4 files changed, 10 insertions(+), 12 deletions(-)
lib/igt_aux.c +2 -3
index c0088d5..7b277be 100644
@@ -430,10 +430,9 @@ bool igt_setup_runtime_pm(void)
 }
 
 /**
- * igt_runtime_pm_status:
+ * igt_get_runtime_pm_status:
  *
- * Returns:
- * The current runtime PM status.
+ * Returns: The current runtime PM status.
  */
 enum igt_runtime_pm_status igt_get_runtime_pm_status(void)
 {
lib/igt_core.c +0 -0
index 56eacf2..7ac7ebe 100644

lib/igt_core.c static void fatal_sig_handler(int sig) · line 1034

Quoted 9 lines
lib/igt_core.c +1 -5
@@ -1031,11 +1031,11 @@ static void fatal_sig_handler(int sig)
  * @fn: exit handler function
  *
  * Set a handler that will be called either when the process calls exit() or
- * returns from the main function, or one of the signals in 'handled_signals'
- * is raised. MAX_EXIT_HANDLERS handlers can be installed, each of which will
- * be called only once, even if a subsequent signal is raised. If the exit
- * handlers are called due to a signal, the signal will be re-raised with the
- * original signal disposition after all handlers returned.
+ * <!-- -->returns from the main function, or one of the signals in

Ugh, this is ugly. Maybe put a "prevent gtkdoc from parsing the returns" into the html comment block?

Quoted 61 lines
lib/igt_core.c +4 -0
+ * 'handled_signals' is raised. MAX_EXIT_HANDLERS handlers can be installed,
+ * each of which will be called only once, even if a subsequent signal is
+ * raised. If the exit handlers are called due to a signal, the signal will be
+ * re-raised with the original signal disposition after all handlers returned.
  *
  * The handler will be passed the signal number if called due to a signal, or
  * 0 otherwise. Exit handlers can also be used from test children spawned with
lib/igt_kms.h +2 -0
index 8e80d4b..17bf0a2 100644
@@ -99,6 +99,7 @@ typedef struct igt_pipe igt_pipe_t;
 typedef uint32_t igt_fixed_t;			/* 16.16 fixed point */
 
 typedef struct {
+	/*< private >*/
 	igt_pipe_t *pipe;
 	int index;
 	unsigned int is_primary       : 1;
@@ -127,6 +128,7 @@ struct igt_pipe {
 };
 
 typedef struct {
+	/*< private >*/
 	igt_display_t *display;
 	uint32_t id;					/* KMS id */
 	struct kmstest_connector_config config;
lib/intel_batchbuffer.h +1 -4
index 49dbcf0..3715161 100644
@@ -204,14 +204,10 @@ void intel_copy_bo(struct intel_batchbuffer *batch,
  * @tiling: tiling mode bits
  * @data: pointer to the memory mapping of the buffer
  * @size: size of the buffer object
- * @num_tiles: number of tiles of the buffer object
  *
  * This is a i-g-t buffer object wrapper structure which augments the baseline
  * libdrm buffer object with suitable data needed by the render copy and the
  * media fill functions.
- *
- * Note that @num_tiles is only used by gem_stress.c internally and can be
- * ignored.
  */
 struct igt_buf {
     drm_intel_bo *bo;
@@ -219,6 +215,7 @@ struct igt_buf {
     uint32_t tiling;
     uint32_t *data;
     uint32_t size;
+    /*< private >*/
     unsigned num_tiles;
 };
 
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#13 lore raw

PATCH 7/7 docs: add missing sections to intel-gpu-tools-docs.xml

In reply to Thomas Wood
---
 docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 4 ++++
 1 file changed, 4 insertions(+)
docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml +4 -0
index dcfff33..96cf77f 100644
@@ -15,6 +15,7 @@
 
   <chapter>
     <title>Intel GPU Tools</title>
+    <xi:include href="xml/debug.xml"/>
     <xi:include href="xml/drmtest.xml"/>
     <xi:include href="xml/igt_core.xml"/>
     <xi:include href="xml/igt_debugfs.xml"/>
@@ -22,9 +23,12 @@
     <xi:include href="xml/igt_fb.xml"/>
     <xi:include href="xml/igt_aux.xml"/>
     <xi:include href="xml/ioctl_wrappers.xml"/>
+    <xi:include href="xml/instdone.xml"/>
     <xi:include href="xml/intel_batchbuffer.xml"/>
     <xi:include href="xml/intel_chipset.xml"/>
     <xi:include href="xml/intel_io.xml"/>
+    <xi:include href="xml/media_fill.xml"/>
+    <xi:include href="xml/rendercopy.xml"/>
 
   </chapter>
   <index id="api-index-full">
Signature · 1 line
1.9.3
#14 lore raw

Re: [i-g-t 7/7] docs: add missing sections to intel-gpu-tools-docs.xml

Quoted 1 line · Thomas Wood

I've intentionally left these out since they're not really part of the core test library ... E.g. all public rendercopy functions are documented as part of the "intel batchbuffer" library.
-Daniel

Quoted 36 lines
---
 docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 4 ++++
 1 file changed, 4 insertions(+)
docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml +4 -0
index dcfff33..96cf77f 100644
@@ -15,6 +15,7 @@
 
   <chapter>
     <title>Intel GPU Tools</title>
+    <xi:include href="xml/debug.xml"/>
     <xi:include href="xml/drmtest.xml"/>
     <xi:include href="xml/igt_core.xml"/>
     <xi:include href="xml/igt_debugfs.xml"/>
@@ -22,9 +23,12 @@
     <xi:include href="xml/igt_fb.xml"/>
     <xi:include href="xml/igt_aux.xml"/>
     <xi:include href="xml/ioctl_wrappers.xml"/>
+    <xi:include href="xml/instdone.xml"/>
     <xi:include href="xml/intel_batchbuffer.xml"/>
     <xi:include href="xml/intel_chipset.xml"/>
     <xi:include href="xml/intel_io.xml"/>
+    <xi:include href="xml/media_fill.xml"/>
+    <xi:include href="xml/rendercopy.xml"/>
 
   </chapter>
   <index id="api-index-full">
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#15 lore raw

Re: [i-g-t 7/7] docs: add missing sections to intel-gpu-tools-docs.xml

Quoted 7 lines · Daniel Vetter
Quoted 1 line · Thomas Wood

I've intentionally left these out since they're not really part of the core test library ... E.g. all public rendercopy functions are documented as part of the "intel batchbuffer" library.
-Daniel

These functions currently appear in the API index and therefore produce warnings that there is no link for them. If they are private then they can be left out of the documentation altogether and their headers added to the IGNORE_HEADERS directive instead.

Quoted 46 lines
Quoted 33 lines
---
 docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml | 4 ++++
 1 file changed, 4 insertions(+)
docs/reference/intel-gpu-tools/intel-gpu-tools-docs.xml +4 -1
index dcfff33..96cf77f 100644
@@ -15,6 +15,7 @@
 
   <chapter>
     <title>Intel GPU Tools</title>
+    <xi:include href="xml/debug.xml"/>
     <xi:include href="xml/drmtest.xml"/>
     <xi:include href="xml/igt_core.xml"/>
     <xi:include href="xml/igt_debugfs.xml"/>
@@ -22,9 +23,12 @@
     <xi:include href="xml/igt_fb.xml"/>
     <xi:include href="xml/igt_aux.xml"/>
     <xi:include href="xml/ioctl_wrappers.xml"/>
+    <xi:include href="xml/instdone.xml"/>
     <xi:include href="xml/intel_batchbuffer.xml"/>
     <xi:include href="xml/intel_chipset.xml"/>
     <xi:include href="xml/intel_io.xml"/>
+    <xi:include href="xml/media_fill.xml"/>
+    <xi:include href="xml/rendercopy.xml"/>
 
   </chapter>
   <index id="api-index-full">
--

1.9.3

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

PATCH 1/1 docs: add private headers to IGNORE_HFILES

---
 docs/reference/intel-gpu-tools/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
docs/reference/intel-gpu-tools/Makefile.am +3 -1
index daaa3f4..549f34b 100644
@@ -58,7 +58,9 @@ EXTRA_HFILES=
 
 # Header files or dirs to ignore when scanning. Use base file/dir names
 # e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h private_code
-IGNORE_HFILES=gen6_render.h gen7_media.h gen7_render.h gen8_media.h gen8_render.h i830_reg.h i915_3d.h i915_pciids.h i915_reg.h intel_reg.h
+IGNORE_HFILES=gen6_render.h gen7_media.h gen7_render.h gen8_media.h \
+	      gen8_render.h i830_reg.h i915_3d.h i915_pciids.h i915_reg.h \
+	      intel_reg.h debug.h instdone.h media_fill.h rendercopy.h
 
 # Images to copy into HTML directory.
 # e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png
Signature · 1 line
1.9.3
Reviewed-by on v1 1/1
#17 lore raw

Re: [PATCH i-g-t] docs: add private headers to IGNORE_HFILES

Quoted 1 line · Thomas Wood
Quoted 26 lines
---
 docs/reference/intel-gpu-tools/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
docs/reference/intel-gpu-tools/Makefile.am +3 -1
index daaa3f4..549f34b 100644
@@ -58,7 +58,9 @@ EXTRA_HFILES=
 
 # Header files or dirs to ignore when scanning. Use base file/dir names
 # e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h private_code
-IGNORE_HFILES=gen6_render.h gen7_media.h gen7_render.h gen8_media.h gen8_render.h i830_reg.h i915_3d.h i915_pciids.h i915_reg.h intel_reg.h
+IGNORE_HFILES=gen6_render.h gen7_media.h gen7_render.h gen8_media.h \
+	      gen8_render.h i830_reg.h i915_3d.h i915_pciids.h i915_reg.h \
+	      intel_reg.h debug.h instdone.h media_fill.h rendercopy.h
 
 # Images to copy into HTML directory.
 # e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#18 lore raw
In reply to Thomas Wood
Quoted 26 lines · Thomas Wood

Piglit now has a top level "piglit" command and the location of the tests can now be read from an environment variable.

---
 README | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
README +5 -2
index 2cfb5c5..cfa186d 100644
@@ -34,32 +34,25 @@ tests/
 
 	git://anongit.freedesktop.org/piglit
 
-	and build it (no need to install anything). Then we need to link up the
-	i-g-t sources with piglit
+	There is no need to build and install piglit if it is only going to be
+	used for running i-g-t tests.
+
+	Set the IGT_TEST_ROOT environment variable to point to the tests
+	directory or link up the i-g-t sources with piglit using a symlink:
 
 	piglit-sources $ cd bin
 	piglit-sources/bin $ ln $i-g-t-sources igt -s

README tests/ · line 51

Quoted 10 lines
README +0 -9
 
-	To avoid some hassles with piglit's use of Waffle just disable it. Run
-
-	piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
-
-	With
-
-	piglit-sources $ ccmake .
-
-	you can check your configuration with a curses interface, too.

Hm, why did you drop this? I run into "lack of waffle" every time I try to use piglit ... Otherwise looks good.
-Daniel

Quoted 26 lines
README +5 -6
-
-	The tests in the i-g-t sources need to have been built already. Then we
-	can run the testcases with (as usual as root, no other drm clients
-	running):
+	In both cases, the tests in the i-g-t sources need to have been built
+	already. Then we can run the testcases with (as usual as root, no other
+	drm clients running):
 
-	piglit-sources # ./piglit-run.py igt <results-file>
+	piglit-sources # ./piglit run igt <results-file>
 
 	The testlist is built at runtime, so no need to update anything in
 	piglit when adding new tests. See
 
-	piglit-sources $ ./piglit-run.py -h
+	piglit-sources $ ./piglit run -h
 
 	for some useful options.
 
Signature · 6 lines
1.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#19 lore raw
Quoted 28 lines · Daniel Vetter
Quoted 27 lines · Thomas Wood

Piglit now has a top level "piglit" command and the location of the tests can now be read from an environment variable.

---
 README | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
README +5 -2
index 2cfb5c5..cfa186d 100644
@@ -34,32 +34,25 @@ tests/
 
      git://anongit.freedesktop.org/piglit
 
-     and build it (no need to install anything). Then we need to link up the
-     i-g-t sources with piglit
+     There is no need to build and install piglit if it is only going to be
+     used for running i-g-t tests.
+
+     Set the IGT_TEST_ROOT environment variable to point to the tests
+     directory or link up the i-g-t sources with piglit using a symlink:
 
      piglit-sources $ cd bin
      piglit-sources/bin $ ln $i-g-t-sources igt -s
 
Quoted 12 lines

README tests/ · line 51

Quoted 9 lines
README +0 -9
-     To avoid some hassles with piglit's use of Waffle just disable it. Run
-
-     piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
-
-     With
-
-     piglit-sources $ ccmake .
-
-     you can check your configuration with a curses interface, too.

Hm, why did you drop this? I run into "lack of waffle" every time I try to use piglit ... Otherwise looks good.

Since there's no need to actually build the Piglit test cases when running intel-gpu-tools tests, there's no requirement for waffle either.

Quoted 33 lines

-Daniel

Quoted 22 lines
README +5 -7
-
-     The tests in the i-g-t sources need to have been built already. Then we
-     can run the testcases with (as usual as root, no other drm clients
-     running):
+     In both cases, the tests in the i-g-t sources need to have been built
+     already. Then we can run the testcases with (as usual as root, no other
+     drm clients running):
 
-     piglit-sources # ./piglit-run.py igt <results-file>
+     piglit-sources # ./piglit run igt <results-file>
 
      The testlist is built at runtime, so no need to update anything in
      piglit when adding new tests. See
 
-     piglit-sources $ ./piglit-run.py -h
+     piglit-sources $ ./piglit run -h
 
      for some useful options.
 
--

1.9.3

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

#20 lore raw
Quoted 42 lines · Thomas Wood
Quoted 28 lines · Daniel Vetter
Quoted 27 lines · Thomas Wood

Piglit now has a top level "piglit" command and the location of the tests can now be read from an environment variable.

---
 README | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)
README +5 -2
index 2cfb5c5..cfa186d 100644
@@ -34,32 +34,25 @@ tests/
 
      git://anongit.freedesktop.org/piglit
 
-     and build it (no need to install anything). Then we need to link up the
-     i-g-t sources with piglit
+     There is no need to build and install piglit if it is only going to be
+     used for running i-g-t tests.
+
+     Set the IGT_TEST_ROOT environment variable to point to the tests
+     directory or link up the i-g-t sources with piglit using a symlink:
 
      piglit-sources $ cd bin
      piglit-sources/bin $ ln $i-g-t-sources igt -s
 
Quoted 12 lines

README tests/ · line 51

Quoted 9 lines
README +0 -9
-     To avoid some hassles with piglit's use of Waffle just disable it. Run
-
-     piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
-
-     With
-
-     piglit-sources $ ccmake .
-
-     you can check your configuration with a curses interface, too.

Hm, why did you drop this? I run into "lack of waffle" every time I try to use piglit ... Otherwise looks good.

Quoted 3 lines

Since there's no need to actually build the Piglit test cases when running intel-gpu-tools tests, there's no requirement for waffle either.

Oh right ;-) Can you please mention this for dummies like me? -Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch