Skip to contentSkip to conversation

overlayfs.bbclass: upperdir ownership change in wrynose

wrynose Andreas Mützel 2 participants 2 messages Jun 11

lore
Share & tools
lore
#0 lore raw

Hi all,

we observed a change in the behaviour of overlayfs.bbclass when porting a BSP from scarthgap to wrynose:

This class used to create a helper unit that created the upperdir if it did not exist by calling the script found in meta/files/overlayfs-create-dirs.sh. Additionally, the script changed the owner of the upperdir to match the one of the lowerdir.

This helper unit and script been removed in oe-core with commit 623c20ff1e989730138c3fbe6e8247eaada20707 because systemd now automatically creates the upperdir if it does not exist. But systemd does not adapt the ownership; instead, it gets created as owned by the default user and group (root:root).

I could not find any reference to this change in the migration notes - is this an intentional change or have we discovered a regression?

Best regards,
Andreas

Signature · 12 lines
emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail [email protected]
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
Office München: Am Knie 16, 81241 München, Germany
http://www.emlix.com

emlix - your embedded Linux partner
#1 lore raw
Quoted 10 lines · Andreas Mützel via lists.openembedded.org

Hi all,

we observed a change in the behaviour of overlayfs.bbclass when porting a BSP from scarthgap to wrynose:

This class used to create a helper unit that created the upperdir if it did not exist by calling the script found in meta/files/overlayfs-create-dirs.sh. Additionally, the script changed the owner of the upperdir to match the one of the lowerdir.

Quoted 8 lines

This helper unit and script been removed in oe-core with commit 623c20ff1e989730138c3fbe6e8247eaada20707 because systemd now automatically creates the upperdir if it does not exist. But systemd does not adapt the ownership; instead, it gets created as owned by the default user and group (root:root).

I could not find any reference to this change in the migration notes - is this an intentional change or have we discovered a regression?

Hello,

Indeed, it looks like a regression to me. Would you be willing to handle it?

If it is easily fixable, send a patch or, if not, open a bug on
https://bugzilla.yoctoproject.org/ with, ideally, a reproducer.

Thanks!

Quoted 3 lines

Best regards,
Andreas

Signature · 2 lines
Yoann Congal
Smile ECS