Skip to contentSkip to conversation

Fix comments in rbtree.c

PATCH In review Nick 2 participants 3 messages Jun 14, 2014 – Jul 8, 2014 Library code

lore
Share & tools
lore

Nick

author
#0 lore raw

PATCH 1/1 Fix comments in rbtree.c

---
 lib/rbtree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
lib/rbtree.c +1 -2
index 65f4eff..c66370c 100644
@@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
 				 *      / \          / \
 				 *     p   u  -->   P   U
 				 *    /            /
-				 *   n            N
+				 *   n            n
 				 *
 				 * However, since g's parent might be red, and
 				 * 4) does not allow this, we need to recurse
-				 * at g.
 				 */
 				rb_set_parent_color(tmp, gparent, RB_BLACK);
 				rb_set_parent_color(parent, gparent, RB_BLACK);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 10 lines · Nick
---
  lib/rbtree.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
lib/rbtree.c +0 -0
index 65f4eff..c66370c 100644

lib/rbtree.c __rb_insert(struct rb_node *node, struct rb_root *root, · line 104

Quoted 5 lines
lib/rbtree.c +1 -1
@@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
  				 *      / \          / \
  				 *     p   u  -->   P   U
  				 *    /            /
-				 *   n            N
+				 *   n            n

You'll need a lengthy explanation here. What makes you think that the comment is wrong ?

Guenter

#2 lore raw

PATCH 1/1 Fix comments in rbtree.c

From: Guenter Roeck wrote on Mon, Jun 16, 2014 at 11:59 PM
Subject: Re: [PATCH] Fix comments in rbtree.c
To: Nick <[email protected]>, [email protected]
Cc: [email protected], [email protected], [email protected]

Quoted 11 lines · Nick
---
  lib/rbtree.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
lib/rbtree.c +0 -0
index 65f4eff..c66370c 100644

lib/rbtree.c __rb_insert(struct rb_node *node, struct rb_root *root, · line 104

Quoted 5 lines
lib/rbtree.c +1 -1
@@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
                                 *      / \          / \
                                 *     p   u  -->   P   U
                                 *    /            /
-                                *   n            N
+                                *   n            n

You'll need a lengthy explanation here. What makes you think that the comment is wrong ?

Guenter

This seems right as of rereading my patch I sent to you. You can drop this patch.
Cheers Nick