kernel-module-split: Add support for KERNEL_MODULE_AUTOLOAD and KERNEL_MODULE_PROBECONF

PATCH In review Richard Purdie 5 participants 8 messages Jun 13, 2014 – Jul 22, 2014

Share & tools

Richard Purdie

author

2014-06-13 15:46 UTC #0 lore raw

PATCH 1/1 kernel-module-split: Add support for KERNEL_MODULE_AUTOLOAD and KERNEL_MODULE_PROBECONF

The current module_autoload_* and module_conf_* variables are error both ugly and error prone. They aren't registered in the task checksums so changes to them aren't reflected in the build. This turns out to be near impossible to fix with the current variable format in any sensible way :(.

This patch replace module_autoload with the list of variables in KERNEL_MODULE_AUTOLOAD which is a much simpler and usable API. An error is printed if an old style variable is encountered. It should be simple to convert to this.

module_conf_* are harder to deal with since there is data associated with it, it isn't simply a flag. We need a list of variables that are set in order to be able to correctly handle the task checksum so we add KERNEL_MODULE_PROBECONF for this purpose and error if the user hasn't added a module to it when they should have.

[YOCTO #5786]

Signed-off-by Richard Purdie <[email protected]>

meta/classes/kernel-module-split.bbclass +9 -1

index d43f743..e38a6f6 100644
@@ -130,8 +130,11 @@ python split_kernel_module_packages () {
 
         # If autoloading is requested, output /etc/modules-load.d/<name>.conf and append
         # appropriate modprobe commands to the postinst
+        autoloadlist = (d.getVar("KERNEL_MODULE_AUTOLOAD", True) or "").split()
         autoload = d.getVar('module_autoload_%s' % basename, True)
         if autoload:
+            bb.error("KERNEL_MODULE_AUTOLOAD has replaced module_autoload_%s, please replace it!" % basename)
+        if basename in autoloadlist:
             name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             for m in autoload.split():

@@ -144,12 +147,15 @@ python split_kernel_module_packages () {
             d.setVar('pkg_postinst_%s' % pkg, postinst)
 
         # Write out any modconf fragment
+        modconflist = (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()
         modconf = d.getVar('module_conf_%s' % basename, True)
-        if modconf:
+        if modconf and basename in modconflist:
             name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             f.write("%s\n" % modconf)
             f.close()
+        elif modconf:
+            bb.error("Please ensure module %s is listed in KERNEL_MODULE_PROBECONF since module_conf_%s is set" % (basename, basename))
 
         files = d.getVar('FILES_%s' % pkg, True)
         files = "%s /etc/modules-load.d/%s.conf /etc/modprobe.d/%s.conf" % (files, basename, basename)

@@ -185,3 +191,5 @@ python split_kernel_module_packages () {
         if len(os.listdir(dir)) == 0:
             os.rmdir(dir)
 }
+
+do_package[vardeps] += '${@" ".join(map(lambda s: "module_conf_" + s, (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()))}'

Bruce Ashfield

2014-06-13 19:02 UTC #1 lore raw

Quoted 11 lines · Richard Purdie

The current module_autoload_* and module_conf_* variables are error both ugly and error prone. They aren't registered in the task checksums so changes to them aren't reflected in the build. This turns out to be near impossible to fix with the current variable format in any sensible way :(.
This patch replace module_autoload with the list of variables in KERNEL_MODULE_AUTOLOAD which is a much simpler and usable API. An error is printed if an old style variable is encountered. It should be simple to convert to this.

Quoted 5 lines

module_conf_* are harder to deal with since there is data associated with it, it isn't simply a flag. We need a list of variables that are set in order to be able to correctly handle the task checksum so we add KERNEL_MODULE_PROBECONF for this purpose and error if the user hasn't added a module to it when they should have.

Looks reasonable to me. In my experience, there aren't a lot of users of the module_* variables, so the transition to the new names and semantics shouldn't be a big issue.

Cheers,

Bruce

Quoted 46 lines

[YOCTO #5786]

Signed-off-by Richard Purdie <[email protected]>

meta/classes/kernel-module-split.bbclass +9 -1

index d43f743..e38a6f6 100644
@@ -130,8 +130,11 @@ python split_kernel_module_packages () {
 
         # If autoloading is requested, output /etc/modules-load.d/<name>.conf and append
         # appropriate modprobe commands to the postinst
+        autoloadlist = (d.getVar("KERNEL_MODULE_AUTOLOAD", True) or "").split()
         autoload = d.getVar('module_autoload_%s' % basename, True)
         if autoload:
+            bb.error("KERNEL_MODULE_AUTOLOAD has replaced module_autoload_%s, please replace it!" % basename)
+        if basename in autoloadlist:
             name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             for m in autoload.split():

@@ -144,12 +147,15 @@ python split_kernel_module_packages () {
             d.setVar('pkg_postinst_%s' % pkg, postinst)
 
         # Write out any modconf fragment
+        modconflist = (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()
         modconf = d.getVar('module_conf_%s' % basename, True)
-        if modconf:
+        if modconf and basename in modconflist:
             name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             f.write("%s\n" % modconf)
             f.close()
+        elif modconf:
+            bb.error("Please ensure module %s is listed in KERNEL_MODULE_PROBECONF since module_conf_%s is set" % (basename, basename))
 
         files = d.getVar('FILES_%s' % pkg, True)
         files = "%s /etc/modules-load.d/%s.conf /etc/modprobe.d/%s.conf" % (files, basename, basename)

@@ -185,3 +191,5 @@ python split_kernel_module_packages () {
         if len(os.listdir(dir)) == 0:
             os.rmdir(dir)
 }
+
+do_package[vardeps] += '${@" ".join(map(lambda s: "module_conf_" + s, (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()))}'

Signature · 2 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Denys Dmytriyenko

2014-06-13 19:13 UTC #2 lore raw

Quoted 19 lines · Bruce Ashfield

Quoted 11 lines · Richard Purdie
The current module_autoload_* and module_conf_* variables are error both ugly and error prone. They aren't registered in the task checksums so changes to them aren't reflected in the build. This turns out to be near impossible to fix with the current variable format in any sensible way :(.
This patch replace module_autoload with the list of variables in KERNEL_MODULE_AUTOLOAD which is a much simpler and usable API. An error is printed if an old style variable is encountered. It should be simple to convert to this.
Quoted 5 lines
module_conf_* are harder to deal with since there is data associated with it, it isn't simply a flag. We need a list of variables that are set in order to be able to correctly handle the task checksum so we add KERNEL_MODULE_PROBECONF for this purpose and error if the user hasn't added a module to it when they should have.

Quoted 3 lines

Looks reasonable to me. In my experience, there aren't a lot of users of the module_* variables, so the transition to the new names and semantics shouldn't be a big issue.

Right, only BSP/Distro maintainers should care... :)

BTW, how about a documentation patch? :)

Signature · 1 line

Denys

Quoted 56 lines

Quoted 45 lines

[YOCTO #5786]

Signed-off-by Richard Purdie <[email protected]>

meta/classes/kernel-module-split.bbclass +9 -1

index d43f743..e38a6f6 100644
@@ -130,8 +130,11 @@ python split_kernel_module_packages () {
 
         # If autoloading is requested, output /etc/modules-load.d/<name>.conf and append
         # appropriate modprobe commands to the postinst
+        autoloadlist = (d.getVar("KERNEL_MODULE_AUTOLOAD", True) or "").split()
         autoload = d.getVar('module_autoload_%s' % basename, True)
         if autoload:
+            bb.error("KERNEL_MODULE_AUTOLOAD has replaced module_autoload_%s, please replace it!" % basename)
+        if basename in autoloadlist:
             name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             for m in autoload.split():

@@ -144,12 +147,15 @@ python split_kernel_module_packages () {
             d.setVar('pkg_postinst_%s' % pkg, postinst)
 
         # Write out any modconf fragment
+        modconflist = (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()
         modconf = d.getVar('module_conf_%s' % basename, True)
-        if modconf:
+        if modconf and basename in modconflist:
             name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             f.write("%s\n" % modconf)
             f.close()
+        elif modconf:
+            bb.error("Please ensure module %s is listed in KERNEL_MODULE_PROBECONF since module_conf_%s is set" % (basename, basename))
 
         files = d.getVar('FILES_%s' % pkg, True)
         files = "%s /etc/modules-load.d/%s.conf /etc/modprobe.d/%s.conf" % (files, basename, basename)

@@ -185,3 +191,5 @@ python split_kernel_module_packages () {
         if len(os.listdir(dir)) == 0:
             os.rmdir(dir)
 }
+
+do_package[vardeps] += '${@" ".join(map(lambda s: "module_conf_" + s, (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()))}'

Signature · 7 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Hart, Darren

2014-06-17 14:54 UTC #3 lore raw

Quoted 22 lines · Denys Dmytriyenko

Quoted 21 lines · Bruce Ashfield
Quoted 2 lines · Richard Purdie
The current module_autoload_* and module_conf_* variables are error both ugly and error prone. They aren't registered in the task
checksums
Quoted 11 lines
so changes to them aren't reflected in the build. This turns out to be near impossible to fix with the current variable format in any sensible way :(.
This patch replace module_autoload with the list of variables in KERNEL_MODULE_AUTOLOAD which is a much simpler and usable API. An error is printed if an old style variable is encountered. It should be simple to convert to this.
module_conf_* are harder to deal with since there is data associated with it, it isn't simply a flag. We need a list of variables that are
set
Quoted 3 lines
in order to be able to correctly handle the task checksum so we add KERNEL_MODULE_PROBECONF for this purpose and error if the user hasn't added a module to it when they should have.

Quoted 7 lines

Quoted 3 lines
Looks reasonable to me. In my experience, there aren't a lot of users of the module_* variables, so the transition to the new names and semantics shouldn't be a big issue.
Right, only BSP/Distro maintainers should care... :)
BTW, how about a documentation patch? :)

Adding Scott R.

I was just looking into that. It appears the ref-manual.html is the place to update. The glossary has a module_autoload definition, which I suppose needs to be replaced with KERNEL_MODULE_AUTOLOAD, which will have slightly different semantics.

If I understand this correctly, the old model was:

module_autoload_foo = "foo"
module_autoload_bar = "bar"

Although the following line in the docs confuses me:

module_autoload_<modname> = "modname1 modname2 modname3"

And now, if I interpreted the commit comment correctly, it should look like:

	KERNEL_MODULE_AUTOLOAD = "foo"
	...
	KERNEL_MODULE_AUTOLOAD += "bar"

I'm not sure how KERNEL_MODULE_PROBECONF is involved, or what value it brings beyond module_conf. From what I can tell, the changes now require:

KERNEL_MODULE_PROBECONF = "foo"

module_conf_foo = "options foo baz=1"

(/me notes the order of operations is non-obvious here "if modconf and basename in modconflist")

Do I have this correct?

--
Darren

Quoted 71 lines

Signature · 2 lines
-- 
Denys
Quoted 65 lines
Review
Quoted 5 lines
[YOCTO #5786]
Signed-off-by Richard Purdie <[email protected]>
(quoted diff) +0 -0
b/meta/classes/kernel-module-split.bbclass
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () { · line 131
Quoted 6 lines
index d43f743..e38a6f6 100644
meta/classes/kernel-module-split.bbclass +0 -0
@@ -130,8 +130,11 @@ python split_kernel_module_packages () {
 
         # If autoloading is requested, output
/etc/modules-load.d/<name>.conf and append
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () { · line 133
Quoted 2 lines
meta/classes/kernel-module-split.bbclass +1 -0
         # appropriate modprobe commands to the postinst
+        autoloadlist = (d.getVar("KERNEL_MODULE_AUTOLOAD", True) or
"").split()
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () {
Quoted 3 lines
meta/classes/kernel-module-split.bbclass +1 -0
         autoload = d.getVar('module_autoload_%s' % basename, True)
         if autoload:
+            bb.error("KERNEL_MODULE_AUTOLOAD has replaced
module_autoload_%s, please replace it!" % basename)
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () { · line 150
Quoted 9 lines
meta/classes/kernel-module-split.bbclass +2 -0
+        if basename in autoloadlist:
             name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             for m in autoload.split():
@@ -144,12 +147,15 @@ python split_kernel_module_packages () {
             d.setVar('pkg_postinst_%s' % pkg, postinst)
 
         # Write out any modconf fragment
+        modconflist = (d.getVar("KERNEL_MODULE_PROBECONF", True) or
"").split()
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () {
Quoted 9 lines
meta/classes/kernel-module-split.bbclass +3 -1
         modconf = d.getVar('module_conf_%s' % basename, True)
-        if modconf:
+        if modconf and basename in modconflist:
             name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             f.write("%s\n" % modconf)
             f.close()
+        elif modconf:
+            bb.error("Please ensure module %s is listed in
KERNEL_MODULE_PROBECONF since module_conf_%s is set" % (basename, basename))
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () { · line 160
Quoted 3 lines
meta/classes/kernel-module-split.bbclass +0 -0
         files = d.getVar('FILES_%s' % pkg, True)
         files = "%s /etc/modules-load.d/%s.conf
/etc/modprobe.d/%s.conf" % (files, basename, basename)
meta/classes/kernel-module-split.bbclass python split_kernel_module_packages () { · line 195
Quoted 6 lines
meta/classes/kernel-module-split.bbclass +2 -0
@@ -185,3 +191,5 @@ python split_kernel_module_packages () {
         if len(os.listdir(dir)) == 0:
             os.rmdir(dir)
 }
+
+do_package[vardeps] += '${@" ".join(map(lambda s: "module_conf_" +
s, (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()))}'
Quoted 2 lines
Signature · 7 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 2 lines

Darren Hart					Open Source Technology Center
[email protected]				            Intel Corporation

Richard Purdie

author

2014-06-17 16:47 UTC #4 lore raw

Quoted 1 line · Darren

Adding Scott R.

I do need to sort out a documentation update.

Quoted 5 lines

I was just looking into that. It appears the ref-manual.html is the place to update. The glossary has a module_autoload definition, which I suppose needs to be replaced with KERNEL_MODULE_AUTOLOAD, which will have slightly different semantics.

Quoted 8 lines

If I understand this correctly, the old model was:
module_autoload_foo = "foo"
module_autoload_bar = "bar"
Although the following line in the docs confuses me:
module_autoload_<modname> = "modname1 modname2 modname3"

That is just wrong.

Quoted 7 lines

And now, if I interpreted the commit comment correctly, it should look like:
	KERNEL_MODULE_AUTOLOAD = "foo"
	...
	KERNEL_MODULE_AUTOLOAD += "bar"

Correct.

Quoted 9 lines

I'm not sure how KERNEL_MODULE_PROBECONF is involved, or what value it brings beyond module_conf. From what I can tell, the changes now require:
KERNEL_MODULE_PROBECONF = "foo"
module_conf_foo = "options foo baz=1"
(/me notes the order of operations is non-obvious here "if modconf and basename in modconflist")

For module_conf, the value is the build system can know which variables were set and account for them in the task checksums. If it doesn't have the list, we'd have to iterate the whole data store and that is a *painfully* slow operation.

module_conf isn't commonly used so maintaining a list isn't too much of a hardship IMO.

Quoted 1 line

Do I have this correct?

Yes.

CHeers,

Richard

Denys Dmytriyenko

2014-06-23 22:55 UTC #5 lore raw

Sorry for the delay...

Quoted 12 lines · Richard Purdie

Quoted 1 line · Darren
Adding Scott R.
I do need to sort out a documentation update.
Quoted 7 lines
I was just looking into that. It appears the ref-manual.html is the place to update. The glossary has a module_autoload definition, which I suppose needs to be replaced with KERNEL_MODULE_AUTOLOAD, which will have slightly different semantics.
If I understand this correctly, the old model was:

Quoted 8 lines

Quoted 6 lines
module_autoload_foo = "foo"
module_autoload_bar = "bar"
Although the following line in the docs confuses me:
module_autoload_<modname> = "modname1 modname2 modname3"
That is just wrong.

Yeah, I think I confused people here... During one of the discussions I tried to mention that standard /etc/modules-load.d/ can have a single file with multiple module entries in it (and the above line was given as an example). Unfortunately, kernel-module-split class couldn't handle that and required placing one module entry per file. So the old syntax would look like this:

module_autoload_<modname1> = "modname1"
module_autoload_<modname2> = "modname2"
etc.

Sorry for the confusion.

Quoted 35 lines

Quoted 6 lines
And now, if I interpreted the commit comment correctly, it should look like:
	KERNEL_MODULE_AUTOLOAD = "foo"
	...
	KERNEL_MODULE_AUTOLOAD += "bar"
Correct.
Quoted 9 lines
I'm not sure how KERNEL_MODULE_PROBECONF is involved, or what value it brings beyond module_conf. From what I can tell, the changes now require:
KERNEL_MODULE_PROBECONF = "foo"
module_conf_foo = "options foo baz=1"
(/me notes the order of operations is non-obvious here "if modconf and basename in modconflist")
For module_conf, the value is the build system can know which variables were set and account for them in the task checksums. If it doesn't have the list, we'd have to iterate the whole data store and that is a *painfully* slow operation.
module_conf isn't commonly used so maintaining a list isn't too much of a hardship IMO.
Quoted 1 line
Do I have this correct?
Yes.
CHeers,
Richard

Martin Jansa

2014-07-22 11:17 UTC #6 lore raw

Quoted 30 lines · Denys Dmytriyenko

Sorry for the delay...
Quoted 12 lines · Richard Purdie
Quoted 1 line · Darren
Adding Scott R.
I do need to sort out a documentation update.
Quoted 7 lines
I was just looking into that. It appears the ref-manual.html is the place to update. The glossary has a module_autoload definition, which I suppose needs to be replaced with KERNEL_MODULE_AUTOLOAD, which will have slightly different semantics.
If I understand this correctly, the old model was:
Quoted 8 lines
Quoted 6 lines
module_autoload_foo = "foo"
module_autoload_bar = "bar"
Although the following line in the docs confuses me:
module_autoload_<modname> = "modname1 modname2 modname3"
That is just wrong.
Yeah, I think I confused people here... During one of the discussions I tried to mention that standard /etc/modules-load.d/ can have a single file with multiple module entries in it (and the above line was given as an example). Unfortunately, kernel-module-split class couldn't handle that and required placing one module entry per file. So the old syntax would look like this:

Quoted 5 lines

module_autoload_<modname1> = "modname1"
module_autoload_<modname2> = "modname2"
etc.
Sorry for the confusion.

Sometimes basename != module name and having multiple entries in one /etc/modules-load.d/file is sometimes useful, see

http://lists.openembedded.org/pipermail/openembedded-core/2014-July/094645.html

which returns support for both features

Quoted 40 lines

Quoted 35 lines
Quoted 6 lines
And now, if I interpreted the commit comment correctly, it should look like:
	KERNEL_MODULE_AUTOLOAD = "foo"
	...
	KERNEL_MODULE_AUTOLOAD += "bar"
Correct.
Quoted 9 lines
I'm not sure how KERNEL_MODULE_PROBECONF is involved, or what value it brings beyond module_conf. From what I can tell, the changes now require:
KERNEL_MODULE_PROBECONF = "foo"
module_conf_foo = "options foo baz=1"
(/me notes the order of operations is non-obvious here "if modconf and basename in modconflist")
For module_conf, the value is the build system can know which variables were set and account for them in the task checksums. If it doesn't have the list, we'd have to iterate the whole data store and that is a *painfully* slow operation.
module_conf isn't commonly used so maintaining a list isn't too much of a hardship IMO.
Quoted 1 line
Do I have this correct?
Yes.
CHeers,
Richard
Signature · 4 lines
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Martin Jansa

2014-06-13 21:02 UTC #7 lore raw

In reply to Bruce Ashfield

Quoted 4 lines · Bruce Ashfield

Quoted 2 lines · Richard Purdie
The current module_autoload_* and module_conf_* variables are error both ugly and error prone. They aren't registered in the task checksums

Looks good, there is extra "error" in first sentence.

Quoted 80 lines

Quoted 9 lines

so changes to them aren't reflected in the build. This turns out to be near impossible to fix with the current variable format in any sensible way :(.
This patch replace module_autoload with the list of variables in KERNEL_MODULE_AUTOLOAD which is a much simpler and usable API. An error is printed if an old style variable is encountered. It should be simple to convert to this.

Quoted 5 lines

module_conf_* are harder to deal with since there is data associated with it, it isn't simply a flag. We need a list of variables that are set in order to be able to correctly handle the task checksum so we add KERNEL_MODULE_PROBECONF for this purpose and error if the user hasn't added a module to it when they should have.

Looks reasonable to me. In my experience, there aren't a lot of users of the module_* variables, so the transition to the new names and semantics shouldn't be a big issue.

Cheers,

Bruce

Quoted 46 lines

[YOCTO #5786]

Signed-off-by Richard Purdie <[email protected]>

meta/classes/kernel-module-split.bbclass +9 -1

index d43f743..e38a6f6 100644
@@ -130,8 +130,11 @@ python split_kernel_module_packages () {
 
         # If autoloading is requested, output /etc/modules-load.d/<name>.conf and append
         # appropriate modprobe commands to the postinst
+        autoloadlist = (d.getVar("KERNEL_MODULE_AUTOLOAD", True) or "").split()
         autoload = d.getVar('module_autoload_%s' % basename, True)
         if autoload:
+            bb.error("KERNEL_MODULE_AUTOLOAD has replaced module_autoload_%s, please replace it!" % basename)
+        if basename in autoloadlist:
             name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             for m in autoload.split():

@@ -144,12 +147,15 @@ python split_kernel_module_packages () {
             d.setVar('pkg_postinst_%s' % pkg, postinst)
 
         # Write out any modconf fragment
+        modconflist = (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()
         modconf = d.getVar('module_conf_%s' % basename, True)
-        if modconf:
+        if modconf and basename in modconflist:
             name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
             f = open(name, 'w')
             f.write("%s\n" % modconf)
             f.close()
+        elif modconf:
+            bb.error("Please ensure module %s is listed in KERNEL_MODULE_PROBECONF since module_conf_%s is set" % (basename, basename))
 
         files = d.getVar('FILES_%s' % pkg, True)
         files = "%s /etc/modules-load.d/%s.conf /etc/modprobe.d/%s.conf" % (files, basename, basename)

@@ -185,3 +191,5 @@ python split_kernel_module_packages () {
         if len(os.listdir(dir)) == 0:
             os.rmdir(dir)
 }
+
+do_package[vardeps] += '${@" ".join(map(lambda s: "module_conf_" + s, (d.getVar("KERNEL_MODULE_PROBECONF", True) or "").split()))}'

Signature · 7 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]