Skip to contentSkip to conversation

powerpc: Reduce scariness of interrupt frames in stack traces

PATCH In review Paul Mackerras 2 participants 2 messages Jun 12, 2014 – Jun 18, 2014 PowerPC

lore
Share & tools
lore

Paul Mackerras

author
#0 lore raw

PATCH 1/1 powerpc: Reduce scariness of interrupt frames in stack traces

Some people see things like "Exception: 501" in stack traces in dmesg and assume that means that something has gone badly wrong, when in fact "Exception: 501" just means a device interrupt was taken. This changes "Exception" to "interrupt" to make it clearer that we are just recording the fact of a change in control flow rather than some error condition.

Signed-off-by Paul Mackerras <[email protected]>
---
 arch/powerpc/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/process.c +1 -1
index 31d0215..aa103dc 100644
@@ -1577,7 +1577,7 @@ void show_stack(struct task_struct *tsk, unsigned long *stack)
 			struct pt_regs *regs = (struct pt_regs *)
 				(sp + STACK_FRAME_OVERHEAD);
 			lr = regs->link;
-			printk("--- Exception: %lx at %pS\n    LR = %pS\n",
+			printk("--- interrupt: %lx at %pS\n    LR = %pS\n",
 			       regs->trap, (void *)regs->nip, (void *)lr);
 			firstframe = 1;
 		}
Signature · 1 line
2.0.0.rc4
reviewer
#1 lore raw
Quoted 6 lines · Paul Mackerras

Some people see things like "Exception: 501" in stack traces in dmesg and assume that means that something has gone badly wrong, when in fact "Exception: 501" just means a device interrupt was taken. This changes "Exception" to "interrupt" to make it clearer that we are just recording the fact of a change in control flow rather than some error condition.

Surely this would be preferable:

Quoted 13 lines
arch/powerpc/kernel/process.c +1 -1
index 31d0215..aa103dc 100644
@@ -1577,7 +1577,7 @@ void show_stack(struct task_struct *tsk, unsigned long *stack)
 			struct pt_regs *regs = (struct pt_regs *)
 				(sp + STACK_FRAME_OVERHEAD);
 			lr = regs->link;
-			printk("--- Exception: %lx at %pS\n    LR = %pS\n",
+			printk("--- 👋🌷🌹🌻🌼🐷🐰🐱💜: %lx at %pS\n    LR = %pS\n",
 			       regs->trap, (void *)regs->nip, (void *)lr);
 			firstframe = 1;
 		}