ARM: i.MX: Migrate Freescale i.MX27 IP Camera board to devicetree

PATCH New Alexander Shiyan 3 participants 7 messages Jun 13, 2014 – Jun 18, 2014

Subsystems (5)

Device tree bindings Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape +1 more subsystems

lore

Share & tools

lore

Alexander Shiyan

author

2014-06-13 06:56 UTC #0 lore raw

PATCH 1/2 ARM: i.MX: Migrate Freescale i.MX27 IP Camera board to devicetree

This patch adds a DT support for Freescale i.MX27 IP Camera board and removes platform representation for this board from the tree.

Signed-off-by Alexander Shiyan <[email protected]>

---
 arch/arm/boot/dts/Makefile          |   1 +
 arch/arm/boot/dts/imx27-ipcam.dts   | 106 ++++++++++++++++++++++++++++++++++++
 arch/arm/mach-imx/Kconfig           |   9 ---
 arch/arm/mach-imx/Makefile          |   1 -
 arch/arm/mach-imx/mach-imx27ipcam.c |  77 --------------------------
 5 files changed, 107 insertions(+), 87 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx27-ipcam.dts
 delete mode 100644 arch/arm/mach-imx/mach-imx27ipcam.c

arch/arm/boot/dts/Makefile +1 -0

index 0f1e8be..b681398 100644
@@ -165,6 +165,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx27-apf27.dtb \
 	imx27-apf27dev.dtb \
 	imx27-eukrea-mbimxsd27-baseboard.dtb \
+	imx27-ipcam.dtb \
 	imx27-pdk.dtb \
 	imx27-phytec-phycore-rdk.dtb \
 	imx27-phytec-phycard-s-rdk.dtb \

arch/arm/boot/dts/imx27-ipcam.dts new file +106 -0

106 lines not on this page · raw message

arch/arm/mach-imx/Kconfig +0 -9

index 4cce93d..ca187be 100644
@@ -397,15 +397,6 @@ config MACH_MXT_TD60
 	  Include support for i-MXT (aka td60) platform. This
 	  includes specific configurations for the module and its peripherals.
 
-config MACH_IMX27IPCAM
-	bool "IMX27 IPCAM platform"
-	select IMX_HAVE_PLATFORM_IMX2_WDT
-	select IMX_HAVE_PLATFORM_IMX_UART
-	select SOC_IMX27
-	help
-	  Include support for IMX27 IPCAM platform. This includes specific
-	  configurations for the board and its peripherals.
-
 config MACH_IMX27_DT
 	bool "Support i.MX27 platforms from device tree"
 	select SOC_IMX27

arch/arm/mach-imx/Makefile +0 -1

index 2c8ca00..a364e20 100644
@@ -66,7 +66,6 @@ obj-$(CONFIG_MACH_CPUIMX27) += mach-cpuimx27.o
 obj-$(CONFIG_MACH_EUKREA_MBIMX27_BASEBOARD) += eukrea_mbimx27-baseboard.o
 obj-$(CONFIG_MACH_PCA100) += mach-pca100.o
 obj-$(CONFIG_MACH_MXT_TD60) += mach-mxt_td60.o
-obj-$(CONFIG_MACH_IMX27IPCAM) += mach-imx27ipcam.o
 obj-$(CONFIG_MACH_IMX27_DT) += imx27-dt.o
 
 # i.MX31 based machines

arch/arm/mach-imx/mach-imx27ipcam.c deleted +0 ~~-77~~

77 lines not on this page · raw message

Signature · 1 line

1.8.5.5

Alexander Shiyan

author

2014-06-13 06:56 UTC #1 lore raw

PATCH 2/2 ARM: i.MX: Migrate Freescale Logic Product Development i.MX27 Lite-Kit board to devicetree

This patch adds a DT support for Freescale Logic Product Development i.MX27 Lite-Kit and removes platform representation for this board from the tree.

Signed-off-by Alexander Shiyan <[email protected]>

---
 arch/arm/boot/dts/Makefile          |  1 +
 arch/arm/boot/dts/imx27-litekit.dts | 72 ++++++++++++++++++++++++++++++++
 arch/arm/mach-imx/Kconfig           |  9 ----
 arch/arm/mach-imx/Makefile          |  1 -
 arch/arm/mach-imx/mach-imx27lite.c  | 83 -------------------------------------
 5 files changed, 73 insertions(+), 93 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx27-litekit.dts
 delete mode 100644 arch/arm/mach-imx/mach-imx27lite.c

arch/arm/boot/dts/Makefile +1 -0

index b681398..25bd629 100644
@@ -166,6 +166,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx27-apf27dev.dtb \
 	imx27-eukrea-mbimxsd27-baseboard.dtb \
 	imx27-ipcam.dtb \
+	imx27-litekit.dtb \
 	imx27-pdk.dtb \
 	imx27-phytec-phycore-rdk.dtb \
 	imx27-phytec-phycard-s-rdk.dtb \

arch/arm/boot/dts/imx27-litekit.dts new file +72 -0

72 lines not on this page · raw message

arch/arm/mach-imx/Kconfig +0 -9

index ca187be..9297cd4 100644
@@ -357,15 +357,6 @@ config MACH_IMX27_VISSTRIM_M10
 	  This includes specific configurations for the board and its
 	  peripherals.
 
-config MACH_IMX27LITE
-	bool "LogicPD MX27 LITEKIT platform"
-	select IMX_HAVE_PLATFORM_IMX_SSI
-	select IMX_HAVE_PLATFORM_IMX_UART
-	select SOC_IMX27
-	help
-	  Include support for MX27 LITEKIT platform. This includes specific
-	  configurations for the board and its peripherals.
-
 config MACH_PCA100
 	bool "Phytec phyCARD-s (pca100)"
 	select IMX_HAVE_PLATFORM_FSL_USB2_UDC

arch/arm/mach-imx/Makefile +0 -1

index a364e20..12eee2a 100644
@@ -60,7 +60,6 @@ obj-$(CONFIG_MACH_MX27ADS) += mach-mx27ads.o
 obj-$(CONFIG_MACH_PCM038) += mach-pcm038.o
 obj-$(CONFIG_MACH_PCM970_BASEBOARD) += pcm970-baseboard.o
 obj-$(CONFIG_MACH_MX27_3DS) += mach-mx27_3ds.o
-obj-$(CONFIG_MACH_IMX27LITE) += mach-imx27lite.o
 obj-$(CONFIG_MACH_IMX27_VISSTRIM_M10) += mach-imx27_visstrim_m10.o
 obj-$(CONFIG_MACH_CPUIMX27) += mach-cpuimx27.o
 obj-$(CONFIG_MACH_EUKREA_MBIMX27_BASEBOARD) += eukrea_mbimx27-baseboard.o

arch/arm/mach-imx/mach-imx27lite.c deleted +0 ~~-83~~

83 lines not on this page · raw message

Signature · 1 line

1.8.5.5

Fabio Estevam

reviewer

2014-06-13 15:15 UTC #2 lore raw

PATCH 1/2 ARM: i.MX: Migrate Freescale i.MX27 IP Camera board to devicetree

In reply to Alexander Shiyan

Quoted 6 lines · Alexander Shiyan

arch/arm/boot/dts/imx27-ipcam.dts new file +6 -0

+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_5v0: regulator at 0 {

arch/arm/boot/dts/imx27-ipcam.dts line 49

Quoted 10 lines

arch/arm/boot/dts/imx27-ipcam.dts new file +10 -0

+                       compatible = "regulator-fixed";
+                       pinctrl-names = "default";
+                       pinctrl-0 = <&pinctrl_reg5v0>;
+                       reg = <0>;
+                       regulator-name = "5V0";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio6 9 GPIO_ACTIVE_HIGH>;
+                       regulator-always-on;
+               };

I don't see this reg_5v0 regulator being referenced anywhere.

Anyway, I am fine if you simply drop the board support file for the mx27 ipcam.

No need to add a dts for it, as I don't have access to this board anymore.

Alexander Shiyan

author

2014-06-13 15:21 UTC #3 lore raw

Fri, 13 Jun 2014 12:15:21 -0300 ?? Fabio Estevam <[email protected]>:

Quoted 19 lines · Alexander Shiyan

Quoted 7 lines

arch/arm/boot/dts/imx27-ipcam.dts new file +6 -0

+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_5v0: regulator at 0 {

arch/arm/boot/dts/imx27-ipcam.dts line 49

Quoted 10 lines

arch/arm/boot/dts/imx27-ipcam.dts new file +10 -0

+                       compatible = "regulator-fixed";
+                       pinctrl-names = "default";
+                       pinctrl-0 = <&pinctrl_reg5v0>;
+                       reg = <0>;
+                       regulator-name = "5V0";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio6 9 GPIO_ACTIVE_HIGH>;
+                       regulator-always-on;
+               };

Quoted 1 line

I don't see this reg_5v0 regulator being referenced anywhere.

I just used IPCAM RM.

Quoted 3 lines

Anyway, I am fine if you simply drop the board support file for the mx27 ipcam.
No need to add a dts for it, as I don't have access to this board anymore.

If so, I will send a removal patch for this, Shawn?

---

Shawn Guo

2014-06-18 14:31 UTC #4 lore raw

PATCH 1/2 ARM: i.MX: Migrate Freescale i.MX27 IP Camera board to devicetree

Quoted 22 lines · Alexander Shiyan

Fri, 13 Jun 2014 12:15:21 -0300 ?? Fabio Estevam <[email protected]>:
Quoted 19 lines · Alexander Shiyan
Quoted 7 lines
arch/arm/boot/dts/imx27-ipcam.dts new file +6 -0
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               reg_5v0: regulator at 0 {
arch/arm/boot/dts/imx27-ipcam.dts line 49
Quoted 10 lines
arch/arm/boot/dts/imx27-ipcam.dts new file +10 -0
+                       compatible = "regulator-fixed";
+                       pinctrl-names = "default";
+                       pinctrl-0 = <&pinctrl_reg5v0>;
+                       reg = <0>;
+                       regulator-name = "5V0";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       gpio = <&gpio6 9 GPIO_ACTIVE_HIGH>;
+                       regulator-always-on;
+               };
Quoted 1 line
I don't see this reg_5v0 regulator being referenced anywhere.

Quoted 7 lines

I just used IPCAM RM.
Quoted 3 lines
Anyway, I am fine if you simply drop the board support file for the mx27 ipcam.
No need to add a dts for it, as I don't have access to this board anymore.
If so, I will send a removal patch for this, Shawn?

Yes, please.

Shawn

Alexander Shiyan

author

2014-06-18 17:25 UTC #5 lore raw

Wed, 18 Jun 2014 22:31:36 +0800 ?? Shawn Guo <[email protected]>:

Quoted 3 lines · Alexander Shiyan

Quoted 2 lines
Fri, 13 Jun 2014 12:15:21 -0300 ?? Fabio Estevam <[email protected]>:
Quoted 1 line · Alexander Shiyan

...

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Anyway, I am fine if you simply drop the board support file for the mx27 ipcam.
No need to add a dts for it, as I don't have access to this board anymore.
If so, I will send a removal patch for this, Shawn?
Yes, please.

OK. What about mach-imx27lite (Part 2/2 of this patch)?

---

Fabio Estevam

reviewer

2014-06-18 17:31 UTC #6 lore raw

PATCH 1/2 ARM: i.MX: Migrate Freescale i.MX27 IP Camera board to devicetree

Quoted 1 line · Alexander Shiyan

OK. What about mach-imx27lite (Part 2/2 of this patch)?

I would suggest simply removing the board support for mach-imx27lite too.

This board only has UART and FEC support and there have been no more updates to add new features since the initial commit.

If anyone is interested on this board, then it should be simple to add a dts file for it.