ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable

PATCH In review Gaku Inami 3 participants 8 messages Jun 5, 2014 – Jun 20, 2014

Subsystems (4)

Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture

lore

Share & tools

lore

Gaku Inami

author

2014-06-05 03:49 UTC #0 lore raw

PATCH v3 1/1 ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable

From: Benoit Cousson <[email protected]>

Mark all SoCs in shmobile as CPUFreq capable
on multiplatform build only.

Signed-off-by Benoit Cousson <[email protected]>

[[email protected]: Move the definition of cpufreq capable]

Signed-off-by Gaku Inami <[email protected]>

---

Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- fixed typo.

Changes since version 2:
- moved the definition of cpufreq capable for shmobile.
- reworked based on renesas-devel-v3.15-rc8-20140605.

 arch/arm/mach-shmobile/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

arch/arm/mach-shmobile/Kconfig +2 -0

index 2a7712b..3b28bd8 100644
@@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
 	select NO_IOPORT_MAP
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_HAS_CPUFREQ
+	select ARCH_HAS_OPP
 
 if ARCH_SHMOBILE_MULTI

Signature · 1 line

1.7.9.5

Simon Horman

2014-06-05 04:09 UTC #1 lore raw

Quoted 8 lines · Gaku Inami

From: Benoit Cousson <[email protected]>
Mark all SoCs in shmobile as CPUFreq capable
on multiplatform build only.
Signed-off-by Benoit Cousson <[email protected]>
[[email protected]: Move the definition of cpufreq capable]
Signed-off-by Gaku Inami <[email protected]>

Thanks, I have queued this up.

Paul Bolle

2014-06-19 07:49 UTC #2 lore raw

In reply to Gaku Inami

Quoted 9 lines · Gaku Inami

From: Benoit Cousson <[email protected]>
Mark all SoCs in shmobile as CPUFreq capable
on multiplatform build only.
Signed-off-by Benoit Cousson <[email protected]>
[[email protected]: Move the definition of cpufreq capable]
Signed-off-by Gaku Inami <[email protected]>
---

This patch landed in next-20140619.

Quoted 16 lines

Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- fixed typo.
Changes since version 2:
- moved the definition of cpufreq capable for shmobile.
- reworked based on renesas-devel-v3.15-rc8-20140605.
 arch/arm/mach-shmobile/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/Kconfig +0 -0
index 2a7712b..3b28bd8 100644

arch/arm/mach-shmobile/Kconfig config ARCH_SHMOBILE_MULTI · line 16

Quoted 4 lines

arch/arm/mach-shmobile/Kconfig +1 -0

@@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
 	select NO_IOPORT_MAP
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_HAS_CPUFREQ

The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So selecting that became a nop.

Is the trivial patch to drop this select statement queued somewhere?

(Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests that this trivial patch is all that is needed at this point.)

arch/arm/mach-shmobile/Kconfig config ARCH_SHMOBILE_MULTI · line 20

Quoted 4 lines

arch/arm/mach-shmobile/Kconfig +1 -0
+	select ARCH_HAS_OPP
 
 if ARCH_SHMOBILE_MULTI
 

Paul Bolle

Simon Horman

2014-06-19 08:09 UTC #3 lore raw

In reply to Gaku Inami

Quoted 38 lines · Paul Bolle

Quoted 9 lines · Gaku Inami
From: Benoit Cousson <[email protected]>
Mark all SoCs in shmobile as CPUFreq capable
on multiplatform build only.
Signed-off-by Benoit Cousson <[email protected]>
[[email protected]: Move the definition of cpufreq capable]
Signed-off-by Gaku Inami <[email protected]>
---
This patch landed in next-20140619.
Quoted 16 lines
Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- fixed typo.
Changes since version 2:
- moved the definition of cpufreq capable for shmobile.
- reworked based on renesas-devel-v3.15-rc8-20140605.
 arch/arm/mach-shmobile/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-shmobile/Kconfig +0 -0
index 2a7712b..3b28bd8 100644
arch/arm/mach-shmobile/Kconfig config ARCH_SHMOBILE_MULTI · line 16
Quoted 4 lines
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
 	select NO_IOPORT_MAP
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_HAS_CPUFREQ
The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So selecting that became a nop.

Quoted 8 lines

Is the trivial patch to drop this select statement queued somewhere?
(Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests that this trivial patch is all that is needed at this point.)
arch/arm/mach-shmobile/Kconfig config ARCH_SHMOBILE_MULTI · line 19
Quoted 3 lines
arch/arm/mach-shmobile/Kconfig +1 -0
+	select ARCH_HAS_OPP
 
 if ARCH_SHMOBILE_MULTI

Thanks for the follow-up Paul.

Inami-san, could you please make an appropriate patch?

Please note the dependency on the patch that Paul has noted, hopefully it will be included in v3.16-rc2.

Gaku Inami

author

2014-06-19 09:16 UTC #4 lore raw

In reply to Gaku Inami

Hi Simon-san,

Quoted 5 lines · Simon Horman

Inami-san, could you please make an appropriate patch?
Please note the dependency on the patch that Paul has noted, hopefully it will be included in v3.16-rc2.

I understand. I will fix it and send again.

Regards,
Inami

Simon Horman

2014-06-20 01:18 UTC #5 lore raw

In reply to Gaku Inami

Quoted 10 lines · Gaku Inami

Hi Simon-san,
Quoted 5 lines · Simon Horman
Inami-san, could you please make an appropriate patch?
Please note the dependency on the patch that Paul has noted, hopefully it will be included in v3.16-rc2.
I understand. I will fix it and send again.

Please just send an (probably small) incremental patch that applies on top of my current devel branch. There is no need to rework your patches that I have already queued up.

Thanks

Gaku Inami

author

2014-06-20 04:40 UTC #6 lore raw

In reply to Gaku Inami

Hi Simon-san,

Quoted 4 lines · Simon Horman

Quoted 3 lines · Gaku Inami
Hi Simon-san,
(2014/06/19 17:09), Simon Horman wrote:

Quoted 8 lines

Quoted 5 lines
Quoted 4 lines
Inami-san, could you please make an appropriate patch?
Please note the dependency on the patch that Paul has noted, hopefully it will be included in v3.16-rc2.
I understand. I will fix it and send again.
Please just send an (probably small) incremental patch that applies on top of my current devel branch. There is no need to rework your patches that I have already queued up.

I'm sorry, my reply was not appropriate.

I posted a new patch(no rework patch from patch v3). Please find the following commit:
http://marc.info/?l=linux-sh&m0317622532328&w=2

This patch can be applied to the top of renesas-devel. (tag:renesas-devel-v3.16-rc1-20140618)
Also, this patch can be applied to linux-next(next-20140619).

Regards,
Inami

Simon Horman

2014-06-20 05:04 UTC #7 lore raw

In reply to Gaku Inami

Quoted 18 lines · Gaku Inami

Hi Simon-san,
Quoted 4 lines · Simon Horman
Quoted 3 lines · Gaku Inami
Hi Simon-san,
(2014/06/19 17:09), Simon Horman wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 4 lines
Inami-san, could you please make an appropriate patch?
Please note the dependency on the patch that Paul has noted, hopefully it will be included in v3.16-rc2.
I understand. I will fix it and send again.
Please just send an (probably small) incremental patch that applies on top of my current devel branch. There is no need to rework your patches that I have already queued up.
I'm sorry, my reply was not appropriate.

Quoted 7 lines

I posted a new patch(no rework patch from patch v3). Please find the following commit:
http://marc.info/?l=linux-sh&m0317622532328&w=2
This patch can be applied to the top of renesas-devel. (tag:renesas-devel-v3.16-rc1-20140618)
Also, this patch can be applied to linux-next(next-20140619).

Thanks, it looks good.