staging: rtl8192e: check return value of dev_skb_alloc
PATCH 1/1 staging: rtl8192e: check return value of dev_skb_alloc
--- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +3 -3
@@ -36,7 +36,6 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, u32 buffer_len) {struct r8192_priv *priv =rtllib_priv (dev); -bool rt_status = true;u16 frag_threshold;u16 frag_length, frag_offset =0 ;int i;
@@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, bLastIniPkt =1 ; } - +if (!skb) +return false; skb =dev_alloc_skb (frag_length +4 );memcpy ((unsigned char *)(skb->cb), &dev,sizeof (dev)); tcb_desc = (struct cb_desc *)(skb->cb +MAX_DEV_ADDR_SIZE );
@@ -99,7 +99,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,write_nic_byte (dev, TPPoll, TPPoll_CQ); -return rt_status; +return true; }static bool CPUcheck_maincodeok_turnonCPU (struct net_device *dev)
Signature · 1 line
1.9.1
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
Quoted 1 line · Nicholas Krause
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +0
-0
[]
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, · line 63
Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2
-1@@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, bLastIniPkt =1 ; } - +if (!skb) +return false; skb =dev_alloc_skb (frag_length +4 );
Nick.
You may have compiled this, but it's obvious you
haven't tested it.
Please stop sending patches until you can verify what you're doing with the code.
Please train a few more of your neurons for coding.
It takes some time and some practice but please don't practice on linux-kernel.
Use google to find some other suitable forums like
http://cboard.cprogramming.com/c-programming/
Back to your patch:
if (!skb) return false;
must go _after_
skb = dev_alloc_skb(frag_length + 4);
This patch is old I thought I fixed it and resent. Cheers Nick
Quoted 40 lines · Joe Perches
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
Quoted 1 line · Nicholas Krause
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +0
-0[]
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, · line 63
Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2
-1@@ -59,7 +58,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, bLastIniPkt =1 ; } - +if (!skb) +return false; skb =dev_alloc_skb (frag_length +4 );Nick.
You may have compiled this, but it's obvious you
haven't tested it.Please stop sending patches until you can verify what you're doing with the code.
Please train a few more of your neurons for coding.
It takes some time and some practice but please don't practice on linux-kernel.
Use google to find some other suitable forums like
http://cboard.cprogramming.com/c-programming/Back to your patch:
if (!skb) return false;must go _after_
skb = dev_alloc_skb(frag_length + 4);