Skip to contentSkip to conversation

staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

PATCH In review Nicholas Krause 5 participants 8 messages Jun 20, 2014 – Jun 21, 2014 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B.

---
 drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c +1 -1
index 01f5a74..2d4fad3 100644
@@ -144,7 +144,7 @@ static bool halbtc_legacy(struct rtl_priv *adapter)
 	
 	bool is_legacy = false;
 
-	if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B))
+	if ((mac->mode == WIRELESS_MODE_A) || (mac->mode == WIRELESS_MODE_B))
 		is_legacy = true;
 
 	return is_legacy;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Nicholas Krause

Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B.

You're just guessing that A and B were intended but it could have been something B and G...

Don't do this. Just leave the static checker warning there so someone can fix it properly instead of introducing a second new bug and hiding the warning so it's impossible to find.

regards,
dan carpenter

#2 lore raw
Quoted 11 lines · Dan Carpenter
Quoted 2 lines · Nicholas Krause

Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B.

You're just guessing that A and B were intended but it could have been something B and G...

Don't do this. Just leave the static checker warning there so someone can fix it properly instead of introducing a second new bug and hiding the warning so it's impossible to find.

It's most likely G anyway:

drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_G))
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B))

Larry probably has a better idea.

#3 lore raw

Thanks for the feedback I will resend the patch fixed. Otherwise please use Larry's idea.
Cheers Nick

Quoted 20 lines · Joe Perches
Quoted 11 lines · Dan Carpenter
Quoted 2 lines · Nicholas Krause

Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B.

You're just guessing that A and B were intended but it could have been something B and G...

Don't do this. Just leave the static checker warning there so someone can fix it properly instead of introducing a second new bug and hiding the warning so it's impossible to find.

It's most likely G anyway:

drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_G))
drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c:     if ((mac->mode == WIRELESS_MODE_B) || (mac->mode == WIRELESS_MODE_B))

Larry probably has a better idea.

#4 lore raw
Quoted 1 line · Nick Krause

Thanks for the feedback I will resend the patch fixed.

Please do not.

Quoted 1 line

Otherwise please use Larry's idea.

It's not Larry's idea. Larry is the primary
contributor for Realtek drivers in staging.

#5 lore raw

Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged.
Thank Nick

Quoted 11 lines · Joe Perches
Quoted 1 line · Nick Krause

Thanks for the feedback I will resend the patch fixed.

Please do not.

Quoted 1 line

Otherwise please use Larry's idea.

It's not Larry's idea. Larry is the primary
contributor for Realtek drivers in staging.

#6 lore raw
Quoted 5 lines · Nick Krause

Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged.
Thank Nick

Quoted 10 lines
Quoted 9 lines · Joe Perches
Quoted 1 line · Nick Krause

Thanks for the feedback I will resend the patch fixed.

Please do not.

Quoted 1 line

Otherwise please use Larry's idea.

It's not Larry's idea. Larry is the primary
contributor for Realtek drivers in staging.

I have just returned from back-to-back trips and a recovery from the failure of my primary laptop. Once I get a little time, I will research this issue and let you know. In the meantime, this patch should not be merged as it is not likely correct.

Larry

A message that is not in the archive (sent off-list or not yet received): CAPDOMVgvnNkVc9TN4MHm7UaD+nfac8C6A0kMo=q9Q237nTWUKQ@mail.gmail.com

maintainer
#8 lore raw
Quoted 4 lines · Nick Krause

Hope you enjoyed your trips , Larry. It would be great if you researched this issue in order for me to send in a correct patch to fix this bug.

That is not how kernel development is done, you need to do the work, not ask others to do it for you.

best of luck,

greg k-h