Skip to contentSkip to conversation

tulip: Poll link status more frequently for Comet chips

PATCH In review Ondrej Zary 3 participants 3 messages Jun 21, 2014 – Jun 22, 2014

Subsystems (3)
Networking Network drivers Tulip network drivers
lore
Share & tools
lore

Ondrej Zary

author
#0 lore raw

PATCH 1/1 tulip: Poll link status more frequently for Comet chips

Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Tested with AN983B.

Signed-off-by Ondrej Zary <[email protected]>
---
 drivers/net/ethernet/dec/tulip/timer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/dec/tulip/timer.c +1 -1
index 768379b..523d9dd 100644
@@ -158,7 +158,7 @@ void comet_timer(unsigned long data)
 {
 	struct net_device *dev = (struct net_device *)data;
 	struct tulip_private *tp = netdev_priv(dev);
-	int next_tick = 60*HZ;
+	int next_tick = 2*HZ;
 
 	if (tulip_debug > 1)
 		netdev_dbg(dev, "Comet link status %04x partner capability %04x\n",
Signature · 1 line
Ondrej Zary
#1 lore raw

Hi Ondrej,

Quoted 1 line · Ondrej Zary

Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.

Why use 2 seconds for the polling interval?

I'm sure you have a good reason for this and it should be in the commit message or as a comment in the code.

I otherwise have no objection to this change.

thanks,
grant

Quoted 22 lines

Tested with AN983B.

Signed-off-by Ondrej Zary <[email protected]>
---
 drivers/net/ethernet/dec/tulip/timer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/dec/tulip/timer.c +1 -2
index 768379b..523d9dd 100644
@@ -158,7 +158,7 @@ void comet_timer(unsigned long data)
 {
        struct net_device *dev = (struct net_device *)data;
        struct tulip_private *tp = netdev_priv(dev);
-       int next_tick = 60*HZ;
+       int next_tick = 2*HZ;
 
        if (tulip_debug > 1)
                netdev_dbg(dev, "Comet link status %04x partner capability %04x\n",
--

Ondrej Zary

maintainer
#2 lore raw

From: Grant Grundler <[email protected]>
Date: Sat, 21 Jun 2014 15:59:30 -0700

Quoted 11 lines

Hi Ondrej,

Quoted 1 line · Ondrej Zary

Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.

Why use 2 seconds for the polling interval?

I'm sure you have a good reason for this and it should be in the commit message or as a comment in the code.

I otherwise have no objection to this change.

Agreed, please post this with a better commit message, specifically make sure you explain why the interval is being changed and why 2*HZ is specifically being choosen.

Thanks.