Skip to contentSkip to conversation

Tools: hv: fix file overwriting of hv_fcopy_daemon

PATCH New Yue Zhang 1 participant 1 message Jun 28, 2014 Hyper-V/Azure core and drivers

lore
Share & tools
lore

Yue Zhang

author
#0 lore raw

PATCH v3 1/1 Tools: hv: fix file overwriting of hv_fcopy_daemon

From: Yue Zhang <[email protected]>

hv_fcopy_daemon fails to overwrite a file if the target file already exits.

Add O_TRUNC flag on opening.

---
 tools/hv/hv_fcopy_daemon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/hv/hv_fcopy_daemon.c +2 -1
index fba1c75..8f96b3e 100644
@@ -88,7 +88,8 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
 		}
 	}
 
-	target_fd = open(target_fname, O_RDWR | O_CREAT | O_CLOEXEC, 0744);
+	target_fd = open(target_fname,
+			 O_RDWR | O_CREAT | O_TRUNC | O_CLOEXEC, 0744);
 	if (target_fd == -1) {
 		syslog(LOG_INFO, "Open Failed: %s", strerror(errno));
 		goto done;
Signature · 1 line
1.9.1