drm/i915/chv: Drop WaGsvBringDownFreqInRc6

PATCH Applied [email protected] 3 participants 5 messages Jun 27, 2014 – Jul 15, 2014

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

[email protected]

author

2014-06-27 06:01 UTC #0 lore raw

PATCH 1/1 drm/i915/chv: Drop WaGsvBringDownFreqInRc6

From: Deepak S <[email protected]>

Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the voltage down.

Signed-off-by Deepak S <[email protected]>

---
 drivers/gpu/drm/i915/intel_pm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/gpu/drm/i915/intel_pm.c +3 -1

index 6b6cfd4..4875f745 100644
@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
 
 	mutex_lock(&dev_priv->rps.hw_lock);
 	if (dev_priv->rps.enabled) {
-		if (IS_VALLEYVIEW(dev))
+		if (IS_CHERRYVIEW(dev))
+			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+		else if (IS_VALLEYVIEW(dev))
 			vlv_set_rps_idle(dev_priv);
 		else
 			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);

Signature · 1 line

1.9.1

Deepak S

author

2014-07-14 07:39 UTC #1 lore raw

Quoted 16 lines · On Saturday 28 June 2014 11:26 AM, [email protected] wrote:

From: Deepak S <[email protected]>
Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the voltage down.
Signed-off-by Deepak S <[email protected]>
---
  drivers/gpu/drm/i915/intel_pm.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +0 -0
index 6b6cfd4..4875f745 100644

drivers/gpu/drm/i915/intel_pm.c void gen6_rps_idle(struct drm_i915_private *dev_priv) · line 3261

Quoted 10 lines

drivers/gpu/drm/i915/intel_pm.c +3 -1

@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
 
  	mutex_lock(&dev_priv->rps.hw_lock);
  	if (dev_priv->rps.enabled) {
-		if (IS_VALLEYVIEW(dev))
+		if (IS_CHERRYVIEW(dev))
+			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+		else if (IS_VALLEYVIEW(dev))
  			vlv_set_rps_idle(dev_priv);
  		else
  			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);

Hi Jesse,

can you please review this patch?

Thanks
Deepak

Jesse Barnes

Reviewed-by

2014-07-14 15:16 UTC #2 lore raw

Quoted 31 lines · On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S <[email protected]> wrote:

Quoted 16 lines · On Saturday 28 June 2014 11:26 AM, [email protected] wrote:
From: Deepak S <[email protected]>
Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the voltage down.
Signed-off-by Deepak S <[email protected]>
---
  drivers/gpu/drm/i915/intel_pm.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +0 -0
index 6b6cfd4..4875f745 100644
drivers/gpu/drm/i915/intel_pm.c void gen6_rps_idle(struct drm_i915_private *dev_priv) · line 3261
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +3 -1
@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
 
  	mutex_lock(&dev_priv->rps.hw_lock);
  	if (dev_priv->rps.enabled) {
-		if (IS_VALLEYVIEW(dev))
+		if (IS_CHERRYVIEW(dev))
+			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+		else if (IS_VALLEYVIEW(dev))
  			vlv_set_rps_idle(dev_priv);
  		else
  			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
Hi Jesse,

Quoted 1 line

can you please review this patch?

Reviewed-by Jesse Barnes <[email protected]>

Signature · 1 line

Jesse Barnes, Intel Open Source Technology Center

Daniel Vetter

Applied

2014-07-14 17:26 UTC #3 lore raw

Quoted 34 lines · Jesse Barnes

Quoted 31 lines · On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S <[email protected]> wrote:
Quoted 16 lines · On Saturday 28 June 2014 11:26 AM, [email protected] wrote:
From: Deepak S <[email protected]>
Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the voltage down.
Signed-off-by Deepak S <[email protected]>
---
  drivers/gpu/drm/i915/intel_pm.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +0 -0
index 6b6cfd4..4875f745 100644
drivers/gpu/drm/i915/intel_pm.c void gen6_rps_idle(struct drm_i915_private *dev_priv) · line 3261
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +3 -1
@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
 
  	mutex_lock(&dev_priv->rps.hw_lock);
  	if (dev_priv->rps.enabled) {
-		if (IS_VALLEYVIEW(dev))
+		if (IS_CHERRYVIEW(dev))
+			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+		else if (IS_VALLEYVIEW(dev))
  			vlv_set_rps_idle(dev_priv);
  		else
  			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
Hi Jesse,

Quoted 3 lines

Quoted 1 line
can you please review this patch?
Reviewed-by Jesse Barnes <[email protected]>

Queued for -next, thanks for the patch.
-Daniel

Signature · 3 lines

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Deepak S

author

2014-07-15 03:26 UTC #4 lore raw

In reply to Jesse Barnes

Quoted 32 lines · Jesse Barnes

Quoted 29 lines · On Tue, 15 Jul 2014 13:03:55 +0530 Deepak S <[email protected]> wrote:
Quoted 16 lines · On Saturday 28 June 2014 11:26 AM, [email protected] wrote:
From: Deepak S <[email protected]>
Drop WaGsvBringDownFreq on CHV.
When in RC6 requesting the min freq should be fine to bring the voltage down.
Signed-off-by Deepak S <[email protected]>
---
   drivers/gpu/drm/i915/intel_pm.c | 4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +0 -0
index 6b6cfd4..4875f745 100644
drivers/gpu/drm/i915/intel_pm.c void gen6_rps_idle(struct drm_i915_private *dev_priv) · line 3261
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +3 -1
@@ -3253,7 +3253,9 @@ void gen6_rps_idle(struct drm_i915_private *dev_priv)
 
   	mutex_lock(&dev_priv->rps.hw_lock);
   	if (dev_priv->rps.enabled) {
-		if (IS_VALLEYVIEW(dev))
+		if (IS_CHERRYVIEW(dev))
+			valleyview_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
+		else if (IS_VALLEYVIEW(dev))
   			vlv_set_rps_idle(dev_priv);
   		else
   			gen6_set_rps(dev_priv->dev, dev_priv->rps.min_freq_softlimit);
Hi Jesse,

Quoted 3 lines

Quoted 1 line
can you please review this patch?
Reviewed-by Jesse Barnes <[email protected]>

Thanks for reviewing