hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div
Subsystems (2)
PATCH RESEND 1/1 hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div
Writing to fanX_div does not clear the cache. As a result, reading from fanX_div may return the old value for up to two seconds after writing a new value.
This patch ensures the fan_div cache is updated in set_fan_div().
---
Sorry, I have a typo in previous patch s/fad_div/fan_div/. So here is a resend.
drivers/hwmon/adm1029.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/hwmon/adm1029.c +3 -0
@@ -242,6 +242,9 @@ static ssize_t set_fan_div(struct device *dev,/* Update the value */ reg = (reg &0x3F ) | (val <<6 ); +/* Update the cache */ + data->fan_div[attr->index] = reg; +/* Write value */ i2c_smbus_write_byte_data (client,ADM1029_REG_FAN_DIV [attr->index], reg);
Signature · 9 lines
1.9.1 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 10 lines · Axel Lin
Writing to
fanX_divdoes not clear the cache. As a result, reading fromfanX_divmay return the old value for up to two seconds after writing a new value.This patch ensures the
fan_divcache is updated inset_fan_div().Reported-by Guenter Roeck <[email protected]>Signed-off-by Axel Lin <[email protected]>---
Sorry, I have a typo in previous patch s/fad_div/fan_div/. So here is a resend.
fad_div is more fun though ;-)
I sent out the same patch half an hour ago, but I'll take yours for the second sign-off.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors