Skip to contentSkip to conversation

sanity.bbclass: Update minimum git version to 1.7.8

PATCH In review Richard Purdie 2 participants 2 messages Jul 4, 2014 – Jul 7, 2014

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 sanity.bbclass: Update minimum git version to 1.7.8

To quote "Maxin B. John" <[email protected]>:

git version 1.7.8 added the --list option to git-branch. Since we depend on this option in git.py, the minimum requiremnt for git should be updated to Git 1.7.8+

Signed-off-by Richard Purdie <[email protected]>
meta/classes/sanity.bbclass +3 -3
index 4b42b17..ed65814 100644
@@ -386,15 +386,15 @@ def check_tar_version(sanity_data):
         return "Your version of tar is older than 1.24 and has bugs which will break builds. Please install a newer version of tar.\n"
     return None
 
-# We use git parameters and functionality only found in 1.7.5 or later
+# We use git parameters and functionality only found in 1.7.8 or later
 def check_git_version(sanity_data):
     from distutils.version import LooseVersion
     status, result = oe.utils.getstatusoutput("git --version 2> /dev/null")
     if status != 0:
         return "Unable to execute git --version, exit code %s\n" % status
     version = result.split()[2]
-    if LooseVersion(version) < LooseVersion("1.7.5"):
-        return "Your version of git is older than 1.7.5 and has bugs which will break builds. Please install a newer version of git.\n"
+    if LooseVersion(version) < LooseVersion("1.7.8"):
+        return "Your version of git is older than 1.7.8 and has bugs which will break builds. Please install a newer version of git.\n"
     return None
 
 # Check the required perl modules which may not be installed by default
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 21 lines · Richard Purdie

To quote "Maxin B. John" <[email protected]>:

git version 1.7.8 added the --list option to git-branch. Since we depend on this option in git.py, the minimum requiremnt for git should be updated to Git 1.7.8+

Signed-off-by Richard Purdie <[email protected]>
meta/classes/sanity.bbclass +1 -1
index 4b42b17..ed65814 100644
@@ -386,15 +386,15 @@ def check_tar_version(sanity_data):
         return "Your version of tar is older than 1.24 and has bugs which will break builds. Please install a newer version of tar.\n"
     return None
 
-# We use git parameters and functionality only found in 1.7.5 or later
+# We use git parameters and functionality only found in 1.7.8 or later
 def check_git_version(sanity_data):
     from distutils.version import LooseVersion
     status, result = oe.utils.getstatusoutput("git --version 2> /dev/null")

meta/classes/sanity.bbclass def check_tar_version(sanity_data): · line 400

Quoted 10 lines
meta/classes/sanity.bbclass +2 -2
     if status != 0:
         return "Unable to execute git --version, exit code %s\n" % status
     version = result.split()[2]
-    if LooseVersion(version) < LooseVersion("1.7.5"):
-        return "Your version of git is older than 1.7.5 and has bugs which will break builds. Please install a newer version of git.\n"
+    if LooseVersion(version) < LooseVersion("1.7.8"):
+        return "Your version of git is older than 1.7.8 and has bugs which will break builds. Please install a newer version of git.\n"
     return None
 
 # Check the required perl modules which may not be installed by default

Ah, I missed this part. Thanks for updating it!

Reviewed-by Maxin B. John <[email protected]>

Best Regards,
Maxin