drm/i915/bdw: 3D_CHICKEN3 has write mask bits
Subsystems (2)
PATCH 1/1 drm/i915/bdw: 3D_CHICKEN3 has write mask bits
From: Michel Thierry <[email protected]>
The workaround to limit SDE poly depth FIFO to 2 is not applied because 3D Chicken-3 mask bit is not set.
WaLimitSizeOfSDEPolyFifo is only for BDW-A and could be removed.
Signed-off-by Michel Thierry <[email protected]>
--- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -5360,7 +5360,7 @@ static void gen8_init_clock_gating(struct drm_device *dev)I915_WRITE (GAMTARBMODE ,_MASKED_BIT_ENABLE (ARB_MODE_BWGTLB_DISABLE ));I915_WRITE (_3D_CHICKEN3, -_3D_CHICKEN_SDE_LIMIT_FIFO_POLY_DEPTH (2 )); +_MASKED_BIT_ENABLE (_3D_CHICKEN_SDE_LIMIT_FIFO_POLY_DEPTH (2 )));I915_WRITE (COMMON_SLICE_CHICKEN2 ,_MASKED_BIT_ENABLE (GEN8_CSC2_SBE_VUE_CACHE_CONSERVATIVE ));
Signature · 1 line
1.9.0
Quoted 8 lines · [email protected] writes:
From: Michel Thierry <[email protected]>
The workaround to limit SDE poly depth FIFO to 2 is not applied because 3D Chicken-3 mask bit is not set.
WaLimitSizeOfSDEPolyFifo is only for BDW-A and could be removed.
Signed-off-by Michel Thierry <[email protected]>
Reviewed-by Mika Kuoppala <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_pm.c +1
-1@@ -5360,7 +5360,7 @@ static void gen8_init_clock_gating(struct drm_device *dev)I915_WRITE (GAMTARBMODE ,_MASKED_BIT_ENABLE (ARB_MODE_BWGTLB_DISABLE ));I915_WRITE (_3D_CHICKEN3, -_3D_CHICKEN_SDE_LIMIT_FIFO_POLY_DEPTH (2 )); +_MASKED_BIT_ENABLE (_3D_CHICKEN_SDE_LIMIT_FIFO_POLY_DEPTH (2 )));I915_WRITE (COMMON_SLICE_CHICKEN2 ,_MASKED_BIT_ENABLE (GEN8_CSC2_SBE_VUE_CACHE_CONSERVATIVE ));Signature · 6 lines
1.9.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 11 lines · Mika Kuoppala
Quoted 8 lines · [email protected] writes:
From: Michel Thierry <[email protected]>
The workaround to limit SDE poly depth FIFO to 2 is not applied because 3D Chicken-3 mask bit is not set.
WaLimitSizeOfSDEPolyFifo is only for BDW-A and could be removed.
Signed-off-by Michel Thierry <[email protected]>Reviewed-by Mika Kuoppala <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch