image.bbclass/buildtools-tarball: cleanup the RDEPENDS
cover image.bbclass/buildtools-tarball: cleanup the RDEPENDS
The following changes since commit a5531a2b8983318b99c119a87b78a92cf84160b8:
bitbake: fetch2/svn: Add transportuser parameter (2014-07-04 09:28:36 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib rbt/rdepends
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=rbt/rdepends
Robert Yang (1):
image.bbclass/buildtools-tarball: cleanup the RDEPENDS
meta/classes/image.bbclass | 4 ++-- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/1 image.bbclass/buildtools-tarball: cleanup the RDEPENDS
The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to RRECOMMENDS
--- meta/classes/image.bbclass | 4 ++-- meta/recipes-core/meta/buildtools-tarball.bb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
meta/classes/image.bbclass +2 -2
@@ -11,8 +11,8 @@ inherit gzipnative LICENSE = "MIT" PACKAGES = "" DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross" -RDEPENDS += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}" -RRECOMMENDS += "${PACKAGE_INSTALL_ATTEMPTONLY}" +RDEPENDS_${PN} += "${PACKAGE_INSTALL} ${LINGUAS_INSTALL}" +RRECOMMENDS_${PN} += "${PACKAGE_INSTALL_ATTEMPTONLY}" INHIBIT_DEFAULT_DEPS = "1"
meta/recipes-core/meta/buildtools-tarball.bb +1 -1
@@ -45,7 +45,7 @@ TOOLCHAIN_HOST_TASK ?= "\ TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-buildtools-nativesdk-standalone-${DISTRO_VERSION}" -RDEPENDS = "${TOOLCHAIN_HOST_TASK}" +RDEPENDS_${PN} = "${TOOLCHAIN_HOST_TASK}" EXCLUDE_FROM_WORLD = "1"
Signature · 1 line
1.7.9.5
Quoted 2 lines · Robert Yang
The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to RRECOMMENDS
Why?
PACKAGES = "" for these recipes so there is no ${PN} package to add these dependencies too?
I suspect this is from your image class modifications but did you test without those modifications?
Cheers,
Richard
Quoted 8 lines · Richard Purdie
Quoted 2 lines · Robert Yang
The "RDEPENDS =" should be replaced by RDEPENDS_${PN}, the similar to RRECOMMENDS
Why?
PACKAGES = "" for these recipes so there is no ${PN} package to add these dependencies too?
Ah, right, we should not set this if no PACKAGES.
Quoted 3 lines
I suspect this is from your image class modifications but did you test without those modifications?
Yes, it is from the image class modifications. I tested it separately, the bitbake core-image-minimal buildtools-tarball were the same w/o these changes, I don't know why it works after your explanations, I tried to print the self.rdepends_pkg from cache.py after patched:
self.rdepends_pkg: {'core-image-minimal': ['packagegroup-core-boot', 'run-postinsts', 'run-postinsts']}
maybe that's why it works.
Anyway, we should drop this since PACKAGES = "".
// Robert
Quoted 7 lines
Cheers,
Richard