xen: Introduce 'xen_nopv' to disable PV extensions for HVM guests.
Subsystems (3)
PATCH 1/1 xen: Introduce 'xen_nopv' to disable PV extensions for HVM guests.
From: Konrad Rzeszutek Wilk <[email protected]>
By default when CONFIG_XEN and CONFIG_XEN_PVHVM kernels are run, they will enable the PV extensions (drivers, interrupts, timers, etc) - which is perfect.
However, in some cases (kexec not fully wokring, benchmarking) we want to disable Xen PV extensions. As such introduce the 'xen_nopv' parameter that will do it.
--- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten.c | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)
Documentation/kernel-parameters.txt +4 -0
@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]
arch/x86/xen/enlighten.c +14 -0
@@ -1930,10 +1930,21 @@ static void __init xen_hvm_guest_init(void)#endif } +static bool off = false; +static __init int xen_parse_nopv (char *arg) +{ + off = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) {uint32_t eax, ebx, ecx, edx, base; +if (off) +return 0 ; +if (xen_pv_domain ())return 0 ;
@@ -1953,6 +1964,9 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (off) +return false; +if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Signature · 1 line
1.7.7.6
Boris Ostrovsky
reviewerQuoted 36 lines · On 07/08/2014 02:48 PM, [email protected] wrote:
From: Konrad Rzeszutek Wilk <[email protected]>
By default when
CONFIG_XENandCONFIG_XEN_PVHVMkernels are run, they will enable the PV extensions (drivers, interrupts, timers, etc) - which is perfect.However, in some cases (kexec not fully wokring, benchmarking) we want to disable Xen PV extensions. As such introduce the '
xen_nopv' parameter that will do it.Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten.c | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)Documentation/kernel-parameters.txt +4
-0@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]arch/x86/xen/enlighten.c +0
-0
arch/x86/xen/enlighten.c static void __init xen_hvm_guest_init(void) · line 1933
Quoted 4 lines
arch/x86/xen/enlighten.c +1
-0@@ -1930,10 +1930,21 @@ static void __init xen_hvm_guest_init(void)#endif } +static bool off = false;
A more descriptive name would be better.
-boris
Quoted 27 lines
arch/x86/xen/enlighten.c +13
-0+static __init int xen_parse_nopv (char *arg) +{ + off = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) {uint32_t eax, ebx, ecx, edx, base; +if (off) +return 0 ; +if (xen_pv_domain ())return 0 ;@@ -1953,6 +1964,9 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (off) +return false; +if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Quoted 33 lines · Boris Ostrovsky
Quoted 32 lines · On 07/08/2014 02:48 PM, [email protected] wrote:
From: Konrad Rzeszutek Wilk <[email protected]>
By default when
CONFIG_XENandCONFIG_XEN_PVHVMkernels are run, they will enable the PV extensions (drivers, interrupts, timers, etc) - which is perfect.However, in some cases (kexec not fully wokring, benchmarking) we want to disable Xen PV extensions. As such introduce the '
xen_nopv' parameter that will do it.Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten.c | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)Documentation/kernel-parameters.txt +4
-0@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]arch/x86/xen/enlighten.c +0
-0
Quoted 8 lines
arch/x86/xen/enlighten.c static void __init xen_hvm_guest_init(void) · line 1932
Quoted 6 lines
arch/x86/xen/enlighten.c +1
-0@@ -1930,10 +1930,21 @@ static void __init xen_hvm_guest_init(void)#endif } +static bool off = false;A more descriptive name would be better.
disable_pv ?
disable?
xen_pvoff ?
ignore_xen ?
Quoted 28 lines
-boris
Quoted 24 lines
arch/x86/xen/enlighten.c +13
-0+static __init int xen_parse_nopv (char *arg) +{ + off = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) {uint32_t eax, ebx, ecx, edx, base; +if (off) +return 0 ; +if (xen_pv_domain ())return 0 ;@@ -1953,6 +1964,9 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (off) +return false; +if (xen_pv_domain ())return false;if (!xen_hvm_domain ())
Boris Ostrovsky
reviewerQuoted 41 lines · Konrad Rzeszutek Wilk
Quoted 32 lines · Boris Ostrovsky
Quoted 31 lines · On 07/08/2014 02:48 PM, [email protected] wrote:
From: Konrad Rzeszutek Wilk <[email protected]>
By default when
CONFIG_XENandCONFIG_XEN_PVHVMkernels are run, they will enable the PV extensions (drivers, interrupts, timers, etc) - which is perfect.However, in some cases (kexec not fully wokring, benchmarking) we want to disable Xen PV extensions. As such introduce the '
xen_nopv' parameter that will do it.Signed-off-by Konrad Rzeszutek Wilk <[email protected]>--- Documentation/kernel-parameters.txt | 4 ++++ arch/x86/xen/enlighten.c | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 0 deletions(-)Documentation/kernel-parameters.txt +4
-0@@ -3691,6 +3691,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted. Disables the ticketlock slowpath using Xen PV optimizations. + xen_nopv [X86,XEN] + Disables the PV optimizations forcing the guest to run + as generic HVM guest with no PV drivers. + xirc2ps_cs= [NET,PCMCIA] Format: <irq>,<irq_mask>,<io>,<full_duplex>,<do_sound>,<lockup_hack>[,<irq2>[,<irq3>[,<irq4>]]]arch/x86/xen/enlighten.c +0
-0Quoted 8 lines
arch/x86/xen/enlighten.c static void __init xen_hvm_guest_init(void) · line 1932
Quoted 7 lines
index e220197..fec8963 100644
arch/x86/xen/enlighten.c +1
-0@@ -1930,10 +1930,21 @@ static void __init xen_hvm_guest_init(void)#endif } +static bool off = false;A more descriptive name would be better.
Quoted 7 lines
disable_pv?disable?
xen_pvoff?
ignore_xen?
How about xen_nopv, to be consistent with the boot option.
-boris
Quoted 28 lines
Quoted 28 lines
-boris
Quoted 24 lines
arch/x86/xen/enlighten.c +13
-0+static __init int xen_parse_nopv (char *arg) +{ + off = true; +return 0 ; +} +early_param ("xen_nopv" , xen_parse_nopv); +static uint32_t __init xen_hvm_platform (void ) {uint32_t eax, ebx, ecx, edx, base; +if (off) +return 0 ; +if (xen_pv_domain ())return 0 ;@@ -1953,6 +1964,9 @@ static uint32_t __init xen_hvm_platform(void)bool xen_hvm_need_lapic (void ) { +if (off) +return false; +if (xen_pv_domain ())return false;if (!xen_hvm_domain ())