Skip to contentSkip to conversation

cpufreq: Fix latency for cpufreq_info

PATCH In review Nicholas Krause 3 participants 4 messages Jul 14, 2014 – Jul 25, 2014 CPU frequency scaling framework

lore
Share & tools
lore

Nicholas Krause

author
#0 lore raw

PATCH 1/1 cpufreq: Fix latency for cpufreq_info

This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency.

Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pxa2xx-cpufreq.c +1 -1
index e24269a..e08bb98 100644
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
 	init_sdram_rows();
 
 	/* set default policy and cpuinfo */
-	policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+	policy->cpuinfo.transition_latency = 1000000;
 
 	/* Generate pxa25x the run cpufreq_frequency_table struct */
 	for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Nicholas Krause

This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency.

Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pxa2xx-cpufreq.c +0 -0
index e24269a..e08bb98 100644

drivers/cpufreq/pxa2xx-cpufreq.c static int pxa_cpufreq_init(struct cpufreq_policy *policy) · line 378

Quoted 8 lines
drivers/cpufreq/pxa2xx-cpufreq.c +1 -1
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
        init_sdram_rows();
 
        /* set default policy and cpuinfo */
-       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+       policy->cpuinfo.transition_latency = 1000000;
 
        /* Generate pxa25x the run cpufreq_frequency_table struct */
        for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Acked-by Viresh Kumar <[email protected]>
#2 lore raw

Viresh,
Be careful when you ACK Nick's patches. He has confessed he has no idea how to build test a kernel. His patches are NOT AT ALL build tested. And some of his patches are being reverted for causing problems in build and all. He looks for FIXME and removes/edits the code as per the comments. Just be careful.

Quoted 30 lines · Viresh Kumar
Quoted 14 lines · Nicholas Krause

This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency.

Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pxa2xx-cpufreq.c +0 -0
index e24269a..e08bb98 100644

drivers/cpufreq/pxa2xx-cpufreq.c static int pxa_cpufreq_init(struct cpufreq_policy *policy) · line 378

Quoted 8 lines
drivers/cpufreq/pxa2xx-cpufreq.c +1 -1
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
        init_sdram_rows();
 
        /* set default policy and cpuinfo */
-       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+       policy->cpuinfo.transition_latency = 1000000;
 
        /* Generate pxa25x the run cpufreq_frequency_table struct */
        for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Acked-by Viresh Kumar <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
Thanks and Regards
Pramod
author
#3 lore raw
Quoted 41 lines · pramod gurav

Viresh,
Be careful when you ACK Nick's patches. He has confessed he has no idea how to build test a kernel. His patches are NOT AT ALL build tested. And some of his patches are being reverted for causing problems in build and all. He looks for FIXME and removes/edits the code as per the comments. Just be careful.

Quoted 25 lines · Viresh Kumar
Quoted 14 lines · Nicholas Krause

This fixes the latency for the cpufreq policy to 1 million nanoseconds that calls the function pxa_cpu_init for the member of the structure called cpuinfo.transition_latency.

Signed-off-by Nicholas Krause <[email protected]>
---
 drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/pxa2xx-cpufreq.c +0 -0
index e24269a..e08bb98 100644

drivers/cpufreq/pxa2xx-cpufreq.c static int pxa_cpufreq_init(struct cpufreq_policy *policy) · line 378

Quoted 8 lines
drivers/cpufreq/pxa2xx-cpufreq.c +1 -1
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
        init_sdram_rows();
 
        /* set default policy and cpuinfo */
-       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+       policy->cpuinfo.transition_latency = 1000000;
 
        /* Generate pxa25x the run cpufreq_frequency_table struct */
        for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Acked-by Viresh Kumar <[email protected]>
Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Quoted 3 lines

--
Thanks and Regards
Pramod

Pramod,
I learned how to do it today and Viresh checked this and it didn't build so I sent him another fixed patch :). I am learning fast now and known how to properly test my patches now.
Nick