Skip to contentSkip to conversation

Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const

PATCH New Adithya Krishnamurthy 1 participant 3 messages Jul 15, 2014 Staging

lore
Share & tools
lore

Adithya Krishnamurthy

author
#0 lore raw

PATCH 1/1 Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const

From: Adithya Krishnamurthy <[email protected]>

Fixed checkpatch "WARNING: char * array declaration might be better as static const"

Signed-off-by Adithya Krishnamurthy <[email protected]>
---
 drivers/staging/tidspbridge/core/io_sm.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/tidspbridge/core/io_sm.c +3 -2
index 42f94e1..24bd962 100644
@@ -1910,10 +1910,11 @@ int dump_dsp_stack(struct bridge_dev_context *bridge_context)
 	u32 offset_output;
 	u32 total_size;
 	u32 poll_cnt;
-	const char *dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
+	static const char * const dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
 				"IRP", "NRP", "AMR", "SSR",
 				"ILC", "RILC", "IER", "CSR"};
-	const char *exec_ctxt[] = {"Task", "SWI", "HWI", "Unknown"};
+	static const char * const exec_ctxt[] = {"Task", "SWI", "HWI",
+						"Unknown"};
 	struct bridge_drv_interface *intf_fxns;
 	struct dev_object *dev_object = bridge_context->dev_obj;
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline

From: Adithya Krishnamurthy <[email protected]>

Fixed checkpatch "WARNING: unnecessary whitespace before a quoted newline"

Signed-off-by Adithya Krishnamurthy <[email protected]>
---
 drivers/staging/tidspbridge/core/tiomap3430.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/tidspbridge/core/tiomap3430.c +1 -1
index f63dd8f..0559ab6 100644
@@ -536,7 +536,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
 		if ((unsigned int *)ul_dsp_clk_addr != NULL) {
 			/* Get the clock rate */
 			ul_dsp_clk_rate = dsp_clk_get_iva2_rate();
-			dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x \n",
+			dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x\n",
 				__func__, ul_dsp_clk_rate);
 			(void)bridge_brd_write(dev_context,
 					       (u8 *) &ul_dsp_clk_rate,
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 1/1 Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses

From: Adithya Krishnamurthy <[email protected]>

Fixed checkpatch "WARNING: Unnecessary parentheses"

Signed-off-by Adithya Krishnamurthy <[email protected]>
---
 drivers/staging/tidspbridge/dynload/cload.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/tidspbridge/dynload/cload.c +1 -1
index 83f2106..b306349 100644
@@ -376,7 +376,7 @@ void dload_headers(struct dload_state *dlthis)
 		return;
 	}
 	/* Check for valid file format */
-	if ((dlthis->dfile_hdr.df_doff_version != DOFF0)) {
+	if (dlthis->dfile_hdr.df_doff_version != DOFF0) {
 		dload_error(dlthis, "Bad DOFF version 0x%x",
 			    dlthis->dfile_hdr.df_doff_version);
 		return;
Signature · 1 line
1.7.9.5