Skip to contentSkip to conversation

Staging: commedi: 8253.h: style issue fixed

PATCH In review Sam Asadi 2 participants 2 messages Jul 15, 2014 Staging

lore
Share & tools
lore

Sam Asadi

author
#0 lore raw

PATCH 95/95 Staging: commedi: 8253.h: style issue fixed

a revision to the file that previously had several style issues. It's clean now.

---
 drivers/staging/comedi/drivers/8253.h |    1 +
 1 file changed, 1 insertion(+)
drivers/staging/comedi/drivers/8253.h +1 -0
index 31d0fc9..d320027 100644
@@ -282,6 +282,7 @@ static inline void i8254_mm_write(void __iomem *base_address,
  * OR'ed with:
  *   I8254_BCD, I8254_BINARY
  */
+
 static inline int i8254_set_mode(unsigned long base_address,
 				 unsigned int regshift,
 				 unsigned int counter_number, unsigned int mode)
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

Patch 95/95? Really? Where are the other 94 patches in this series?

:(

Please look at what you are doing here, does it make sense?

Quoted 2 lines · Sam Asadi

a revision to the file that previously had several style issues. It's clean now.

What does this mean? What did you do in this changeset? Describe _why_ you made the change, not the result of what happened _after_ this patch is applied.

Please step back, take a day or two to regroup, and revisit what you are trying to do here. You are not sending out patches correctly at all. Please read some tutorials on how to do this properly (try kernelnewbies.org) and then do a dry-run by sending the patches to yourself.

After that looks correct, then consider sending them to the kernel developers.

But again, wait, don't rush, there's no deadline here.

greg k-h