Skip to contentSkip to conversation

Staging: comedi: adv_pci1710: a line over 80 fixed

PATCH New Sam Asadi 1 participant 7 messages Jul 20, 2014 Staging

lore
Share & tools
lore

Sam Asadi

author
#0 lore raw

PATCH 1/7 Staging: comedi: adv_pci1710: a line over 80 fixed

A 'line over 80' issue fixed, by removing comment to previous line. And also, by this, 'a blank line' isssue resolved.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -2
index 602b7a1..a15a552 100644
@@ -722,8 +722,8 @@ static int pci171x_ai_cancel(struct comedi_device *dev,
 	default:
 		devpriv->CntrlReg &= Control_CNT0;
 		devpriv->CntrlReg |= Control_SW;
-
-		outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);	/*  reset any operations */
+		/* reset any operations */
+		outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
 		pci171x_start_pacer(dev, false);
 		outb(0, dev->iobase + PCI171x_CLRFIFO);
 		outb(0, dev->iobase + PCI171x_CLRINT);
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/7 Staging: comedi: adv_pci1710: a line over 80 issue fixed

By removing a comment to previous line, 'line over 80' issue fixed.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -1
index a15a552..b4b8f85 100644
@@ -1049,7 +1049,8 @@ static int pci171x_reset(struct comedi_device *dev)
 	struct pci1710_private *devpriv = dev->private;
 
 	outw(0x30, dev->iobase + PCI171x_CNTCTRL);
-	devpriv->CntrlReg = Control_SW | Control_CNT0;	/*  Software trigger, CNT0=external */
+	/* Software trigger, CNT0=external */
+	devpriv->CntrlReg = Control_SW | Control_CNT0;
 	outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);	/*  reset any operations */
 	outb(0, dev->iobase + PCI171x_CLRFIFO);	/*  clear FIFO */
 	outb(0, dev->iobase + PCI171x_CLRINT);	/*  clear INT request */
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 3/7 Staging: comedi: adv_pci1710: A line style issue fixed

In reply to Sam Asadi

A 'line over 80 characters' fixed by removing over-lined comment to previous line.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -1
index b4b8f85..887aa7e 100644
@@ -1051,7 +1051,8 @@ static int pci171x_reset(struct comedi_device *dev)
 	outw(0x30, dev->iobase + PCI171x_CNTCTRL);
 	/* Software trigger, CNT0=external */
 	devpriv->CntrlReg = Control_SW | Control_CNT0;
-	outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);	/*  reset any operations */
+	/* reset any operations */
+	outw(devpriv->CntrlReg, dev->iobase + PCI171x_CONTROL);
 	outb(0, dev->iobase + PCI171x_CLRFIFO);	/*  clear FIFO */
 	outb(0, dev->iobase + PCI171x_CLRINT);	/*  clear INT request */
 	pci171x_start_pacer(dev, false);
Signature · 1 line
1.7.10.4
author
#3 lore raw

PATCH 4/7 Staging: comedi: adv_pci1710: a line over 80 characters fixed

In reply to Sam Asadi

An issue in 'line over 80 characters' fixed and over-lined comment removed to the previous line.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -1
index 887aa7e..bc73141 100644
@@ -1058,7 +1058,8 @@ static int pci171x_reset(struct comedi_device *dev)
 	pci171x_start_pacer(dev, false);
 	devpriv->da_ranges = 0;
 	if (this_board->n_aochan) {
-		outb(devpriv->da_ranges, dev->iobase + PCI171x_DAREF);	/*  set DACs to 0..5V */
+		/* set DACs to 0..5V */
+		outb(devpriv->da_ranges, dev->iobase + PCI171x_DAREF);
 		outw(0, dev->iobase + PCI171x_DA1);	/*  set DA outputs to 0V */
 		devpriv->ao_data[0] = 0x0000;
 		if (this_board->n_aochan > 1) {
Signature · 1 line
1.7.10.4
author
#4 lore raw

PATCH 5/7 Staging: comedi: adv_pci1710: a line over 80 characters resolved

In reply to Sam Asadi

An issue in 'line over 80 characters' fixed by taking back over-lined comment a few characters.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/adv_pci1710.c +1 -1
index bc73141..7ccd41b 100644
@@ -1060,7 +1060,7 @@ static int pci171x_reset(struct comedi_device *dev)
 	if (this_board->n_aochan) {
 		/* set DACs to 0..5V */
 		outb(devpriv->da_ranges, dev->iobase + PCI171x_DAREF);
-		outw(0, dev->iobase + PCI171x_DA1);	/*  set DA outputs to 0V */
+		outw(0, dev->iobase + PCI171x_DA1); /* set DA outputs to 0V */
 		devpriv->ao_data[0] = 0x0000;
 		if (this_board->n_aochan > 1) {
 			outw(0, dev->iobase + PCI171x_DA2);
Signature · 1 line
1.7.10.4
author
#5 lore raw

PATCH 6/7 Staging: comedi: adv_pci1710: an issue in line over 80 fixed

In reply to Sam Asadi

An issue in 'line over 80 characters' fixed by removing over-lined comment to the previous line.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -2
index 7ccd41b..6bd5015 100644
@@ -1080,8 +1080,8 @@ static int pci171x_reset(struct comedi_device *dev)
 static int pci1720_reset(struct comedi_device *dev)
 {
 	struct pci1710_private *devpriv = dev->private;
-
-	outb(Syncont_SC0, dev->iobase + PCI1720_SYNCONT);	/*  set synchronous output mode */
+	/* set synchronous output mode */
+	outb(Syncont_SC0, dev->iobase + PCI1720_SYNCONT);
 	devpriv->da_ranges = 0xAA;
 	outb(devpriv->da_ranges, dev->iobase + PCI1720_RANGE);	/*  set all ranges to +/-5V */
 	outw(0x0800, dev->iobase + PCI1720_DA0);	/*  set outputs to 0V */
Signature · 1 line
1.7.10.4
author
#6 lore raw

PATCH 7/7 Staging: comedi: adv_pci1710: an issue in code style fixed

In reply to Sam Asadi

An issue in 'line over 80 characters' fixed by removing over-lined comment to the previous line.

---
 drivers/staging/comedi/drivers/adv_pci1710.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/adv_pci1710.c +2 -1
index 6bd5015..e19ab95 100644
@@ -1083,7 +1083,8 @@ static int pci1720_reset(struct comedi_device *dev)
 	/* set synchronous output mode */
 	outb(Syncont_SC0, dev->iobase + PCI1720_SYNCONT);
 	devpriv->da_ranges = 0xAA;
-	outb(devpriv->da_ranges, dev->iobase + PCI1720_RANGE);	/*  set all ranges to +/-5V */
+	/* set all ranges to +/-5V */
+	outb(devpriv->da_ranges, dev->iobase + PCI1720_RANGE);
 	outw(0x0800, dev->iobase + PCI1720_DA0);	/*  set outputs to 0V */
 	outw(0x0800, dev->iobase + PCI1720_DA1);
 	outw(0x0800, dev->iobase + PCI1720_DA2);
Signature · 1 line
1.7.10.4