Skip to contentSkip to conversation

ALSA: hda - add PCI IDs for Intel Braswell

PATCH In review [email protected] 2 participants 4 messages Jul 25, 2014 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ALSA: hda - add PCI IDs for Intel Braswell

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +3 -0
index 387fc73..5db1948 100644
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/2 ALSA: hda - add codec ID for Braswell display audio codec

From: Libin Yang <[email protected]>

This patch adds codec ID (0x80862883) and module alias for Braswell display codec.

---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
index a21090b..36badba 100644
@@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x80862808, .name = "Broadwell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862880, .name = "CedarTrail HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x80862882, .name = "Valleyview2 HDMI",	.patch = patch_generic_hdmi },
+{ .id = 0x80862883, .name = "Braswell HDMI",	.patch = patch_generic_hdmi },
 { .id = 0x808629fb, .name = "Crestline HDMI",	.patch = patch_generic_hdmi },
 {} /* terminator */
 };
@@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807");
 MODULE_ALIAS("snd-hda-codec-id:80862808");
 MODULE_ALIAS("snd-hda-codec-id:80862880");
 MODULE_ALIAS("snd-hda-codec-id:80862882");
+MODULE_ALIAS("snd-hda-codec-id:80862883");
 MODULE_ALIAS("snd-hda-codec-id:808629fb");
 
 MODULE_LICENSE("GPL");
Signature · 1 line
1.9.1
#2 lore raw
In reply to [email protected]

At Fri, 25 Jul 2014 16:19:15 +0800,

Quoted 4 lines · [email protected] wrote:

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

So, you confirmed that runtime PM works? Also, the device doesn't need the buffer size alignment unlike Haswell & co? If these were already confirmed, describe in the patch description (also mention that it's an HDMI controller).

Takashi

Quoted 23 lines
---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +3 -0
index 387fc73..5db1948 100644
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
Signature · 1 line
1.9.1
#3 lore raw

Hi Takashi,

Please see my comments below

Quoted 10 lines

-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Friday, July 25, 2014 4:31 PM
To: Yang, Libin
Cc: [email protected]; Lin, Mengdong
Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell

At Fri, 25 Jul 2014 16:19:15 +0800,

Quoted 1 line · [email protected] wrote:
Quoted 9 lines
Quoted 3 lines

From: Libin Yang <[email protected]>

Add HD Audio Device PCI ID for the Intel Braswell platform.

So, you confirmed that runtime PM works? Also, the device doesn't need the buffer size alignment unlike Haswell & co? If these were already confirmed, describe in the patch description (also mention that it's an HDMI controller).

Yes, I have tested the runtime PM, and it works. Besides, I think you are right, if the HDMI codec doesn't support, we should leave it to codec to decide not to use the runtime PM.

For the buffer size alignment, I will confirm with our HW team. Thanks for reminding me.

I will add the comments in the patch description.

BTW: this is not a HDMI audio controller. The HDMI codec and analog codec will both connect to the controller. It's not embedded into the HDMI controller.

Quoted 27 lines

Takashi

Quoted 11 lines
---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)
sound/pci/hda/hda_intel.c +0 -0
index 387fc73..5db1948 100644

sound/pci/hda/hda_intel.c static const struct pci_device_id azx_ids[] = { · line 2019

Quoted 3 lines
sound/pci/hda/hda_intel.c +0 -0
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
 	/* BayTrail */
 	{ PCI_DEVICE(0x8086, 0x0f04),
 	  .driver_data = AZX_DRIVER_PCH |

AZX_DCAPS_INTEL_PCH_NOPM },

Quoted 9 lines
sound/pci/hda/hda_intel.c +3 -1
+	/* Braswell */
+	{ PCI_DEVICE(0x8086, 0x2284),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
 	/* ICH */
 	{ PCI_DEVICE(0x8086, 0x2668),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
--

1.9.1