drm/panel: simple: Use devm_gpiod_get_optional()
Subsystems (3)
PATCH 1/1 drm/panel: simple: Use devm_gpiod_get_optional()
Use the new devm_gpiod_get_optional() to simplify the probe code.
Signed-off-by Alexandre Courbot <[email protected]>
--- drivers/gpu/drm/panel/panel-simple.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +5 -7
@@ -185,16 +185,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)if (IS_ERR (panel->supply))return PTR_ERR (panel->supply); - panel->enable_gpio =devm_gpiod_get (dev,"enable" ); + panel->enable_gpio =devm_gpiod_get_optional (dev,"enable" );if (IS_ERR (panel->enable_gpio)) { err =PTR_ERR (panel->enable_gpio); -if (err != -ENOENT ) { -dev_err (dev,"failed to request GPIO: %d\n" , err); -return err; - } +dev_err (dev,"failed to request GPIO: %d\n" , err); +return err; + } - panel->enable_gpio =NULL ; - }else { +if (panel->enable_gpio) { err =gpiod_direction_output (panel->enable_gpio,0 );if (err <0 ) {dev_err (dev,"failed to setup GPIO: %d\n" , err);
Signature · 1 line
2.0.2
Ping, Thierry?
Quoted 36 lines · Alexandre Courbot
Use the new
devm_gpiod_get_optional()to simplify the probe code.Signed-off-by Alexandre Courbot <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)drivers/gpu/drm/panel/panel-simple.c +5
-8@@ -185,16 +185,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)if (IS_ERR (panel->supply))return PTR_ERR (panel->supply); - panel->enable_gpio =devm_gpiod_get (dev,"enable" ); + panel->enable_gpio =devm_gpiod_get_optional (dev,"enable" );if (IS_ERR (panel->enable_gpio)) { err =PTR_ERR (panel->enable_gpio); -if (err != -ENOENT ) { -dev_err (dev,"failed to request GPIO: %d\n" , err); -return err; - } +dev_err (dev,"failed to request GPIO: %d\n" , err); +return err; + } - panel->enable_gpio =NULL ; - }else { +if (panel->enable_gpio) { err =gpiod_direction_output (panel->enable_gpio,0 );if (err <0 ) {dev_err (dev,"failed to setup GPIO: %d\n" , err); --2.0.2
Quoted 6 lines · Alexandre Courbot
Use the new
devm_gpiod_get_optional()to simplify the probe code.Signed-off-by Alexandre Courbot <[email protected]>--- drivers/gpu/drm/panel/panel-simple.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
For some reason I thought I had already applied this, but apparently I was mistaken. Applied now, thanks.
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel