Skip to contentSkip to conversation

Staging: android: sw_sync.c: fix missing blank line after declaration

PATCH In review Murilo Opsfelder Araujo 4 participants 6 messages Jul 28, 2014 – Jul 31, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: android: sw_sync.c: fix missing blank line after declaration

Fix coding style issue.

---
 drivers/staging/android/sw_sync.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/android/sw_sync.c +2 -0
index a76db3f..863d4b1 100644
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 20 lines · Murilo Opsfelder Araujo

Fix coding style issue.

---
 drivers/staging/android/sw_sync.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/android/sw_sync.c +1 -0
index a76db3f..863d4b1 100644
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 

drivers/staging/android/sw_sync.c static int sw_sync_open(struct inode *inode, struct file *file) · line 163

Quoted 7 lines
drivers/staging/android/sw_sync.c +1 -0
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }

Does not apply to my tree at all :(

#2 lore raw
Quoted 1 line · Greg KH

Does not apply to my tree at all :(

I was using linux-next. No checkpatch.pl warnings for sw_sync.c in staging-next.

Signature · 1 line
Murilo
#3 lore raw
In reply to Murilo Opsfelder Araujo

Hi,

Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a écrit :

Quoted 3 lines

Fix coding style issue.

Is this some kind of game ?

The *same* patch was sent three times from three different email addresses:

http://lkml.kernel.org/r/[email protected]

From: Nicholas Krause <[email protected]>
Date: Wed, 23 Jul 2014 22:53:23 -0400
Message-Id: <[email protected]>
Subject: [PATCH] staging: Add blank lines in sw_sync.c

http://lkml.kernel.org/r/[email protected]

From: Adrian Remonda <[email protected]>
Date: Mon, 28 Jul 2014 23:07:40 +0200
Message-Id: <[email protected]>
Subject: [PATCH] Staging: android: Missing a blank line after declarations
in sw_sync.c This is a patch to the sw_sync.c file that fixes up a missing a blank warning found by the checkpatch.pl tool

http://lkml.kernel.org/r/[email protected]

From: Murilo Opsfelder Araujo <[email protected]>
Date: Mon, 28 Jul 2014 19:38:23 -0300
Message-Id: <[email protected]>
Subject: [PATCH] Staging: android: sw_sync.c: fix missing blank line after
declaration

Quoted 17 lines
---
 drivers/staging/android/sw_sync.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/staging/android/sw_sync.c +1 -0
index a76db3f..863d4b1 100644
@@ -97,6 +97,7 @@ static void sw_sync_pt_value_str(struct sync_pt *sync_pt,
 				       char *str, int size)
 {
 	struct sw_sync_pt *pt = (struct sw_sync_pt *)sync_pt;
+
 	snprintf(str, size, "%d", pt->value);
 }
 

drivers/staging/android/sw_sync.c static int sw_sync_open(struct inode *inode, struct file *file) · line 163

Quoted 7 lines
drivers/staging/android/sw_sync.c +1 -0
@@ -156,6 +157,7 @@ static int sw_sync_open(struct inode *inode, struct file *file)
 static int sw_sync_release(struct inode *inode, struct file *file)
 {
 	struct sw_sync_timeline *obj = file->private_data;
+
 	sync_timeline_destroy(&obj->obj);
 	return 0;
 }

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA
#4 lore raw
Quoted 4 lines · Yann Droneaud

Hi,

Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a écrit :

Quoted 8 lines
Quoted 3 lines

Fix coding style issue.

Is this some kind of game ?

The *same* patch was sent three times from three different email addresses:

This is just normal.

Once I saw 7 people send the same patch. I was almost the third person to send a fix last week. I had the patch prepared to send, but I happened to look at my inbox before sending.

regards,
dan carpenter

#5 lore raw

Hi,

Quoted 9 lines · Dan Carpenter
Quoted 8 lines · Yann Droneaud

Le lundi 28 juillet 2014 à 19:38 -0300, Murilo Opsfelder Araujo a écrit :

Quoted 3 lines

Fix coding style issue.

Is this some kind of game ?

Quoted 9 lines
Quoted 2 lines

The *same* patch was sent three times from three different email addresses:

This is just normal.

Once I saw 7 people send the same patch. I was almost the third person to send a fix last week. I had the patch prepared to send, but I happened to look at my inbox before sending.

As the initial patch was sent by someone who has some trouble with the way things are done here [1], it raise some, probably false, alarms.

[1] "Help with flame wars"
http://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-July/011394.html

Regards.

Signature · 2 lines
Yann Droneaud
OPTEYA