Add patch 0001-Typo-in-fuser-makes-M-on-all-the-time.patch

PATCH In review Patrice B 4 participants 6 messages Jul 30, 2014

Share & tools

Patrice B

author

2014-07-30 05:54 UTC #0 lore raw

PATCH 1/1 Add patch 0001-Typo-in-fuser-makes-M-on-all-the-time.patch

This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...

Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>

---
 ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
 meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
 2 files changed, 46 insertions(+)
 create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +44 -0

new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001
+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>
+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++	* Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+ 	* Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+ 		usage(_("No process specification given"));
+ 
+ 	/* Check if -M flag was used and if so check mounts */
+-	if (opts * OPT_ISMOUNTPOINT) {
++	if (opts & OPT_ISMOUNTPOINT) {
+ 	    check_mountpoints(&mounts, &names_head, &names_tail);
+ 	}
+ 
+-- 
+1.8.4.2
+

meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0

index 22f65c5..9f328bb 100644
@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
 SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
 SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"

Signature · 1 line

1.8.4.2

Khem Raj

2014-07-30 06:05 UTC #1 lore raw

Quoted 5 lines · Patrice B

This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...
Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>

why spaces in email address ?

Quoted 62 lines

---
 ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
 meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
 2 files changed, 46 insertions(+)
 create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +44 -0

new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001
+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>
+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++      * Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+       * Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+               usage(_("No process specification given"));
+
+       /* Check if -M flag was used and if so check mounts */
+-      if (opts * OPT_ISMOUNTPOINT) {
++      if (opts & OPT_ISMOUNTPOINT) {
+           check_mountpoints(&mounts, &names_head, &names_tail);
+       }
+
+--
+1.8.4.2
+

meta/recipes-extended/psmisc/psmisc_22.21.bb +0 -0

index 22f65c5..9f328bb 100644

meta/recipes-extended/psmisc/psmisc_22.21.bb LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" · line 8

Quoted 5 lines

meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0

@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
 SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
 SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"

Move SRC_URI += above SRC_URI[md5sum]

Patrice B

author

2014-07-30 06:16 UTC #2 lore raw

I'm not an expert in patch submission. Regarding the previous patch proposal in this list, I thought it was what should be done ?

(sorry for sending twice, I forgot to copy the list)

Quoted 79 lines · Khem Raj

Quoted 5 lines · Patrice B

This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...
Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>

why spaces in email address ?

Quoted 62 lines

---
 ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
 meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
 2 files changed, 46 insertions(+)
 create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +44 -0

new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001
+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>
+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++      * Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+       * Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+               usage(_("No process specification given"));
+
+       /* Check if -M flag was used and if so check mounts */
+-      if (opts * OPT_ISMOUNTPOINT) {
++      if (opts & OPT_ISMOUNTPOINT) {
+           check_mountpoints(&mounts, &names_head, &names_tail);
+       }
+
+--
+1.8.4.2
+

meta/recipes-extended/psmisc/psmisc_22.21.bb +0 -0

index 22f65c5..9f328bb 100644

meta/recipes-extended/psmisc/psmisc_22.21.bb LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" · line 8

Quoted 5 lines

meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0

@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
 SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
 SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"

Move SRC_URI += above SRC_URI[md5sum]

Saul Wold

2014-07-30 07:36 UTC #3 lore raw

In reply to Patrice B

This patch should be sent to openembedded-core@

Quoted 19 lines · Patrice B

This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...
Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>
---
  ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
  meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
  2 files changed, 46 insertions(+)
create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +1 -0
new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch line 11

Quoted 10 lines

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +10 -0

+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>

This needs an Upstream-Status: Backport?

Quoted 44 lines

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +33 -0

+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++	* Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+ 	* Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+ 		usage(_("No process specification given"));
+
+ 	/* Check if -M flag was used and if so check mounts */
+-	if (opts * OPT_ISMOUNTPOINT) {
++	if (opts & OPT_ISMOUNTPOINT) {
+ 	    check_mountpoints(&mounts, &names_head, &names_tail);
+ 	}
+
+--
+1.8.4.2
+

meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0

index 22f65c5..9f328bb 100644
@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
  SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
  SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"

Martin Jansa

2014-07-30 08:13 UTC #4 lore raw

Quoted 2 lines · Saul Wold

This patch should be sent to openembedded-core@

and with better subject, something like

psmisc: fix fuser -M

Quoted 81 lines · Patrice B

Quoted 19 lines

This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...
Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>
---
  ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
  meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
  2 files changed, 46 insertions(+)
create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +1 -0
new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch line 11

Quoted 10 lines

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +10 -0

+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>

This needs an Upstream-Status: Backport?

Quoted 44 lines

meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +33 -0

+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++	* Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+ 	* Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+ 		usage(_("No process specification given"));
+
+ 	/* Check if -M flag was used and if so check mounts */
+-	if (opts * OPT_ISMOUNTPOINT) {
++	if (opts & OPT_ISMOUNTPOINT) {
+ 	    check_mountpoints(&mounts, &names_head, &names_tail);
+ 	}
+
+--
+1.8.4.2
+

meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0

index 22f65c5..9f328bb 100644
@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
  SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
  SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"

Signature · 4 lines

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Signature · 1 line

Martin 'JaMa' Jansa     jabber: [email protected]

Patrice B

author

2014-07-30 12:58 UTC #5 lore raw

Thanks for your advices. I tried to improve my patch and submitted it to openembedded-core list:

http://lists.openembedded.org/pipermail/openembedded-core/2014-July/095107.html

Regards.

Patrice

Quoted 90 lines · Martin Jansa

Quoted 2 lines · Saul Wold
This patch should be sent to openembedded-core@
and with better subject, something like
psmisc: fix fuser -M
Quoted 81 lines · Patrice B
Quoted 19 lines
This patch fixes a major bug in fuser that makes it behave as if -M option is always used ( http://bugs.debian.org/740275 ). Hoping the patches is correctly done...
Signed-off-by Patrice Bouchand <pbfwdlist at gmail.com>
---
  ...001-Typo-in-fuser-makes-M-on-all-the-time.patch | 44 ++++++++++++++++++++++
  meta/recipes-extended/psmisc/psmisc_22.21.bb       |  2 +
  2 files changed, 46 insertions(+)
create mode 100644 meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +1 -0
new file mode 100644
index 0000000..3a4c9a9
@@ -0,0 +1,44 @@
+From 3638cc55b4d08851faba46635d737b24d016665b Mon Sep 17 00:00:00 2001
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch line 11
Quoted 10 lines
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +10 -0
+From: Brad Jorsch <[email protected]>
+Date: Fri, 28 Feb 2014 21:55:02 +1100
+Subject: [PATCH] Typo in fuser makes -M on all the time
+
+Brad found that fuser had the -M option on all the time.
+A simple but significant typo caused this, thanks the the patch.
+
+Bug-Debian: http://bugs.debian.org/740275
+
+Signed-off-by: Craig Small <[email protected]>
This needs an Upstream-Status: Backport?
Quoted 44 lines
meta/recipes-extended/psmisc/files/0001-Typo-in-fuser-makes-M-on-all-the-time.patch new file +33 -0
+---
+ ChangeLog   | 4 ++++
+ src/fuser.c | 2 +-
+ 2 files changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/ChangeLog b/ChangeLog
+index fd1cccf..e5f784c 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,7 @@
++Changes in 22.22
++================
++	* Fixed typo in fuser which has -M on Debian #740275
++
+ Changes in 22.21
+ ================
+ 	* Missing comma in fuser(1) added Debian #702391
+diff --git a/src/fuser.c b/src/fuser.c
+index b485f65..389b302 100644
+--- a/src/fuser.c
++++ b/src/fuser.c
+@@ -1174,7 +1174,7 @@ int main(int argc, char *argv[])
+ 		usage(_("No process specification given"));
+
+ 	/* Check if -M flag was used and if so check mounts */
+-	if (opts * OPT_ISMOUNTPOINT) {
++	if (opts & OPT_ISMOUNTPOINT) {
+ 	    check_mountpoints(&mounts, &names_head, &names_tail);
+ 	}
+
+--
+1.8.4.2
+
meta/recipes-extended/psmisc/psmisc_22.21.bb +2 -0
index 22f65c5..9f328bb 100644
@@ -4,3 +4,5 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
  SRC_URI[md5sum] = "935c0fd6eb208288262b385fa656f1bf"
  SRC_URI[sha256sum] = "97323cad619210845b696d7d722c383852b2acb5c49b5b0852c4f29c77a8145a"
+
+SRC_URI += "file://0001-Typo-in-fuser-makes-M-on-all-the-time.patch"
Signature · 4 lines
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky