Skip to contentSkip to conversation

ASoC: Intel: Don't issue ipc when processing response

PATCH Applied Jie Yang 2 participants 2 messages Aug 1, 2014

Subsystems (3)
lore
Share & tools
lore

Jie Yang

author
#0 lore raw

PATCH 1/1 ASoC: Intel: Don't issue ipc when processing response

From: Paweł Piskorski <[email protected]>

Make sure we dont issue IPC when we are processing a response.

---
 sound/soc/intel/sst-haswell-ipc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
sound/soc/intel/sst-haswell-ipc.c +3 -2
index 5a607ab..0fec686 100644
@@ -457,9 +457,10 @@ static void ipc_tx_msgs(struct kthread_work *work)
 		return;
 	}
 
-	/* if the DSP is busy we will TX messages after IRQ */
+	/* if the DSP is busy, we will TX messages after IRQ.
+	 * also postpone if we are in the middle of procesing completion irq*/
 	ipcx = sst_dsp_shim_read_unlocked(hsw->dsp, SST_IPCX);
-	if (ipcx & SST_IPCX_BUSY) {
+	if (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE)) {
 		spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
 		return;
 	}
Signature · 6 lines
1.8.3.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
maintainer Applied
#1 lore raw
Quoted 3 lines · Jie Yang

From: Paweł Piskorski <[email protected]>

Make sure we dont issue IPC when we are processing a response.

Applied, thanks.