hwmon: (gpio-fan) Prevent overflow problem when writing large limits
PATCH 1/1 hwmon: (gpio-fan) Prevent overflow problem when writing large limits
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from unsigned long to int to fix the problem.
Signed-off-by Axel Lin <[email protected]>
--- drivers/hwmon/gpio-fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/gpio-fan.c +1 -1
@@ -173,7 +173,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data)return -ENODEV ; } -static int rpm_to_speed_index (struct gpio_fan_data *fan_data,int rpm) +static int rpm_to_speed_index (struct gpio_fan_data *fan_data,unsigned long rpm) {struct gpio_fan_speed *speed = fan_data->speed;int i;
Signature · 9 lines
1.9.1 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 5 lines · Axel Lin
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from unsigned long to int to fix the problem.
Signed-off-by Axel Lin <[email protected]>
Good catch. Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors