Skip to contentSkip to conversation

staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

PATCH In review Miguel Oliveira 2 participants 2 messages Aug 5, 2014 – Aug 10, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: HalPhyRf_8188e: Fix static symbol sparse warning

Fix sparse warning:
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? by making it static since it's only used once.

---
 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c +1 -1
index 7fa744b..d2bcc16 100644
@@ -22,7 +22,7 @@
 #define		ODM_TXPWRTRACK_MAX_IDX_88E		6
 
 
-u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
+static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
 {
 	u8	channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
 		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 14 lines · Miguel Oliveira

Fix sparse warning:
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol 'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static? by making it static since it's only used once.

---
 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c +0 -0
index 7fa744b..d2bcc16 100644

drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c line 28

Quoted 8 lines
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c +1 -1
@@ -22,7 +22,7 @@
 #define		ODM_TXPWRTRACK_MAX_IDX_88E		6
 
 
-u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
+static u8 ODM_GetRightChnlPlaceforIQK(u8 chnl)
 {
 	u8	channel_all[ODM_TARGET_CHNL_NUM_2G_5G] = {
 		1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,

Someone else made this change already, always work against the linux-next tree :(

thanks,

greg k-h